New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865101 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

A11y: Autofill: ChromeVox does not announce that autofill suggestions are available

Project Member Reported by dsexton@chromium.org, Jul 18

Issue description

Chrome: 69.0.3494.0 (Official Build) Canary

Steps to repro:
# With ChromeVox active (ctrl+alt+z), visit https://rsolomakhin.github.io/autofill/
# Focus the first form field
# Notice that there are suggestions available, but ChromeVox doesn't announce anything different about this edit field
# Type the first letter(s) of a saved name
# Notice that there are suggestions available, but ChromeVox doesn't announce anything different about this edit field

Expected: ChromeVox should indicate that there are autocomplete suggestions available

Actual: Although arrow keys work to open and navigate the menu, the user will not know when the menu is available.
 
Cc: aleventhal@chromium.org
Labels: RegressedIn-69 FoundIn-69
Thanks for the report. This seems to be a recent regression, since a fix was merged to M67 and M68:  crbug.com/848297 .

Would you mind double checking that it's working for M68?
Ping?
Hi Fabio,

I can repro on 67, 68, and 69 on Google_Eve.9584.107.0 and Google_Eve.9584.160.0.

Please let me know if you need me to go back to 66 or if there's anything else I can do to help. 

67.0.3396.99 (Official Build) (64-bit) 
Followed steps above except saved Homer as first name + revisited page
ChromeVox does not indicate that autofill suggestions are available


68.0.3440.70 (Official Build) beta (64-bit) 
ChromeVox does not indicate that autofill suggestions are available


60.0.3494.0 (Official Build) beta (64-bit) 
ChromeVox does not indicate that autofill suggestions are available

Thanks,

Laura 

Hi Laura.

What is the difference between this and  crbug.com/848297 ? It seemed to me that this had been fixed and merged to both 67 and 68.
Cc: leberly@chromium.org
CC'ing Laura Eberly so that she can see the question from Fabio in comment 4.
It appears that 848297 did not resolve the issue. The latest change was checked into 68.0.3440.15 so I reviewed it:  

67.0.3396.99: confirmed that the bug reproduces, does not announce autocomplete
68.0.3440.76: confirmed that the bug reproduces, does not announce autocomplete

Please either reopen the other bug and dupe this out or continue on this bug, your choice.

Thanks,

Laura 




Cc: se...@chromium.org
Is it possible that ChromeVox received an update? The fix was tested by a few people to make sure that it worked, so this is a bit surprising.

Another possible cause might be the new UI. Is it possible to test it with this flag on and off to see if it has an effect? #enable-autofill-native-dropdown-views

Thanks!

Comment 8 Deleted

leberly@: can you please confirm if my diagnosis is correct?

This is not the same issue as  crbug.com/848297 :
 - The closed bug was about announcing suggestions that regressed in M67 - if the user navigates using TAB/DOWN/UP, suggestions will be announced; if they click with the mouse and hover on suggestions, or use DOWN/UP, suggestions are announced as well;
 - This bug is about discoverability - if the dropdown is shown without a selection (either with a mouse click or after the user starts typing on the field), the dropdown is not discoverable.

Other screenreaders will announce that a menu was opened and the user can press the arrow keys to select a suggestion.

Please notice that we send an a11y event when the dropdown is shown, and it looks like it's not been handled by ChromeVOX: https://chromium.googlesource.com/chromium/src/+/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc#682
Cc: durgapandey@chromium.org
Labels: -RegressedIn-69 Target-70 FoundIn-70 FoundIn-68
dtseng@: In the mean time, is there any workaround that will force ChromeVOX to announce a dropdown is present?

In addition, please make sure you enable flag chrome://flags/#enable-autofill-native-dropdown-views - this enables the new dropdown, which will become the default in M69. The old UI will be deleted, most likely in M70 or M71, so it may not be worth finding a general solution for both the new and the old UI.

I'm removing label "RegressedIn-69", because this was not working before either. Adding FoundIn-70, FoundIn-68, Target-70 instead for better tracking.
Fabio, your assessment SGTM. Here's another repro just for good measure:

Google Chrome	69.0.3497.21 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

Steps:
# Enable ChromeVox 
# Enable #enable-autofill-native-dropdown-views
# Navigate to https://rsolomakhin.github.io/autofill/
# Navigate to Profile Autofill, Name: field
# Press down arrow
Expected: dropdown is announced
Actual: nothing is indicated 
1. the menu start event does get handled by ChromeVox. The reason why we know this is because by pressing arrow keys, ChromeVox receives the menu start event and says "auto complete menu opened".

2. The bug here is the fact that the text field (within the DOM of the web page) has not been annotated with the auto complete attribute "aria-autocomplete". Since this is an overlay using native views, there exists the problem. ChromeVox is appropriately reporting the focused item (in this case the text field).
It looks like there was a bit of a hack to hook the auto complete state into the Win/Mac accessibility trees here:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_external_delegate.cc?q=oninputsuggestionsavailable&sq=package:chromium&dr=C&l=179
Unfortunately, that support doesn't translate to anything in Chrome OS including ChromeVox.

Owner: ----
Status: available (was: Assigned)
Labels: a11y-Autofill-and-autocomplete
David, Fabio and I discussed plumbing the information via a state in Blink. Here's a start: https://chromium-review.googlesource.com/c/chromium/src/+/1176621
Cc: vasi...@chromium.org
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849da389d2fa8868b944b84595dac2d041cb6222

commit 849da389d2fa8868b944b84595dac2d041cb6222
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Aug 21 11:34:19 2018

Begin autofill accessibility refactoring

Autofill information should be provided via the renderer, and made
available as a state that can be accessed via automation and ChromeVox.

TBR: spang@chromium.org
Bug: 865101
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifaff2013cd0315eafe2ff2900fbf40765d4863f5
Reviewed-on: https://chromium-review.googlesource.com/1176621
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584717}
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/chromecast/common/extensions_api/automation.idl
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/content/shell/test_runner/web_ax_object_proxy.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/public/web/web_ax_object.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/core/accessibility/ax_object_cache.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/platform/ax_platform_node.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/platform/ax_platform_node.h
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/849da389d2fa8868b944b84595dac2d041cb6222/ui/accessibility/platform/ax_platform_node_win.cc

Owner: seblalancette@chromium.org
Assigning to seblalancette@, who is excited about accessibility!

Sign in to add a comment