Assigned to the current Chrome gardener for triage

+A few folks from Graphics in case this rings any bells.

Sounds more like a toolchain issue than graphics.

Luis, Manoj: Any ideas?

We haven't done a toolchain change recently. Any ideas when did this start?

mka@ Does the problem repro if you pass --nousepkg to build_packages (This will force all packages to be built from source. If the crash disappears, it might be a prebuilt issue)

Note that, this error seems like passing an unaligned pointer somewhere, typically caused by pointer casts e.g. char * -> int * where alignment does not match target type.

I have seen a few such such crashes in the code where compiler generated neon memory loads/stores where the code didn't specify the correct alignment.
e.g. https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/496366
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/568779

I'm rebuilding with '--nousepkg', but it will take a while.

Can't really say when this started, I haven't built a scarlet/rk3399 image for a longer time. Usually I use an image from goldeneye as starting point, which wouldn't have the issue.

The issue still occurs when building with '--nousepkg'.

FYI: I synced up and build kevin in my chroot (in an incremental build).  I can confirm the same behavior Matthias is seeing.


The fact that things work when you build with USE="chrome_internal" seems like a huge clue here.  That shouldn't affect any toolchain or anything else.

BTW: This seems like a pretty serious issue that will affect lots of developers.  P0 might be overkill, but not by much.  Leaving as P1 for now, but IMO this should be considered pretty high priority.

In theory someone good at building Chrome could bisect this without too much trouble to figure out which version of chromium this was introduced in.

I tried to repro the issue with gdb and got the following back trace but have no idea if this back trace is pointing to the cause of alignment errors.

This line seems to be of interest https://cs.chromium.org/chromium/src/third_party/icu/source/i18n/number_decimfmtprops.cpp?l=23 since it does placement new using an existing char buffer.

Another interesting thing to note is that the icu code was recently updated in chromium (https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503)


thread 12.1 received signal SIGABRT, Aborted.
__libc_do_syscall () at ../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S:47
47      in ../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S
(gdb) bt
#0  __libc_do_syscall () at ../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S:47
#1  0xf1c3b5b2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#2  0xf1c3c37a in __GI_abort () at abort.c:89
#3  0x0fb11d08 in base::debug::BreakDebugger ()
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/debug/debugger_posix.cc:258
#4  0x0fb127a2 in base::debug::(anonymous namespace)::StackDumpSignalHandler (signal=6, info=<optimized out>, void_context=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/debug/stack_trace_posix.cc:257
#5  <signal handler called>
#6  __libc_do_syscall () at ../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S:47
#7  0xf1c3b5b2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#8  0xf1c3c37a in __GI_abort () at abort.c:89
#9  0x0fb11d08 in base::debug::BreakDebugger ()
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/debug/debugger_posix.cc:258
#10 0x0fb127a2 in base::debug::(anonymous namespace)::StackDumpSignalHandler (signal=7, info=<optimized out>, void_context=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/debug/stack_trace_posix.cc:257
#11 <signal handler called>
#12 icu_62::MeasureUnit::MeasureUnit (this=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/measunit.cpp:1125
#13 icu_62::CurrencyUnit::CurrencyUnit (this=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/currunit.cpp:65
#14 icu_62::number::impl::NullableValue<icu_62::CurrencyUnit>::NullableValue (
    this=0x147b5661 <(anonymous namespace)::kRawDefaultProperties+8>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/number_types.h:239
#15 icu_62::number::impl::DecimalFormatProperties::DecimalFormatProperties (this=0x147b5659 <(anonymous namespace)::kRawDefaultProperties>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/number_decimfmtprops.cpp:29
#16 (anonymous namespace)::initDefaultProperties ()
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/number_decimfmtprops.cpp:23
#17 icu_62::umtx_initOnce (uio=..., fp=<optimized out>, errCode=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/common/umutex.h:267
#18 icu_62::number::impl::DecimalFormatProperties::equalsDefaultExceptFastFormat (this=0x15235500)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/number_decimfmtprops.cpp:140
#19 0x0fdaf5d6 in icu_62::DecimalFormat::setupFastFormat (this=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/decimfmt.cpp:1264
#20 icu_62::DecimalFormat::touch (this=0x15382480, status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/decimfmt.cpp:1148
#21 0x0fdaf9d6 in icu_62::DecimalFormat::DecimalFormat (this=0x15382480, pattern=..., symbolsToAdopt=<optimized out>, 
    style=<optimized out>, status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/decimfmt.cpp:95
#22 0x0fdd4dd6 in icu_62::NumberFormat::makeInstance (desiredLocale=..., style=UNUM_DECIMAL, mustBeDecimalFormat=0 '\000', 
    status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1467
#23 0x0fdd4428 in icu_62::NumberFormat::makeInstance (desiredLocale=..., style=<optimized out>, status=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1296
#24 icu_62::NumberFormat::internalCreateInstance (loc=..., kind=UNUM_DECIMAL, status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1047
#25 0x0fdd4724 in icu_62::LocaleCacheKey<icu_62::SharedNumberFormat>::createObject (this=<optimized out>, 
    status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1258
#26 0x123a0bd2 in icu_62::UnifiedCache::_get (this=0x153b3c00, key=..., value=@0xfff60118: 0x0, creationContext=0x0, 
    status=@0xfff6011c: U_USING_DEFAULT_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/common/unifiedcache.cpp:391
#27 0x0fdd452e in icu_62::UnifiedCache::get<icu_62::SharedNumberFormat> (this=0x153b3c00, key=..., creationContext=0x0, 
    status=<optimized out>, ptr=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/common/unifiedcache.h:234
#28 icu_62::UnifiedCache::get<icu_62::SharedNumberFormat> (this=0x153b3c00, key=..., status=<optimized out>, ptr=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/common/unifiedcache.h:206
#29 icu_62::UnifiedCache::getByLocale<icu_62::SharedNumberFormat> (loc=..., status=<optimized out>, ptr=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/common/unifiedcache.h:274
#30 icu_62::NumberFormat::createSharedInstance (loc=..., kind=<optimized out>, status=@0xfff603f8: U_USING_FALLBACK_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1283
#31 0x0fdd4218 in icu_62::NumberFormat::createInstance (loc=..., kind=UNUM_DECIMAL, status=@0xfff603f8: U_USING_FALLBACK_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:1055
#32 icu_62::NumberFormat::createInstance (inLocale=..., status=@0xfff603f8: U_USING_FALLBACK_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/numfmt.cpp:785
#33 0x0fdf798c in icu_62::SimpleDateFormat::initialize (this=0x152b4180, locale=..., status=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/smpdtfmt.cpp:861
#34 0x0fdf892a in icu_62::SimpleDateFormat::construct (this=<optimized out>, timeStyle=<optimized out>, dateStyle=<optimized out>, 
    locale=..., status=@0xfff603f8: U_USING_FALLBACK_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/smpdtfmt.cpp:839
#35 icu_62::SimpleDateFormat::SimpleDateFormat (this=0x152b4180, timeStyle=icu_62::DateFormat::kShort, 
    dateStyle=icu_62::DateFormat::kNone, locale=..., status=@0xfff603f8: U_USING_FALLBACK_WARNING)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/smpdtfmt.cpp:499
#36 0x0fdaec76 in icu_62::DateFormat::create (timeStyle=icu_62::DateFormat::kShort, dateStyle=icu_62::DateFormat::kNone, locale=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/datefmt.cpp:526
#37 0x0fe9b5a2 in icu_62::DateFormat::createDateTimeInstance (dateStyle=icu_62::DateFormat::kNone, timeStyle=icu_62::DateFormat::kShort, 
    aLocale=...) at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/datefmt.cpp:416
#38 icu_62::DateFormat::createTimeInstance (style=icu_62::DateFormat::kShort, aLocale=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/icu/source/i18n/datefmt.cpp:393
#39 base::GetHourClockType () at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/i18n/time_formatting.cc:267
#40 0x11315d74 in ash::ClockModel::ClockModel (this=0x153b3bd0)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/ash/system/model/clock_model.cc:15
---Type <return> to continue, or q <return> to quit---
#41 0x1124ae1c in std::__1::make_unique<ash::ClockModel> () at /usr/bin/../include/c++/v1/memory:3011
#42 ash::SystemTrayModel::SystemTrayModel (this=0x15264420)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/ash/system/model/system_tray_model.cc:24
#43 0x1123ac30 in std::__1::make_unique<ash::SystemTrayModel> () at /usr/bin/../include/c++/v1/memory:3011
#44 ash::Shell::Init (this=0x150f7b80, context_factory=0x150f7b88, 
    context_factory_private=0x147aff48 <_ZN4base12_GLOBAL__N_123g_feature_list_instanceE.llvm.4975689307642247704>, 
    initial_display_prefs=..., gpu_interface_provider=..., connector=0x0)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/ash/shell.cc:1262
#45 0x1123939e in ash::Shell::CreateInstance (init_params=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/ash/shell.cc:280
#46 0x1154df48 in (anonymous namespace)::CreateClassicShell ()
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/ui/ash/ash_shell_init.cc:38
#47 AshShellInit::AshShellInit (this=0x1510c5e0)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/ui/ash/ash_shell_init.cc:51
#48 0x1154e876 in std::__1::make_unique<AshShellInit> () at /usr/bin/../include/c++/v1/memory:3011
#49 ChromeBrowserMainExtraPartsAsh::PreProfileInit (this=0x15036d20)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:172
#50 0x0f8620e0 in ChromeBrowserMainParts::PreProfileInit (this=0x15061750)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chrome_browser_main.cc:1432
#51 0x0ee7453c in ChromeBrowserMainPartsLinux::PreProfileInit (this=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chrome_browser_main_linux.cc:85
#52 chromeos::ChromeBrowserMainPartsChromeos::PreProfileInit (this=0x15061750)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc:787
#53 0x0f861214 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl (this=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chrome_browser_main.cc:1720
#54 ChromeBrowserMainParts::PreMainMessageLoopRun (this=0x15061750)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chrome_browser_main.cc:1411
#55 0x0ee740f2 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun (this=0x15061750)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc:688
#56 0x0e6994f6 in content::BrowserMainLoop::PreMainMessageLoopRun (this=0x1505cd00)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/browser/browser_main_loop.cc:1006
#57 0x0e96a7d4 in base::RepeatingCallback<int ()>::Run() const & (this=0x15111d98)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/base/callback.h:129
#58 content::StartupTaskRunner::RunAllTasksNow (this=0x150ecd40)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/browser/startup_task_runner.cc:43
#59 0x0e697200 in content::BrowserMainLoop::CreateStartupTasks (this=0x1505cd00)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/browser/browser_main_loop.cc:917
#60 0x0e69b1d0 in content::BrowserMainRunnerImpl::Initialize (this=<optimized out>, parameters=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/browser/browser_main_runner_impl.cc:141
#61 0x0e694e16 in content::BrowserMain (parameters=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/browser/browser_main.cc:43
#62 0x0f855866 in content::RunBrowserProcessMain (main_function_params=..., delegate=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/app/content_main_runner_impl.cc:596
#63 content::ContentMainRunnerImpl::Run (this=<optimized out>, start_service_manager_only=<optimized out>)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/app/content_main_runner_impl.cc:947
#64 0x0f85b2b6 in service_manager::Main (params=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/services/service_manager/embedder/main.cc:472
#65 0x0f854a18 in content::ContentMain (params=...)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/content/app/content_main.cc:19
#66 0x0df58980 in ChromeMain (argc=40, argv=0xfff61654)
    at ../../../../../chromeos-cache/distfiles/target/chrome-src/src/chrome/app/chrome_main.cc:101
#67 0xf1c2c8a0 in __libc_start_main (main=0xdf58909 <main(int, char const**)>, argc=40, argv=0xfff61654, init=<optimized out>, 
    fini=0x133d910d <__libc_csu_fini>, rtld_fini=0xf219b059 <_dl_fini>, stack_end=0xfff61654) at libc-start.c:289
#68 0x0df4a8a8 in _start ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Pushing (non-official) chromium through simple chrome workflow to an image built with USE=chrome_internal does not cause any problems. Still suspecting some toolchain issues rather than things like ICU.

@13: I'm confused about how it can be a toolchain issue when I can do a build in the same choot and it works with USE=chrome_internal and fails without it.  It's not like chrome_internal is changing the toolchain.

mukai@ why do you think this is a toolchain issue. The stack trace is pretty clear that there is a bug in icu code. It may not be the only issue here though.

More details:

char array used in placement new is not aligned to alignment needed by DecimalFormatProperties

23          new(kRawDefaultProperties) DecimalFormatProperties(); // set to the default instance
(gdb) p &kRawDefaultProperties
$1 = (char (*)[736]) 0x10dc1659 <(anonymous namespace)::kRawDefaultProperties>
// aligned to 1 byte, not 8 bytes.

Assigning to jshin@ to fix icu code.

Btw, I made a local build with this patch and it has fixed the crash.

diff --git a/source/i18n/number_decimfmtprops.cpp b/source/i18n/number_decimfmtprops.cpp
index 6754fe19..b8994e56 100644
--- a/source/i18n/number_decimfmtprops.cpp
+++ b/source/i18n/number_decimfmtprops.cpp
@@ -15,7 +15,7 @@ using namespace icu::number::impl;
 
 namespace {
 
-char kRawDefaultProperties[sizeof(DecimalFormatProperties)];
+alignas(DecimalFormatProperties) char kRawDefaultProperties[sizeof(DecimalFormatProperties)];
 
 icu::UInitOnce gDefaultPropertiesInitOnce = U_INITONCE_INITIALIZER;

Thanks Manoj for investigating and implementing a fix!

sffc@ : who wrote the code in question :-) 

This is seriously affecting developer productivity.  It has been confirmed to affect other arm64 boards besides those in the gru family everyone is needing to discover and debug this problem separately.  It seems like there is no reason we can't land the fix at <https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1145582>, is there?  Bumping this priority up in case that helps land the change a little sooner.

Then let's revert the ICU update. See https://chromium-review.googlesource.com/c/chromium/src/+/1145737

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1145582 is a CL. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/297a4dd02b9d36c92ab9b4f121e433c9c3bc14f8

commit 297a4dd02b9d36c92ab9b4f121e433c9c3bc14f8
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Jul 23 17:25:48 2018

i18n: Fix a crash because of unaligned memory accesses.

The buffer used in placement new should have the same alignment
as the underlying type DecimalFormatProperties.
Fixes login crashes in Chrome OS.

BUG= chromium:865100 
TEST=locally built chrome os image works.

Change-Id: Ic71cb4e7962f1b9170e0a4ef00223767c621bc67
Reviewed-on: https://chromium-review.googlesource.com/1145582
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/297a4dd02b9d36c92ab9b4f121e433c9c3bc14f8/README.chromium
[add] https://crrev.com/297a4dd02b9d36c92ab9b4f121e433c9c3bc14f8/patches/decimalformat_align.patch
[modify] https://crrev.com/297a4dd02b9d36c92ab9b4f121e433c9c3bc14f8/source/i18n/number_decimfmtprops.cpp

Request merging to 69.

ICU roll CL is in CQ. 

https://chromium-review.googlesource.com/c/chromium/src/+/1147108 

69 branch DEPS file will be updated as well once approved. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d7a83a3c7bdfeff08273c972b3e32a9b1911bd6

commit 8d7a83a3c7bdfeff08273c972b3e32a9b1911bd6
Author: Jungshik Shin <jshin@chromium.org>
Date: Mon Jul 23 21:29:16 2018

Roll ICU to 297a4dd02b

For actual changes, see

  https://chromium-review.googlesource.com/1145582

TBR=manojgupta@chromium.org
BUG= chromium:865100 
TEST=locally built chrome os image works.

Change-Id: Ifeaa0092937977fbb942741b1f348845c1e4596f
Reviewed-on: https://chromium-review.googlesource.com/1147108
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577267}
[modify] https://crrev.com/8d7a83a3c7bdfeff08273c972b3e32a9b1911bd6/DEPS

To be merged to 69 branch (branch DEPS roll) once approved. 

Thanks for fixing.  This is a known issue, and the fix is the same as the one proposed for ICU: https://unicode-org.atlassian.net/browse/ICU-20001

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge for M69.

jshin@ Can you merge the fix to 69 branch?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860c55a1c94c0df106e70c95d13f54246d26c386

commit 860c55a1c94c0df106e70c95d13f54246d26c386
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Jul 27 17:05:37 2018

[M69 merge] Roll ICU to 297a4dd02b

For actual changes, see

  https://chromium-review.googlesource.com/1145582

TBR=manojgupta@chromium.org
BUG= chromium:865100 
TEST=locally built chrome os image works.

Change-Id: Ifeaa0092937977fbb942741b1f348845c1e4596f
Reviewed-on: https://chromium-review.googlesource.com/1147108
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577267}(cherry picked from commit 8d7a83a3c7bdfeff08273c972b3e32a9b1911bd6)
Reviewed-on: https://chromium-review.googlesource.com/1153220
Cr-Commit-Position: refs/branch-heads/3497@{#160}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/860c55a1c94c0df106e70c95d13f54246d26c386/DEPS

Just done. In the past, I need to roll ICU in buildspec/ repos for branch (3497 in this case), but it seems that it's a lot simpler. We can just use gerrit to cherry-pick DEPS roll CL to a branch.