New issue
Advanced search Search tips

Issue 865098 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature

Blocked on: View detail
issue 866868
issue v8:8041



Sign in to add a comment

Tracking bug for improvements to ScriptStreaming

Project Member Reported by rmcilroy@chromium.org, Jul 18

Issue description

Tracking some of the work we are doing to increase the amount of scripts that are streamed off-thread using the ScriptStreamer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dbc3cfeab2a55589012d661336787b248ef7f6d

commit 3dbc3cfeab2a55589012d661336787b248ef7f6d
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Mon Jul 23 23:34:07 2018

Split HTMLParserScriptRunner::ExecutePendingScriptAndDispatchEvent

Before this CL, ExecutePendingScriptAndDispatchEvent() implements
two different spec concept depending on its two call sites, and
ScriptStreamer::Type parameter is used just to distinguish the
two call sites.

This CL splits the method into two (one for each call site),
to remove unnecessary dependency to ScriptStreamer::Type and
make spec correspondence clearer.

Bug: 865098, 686281
Change-Id: I2ddb10ebe4c20861121d42d11d4a83cb349c3369
Reviewed-on: https://chromium-review.googlesource.com/1144462
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577316}
[modify] https://crrev.com/3dbc3cfeab2a55589012d661336787b248ef7f6d/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/3dbc3cfeab2a55589012d661336787b248ef7f6d/third_party/blink/renderer/core/script/html_parser_script_runner.h

Blockedon: 866868
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e

commit 3b4d46e39cb5daa0b48242dc30f4c6c910cee25e
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Jul 24 15:09:59 2018

[blink] Use scheduler for script streaming

Add a new feature flag, ScheduledScriptStreaming, which makes the script
streamer use the task scheduler for streaming tasks, rather than using a
dedicated ScriptStreamerThread.

Bug: chromium:865098
Bug: chromium:866868
Change-Id: I05ca411d8d5187c4b5180011ebce2a603e3944fe
Reviewed-on: https://chromium-review.googlesource.com/1145386
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577543}
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/content/child/runtime_features.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/content/public/common/content_features.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/content/public/common/content_features.h
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/3b4d46e39cb5daa0b48242dc30f4c6c910cee25e/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dee012cfe5748e0dab658267fc55c9910ad2418

commit 4dee012cfe5748e0dab658267fc55c9910ad2418
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Wed Jul 25 00:27:49 2018

[ScriptStreamer] Better histogram tracking of reason scripts aren't streamed

Currently the NotStreamingReason histogram is only recorded if we try to
start streaming a script, and is not updated for various situations where
we cancel streaming a script (e.g., we have a code-cache for the script).

This CL updates the tracking such that we record the reason script streaming
wasn't started, or was suppressed, and then record this in the histogram
when calling GetSource() on the ClassicPendingScript.

As part of this change, the logic for recording these histograms is moved
from ScriptStreamer to ClassicPendingScript. The ScriptStreamer::Type enum is
also moved to PendingScript and renamed ExecutionType, since it is no longer
used by the ScriptStreamer class.

BUG=865098

Change-Id: I20979352c6976e489d051a8432bbc51c39f428b0
Reviewed-on: https://chromium-review.googlesource.com/1142158
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577744}
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/html_parser_script_runner.h
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/third_party/blink/renderer/core/script/script_runner_test.cc
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/4dee012cfe5748e0dab658267fc55c9910ad2418/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d2aca012664d3ba22ed109f8b3cd8920ed0988c

commit 0d2aca012664d3ba22ed109f8b3cd8920ed0988c
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Wed Jul 25 05:29:58 2018

[ScriptStreamer] Propagate NotStreamingReason to v8.compile trace event.

Enables tracking of why a particular script was not parsed / compiled by the
ScriptStreamer.

BUG=865098

Change-Id: I1a1b033689d0f12df4f28ff5c4bb21243cbec197
Reviewed-on: https://chromium-review.googlesource.com/1143762
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577808}
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/bindings/core/v8/script_source_code.cc
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/bindings/core/v8/script_source_code.h
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/0d2aca012664d3ba22ed109f8b3cd8920ed0988c/third_party/blink/renderer/core/script/classic_pending_script.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567d05d238b73a051114bc59412d104b3d3fbdea

commit 567d05d238b73a051114bc59412d104b3d3fbdea
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Wed Jul 25 23:46:43 2018

[ScriptStreamer] Unify logic for deciding whether resource has a code cache.

Only suppress streaming in the cases where V8 will actually consume the code
code cache. It is no longer necessary to suppress it when we might want to
produce a code cache.

BUG=865098

Change-Id: I5ac4e798d7c7a732f87e0520ec4221da2646ae3e
Reviewed-on: https://chromium-review.googlesource.com/1149360
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578130}
[modify] https://crrev.com/567d05d238b73a051114bc59412d104b3d3fbdea/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/567d05d238b73a051114bc59412d104b3d3fbdea/third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
[modify] https://crrev.com/567d05d238b73a051114bc59412d104b3d3fbdea/third_party/blink/renderer/bindings/core/v8/v8_code_cache.h

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20f9a30606d80e1059c2976e73cc99f7de7d76e

commit f20f9a30606d80e1059c2976e73cc99f7de7d76e
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Fri Aug 03 07:15:37 2018

[ScriptStreaming] Stream small scripts when ScheduledScriptStreaming is enabled.

With scheduled script streaming and background compilation it is now worthwhile to
stream smaller scripts. Enable support for streaming these smaller scripts when
the ScheduledScriptStreaming trial is enabled to investigate performance impact.

BUG=chromium:865098

Change-Id: Ia7691dbe9f8dd970aafda2715a34edc3ef16616b
Reviewed-on: https://chromium-review.googlesource.com/1160653
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580466}
[modify] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/083c5a6cf7a2f3848f110d19e7e14946bf005514

commit 083c5a6cf7a2f3848f110d19e7e14946bf005514
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Mon Aug 06 15:10:21 2018

[Compile] Track cases where a script is in the isolate cache but was streaming parse/compiled.

We want to limit these cases since they result in unecessary work on background threads
doing the streaming parse / compile, and delay the script execution unecessarily
while waiting for the streamer to complete.

BUG=chromium:865098

Change-Id: Ibb3346c2e644bb333521d876d00aeb9cc063b6aa
Reviewed-on: https://chromium-review.googlesource.com/1163669
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54929}
[modify] https://crrev.com/083c5a6cf7a2f3848f110d19e7e14946bf005514/src/compiler.cc
[modify] https://crrev.com/083c5a6cf7a2f3848f110d19e7e14946bf005514/src/counters.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68bed4d18855b41a7b089b8cdd26dddd86d051b2

commit 68bed4d18855b41a7b089b8cdd26dddd86d051b2
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Mon Aug 06 15:48:52 2018

[Metrics] Add entry to V8CacheBehaviour enum.

Adds kHitIsolateCacheWhenStreamingSource.

BUG=chromium:865098
TBR=delphick@chromium.org

Change-Id: I9112410a1ddf9b9f56667a7880152d306d4a2612
Reviewed-on: https://chromium-review.googlesource.com/1163672
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580883}
[modify] https://crrev.com/68bed4d18855b41a7b089b8cdd26dddd86d051b2/tools/metrics/histograms/enums.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31aa16cc8b1b130853d6025070a2bbc76dd4c6e8

commit 31aa16cc8b1b130853d6025070a2bbc76dd4c6e8
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Thu Aug 09 13:11:43 2018

[ScriptStreaming] Fix incorrect DCHECK.

ready_state_ could be kErrorOccured as well as kReadyStreaming. Update the
logic to check for this and add a new NotStreamingReason to log it.

BUG=chromium:865098,chromium:871276

Change-Id: I7f4e17c843b74632d4cf167664f26fdb92f30a8c
Reviewed-on: https://chromium-review.googlesource.com/1164943
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581882}
[modify] https://crrev.com/31aa16cc8b1b130853d6025070a2bbc76dd4c6e8/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/31aa16cc8b1b130853d6025070a2bbc76dd4c6e8/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/31aa16cc8b1b130853d6025070a2bbc76dd4c6e8/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/31aa16cc8b1b130853d6025070a2bbc76dd4c6e8/tools/metrics/histograms/enums.xml

Blockedon: v8:8041
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5912b768395ab595274c932bd653f9e47a93ec1c

commit 5912b768395ab595274c932bd653f9e47a93ec1c
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Aug 16 14:56:13 2018

[v8] Re-post non-blocking ScriptStreamer tasks

Posted blocking ScriptStreamer tasks can end up in a queue, and have
their Resource complete loading before the task even starts. When this
happens, these tasks will no longer block on network input, but they
will still be posted to the blocking task runner, which does not spin up
new threads if the running task is not blocked. When there are a lot of
small functions posted for streaming, this results in a slightly
paradoxical starvation, where the blocking task runner is processing
lots of no-longer-blocking tasks all in one thread, as it has no reason
to spin up new threads.

To avoid this, if a streaming task isn't started before the resource
finishes loading, we can cancel this posted task, and instead post a new
non-blocking task to the non-blocking thread pool. This frees up the
blocking task runner to process only blocking tasks (and thus allows it
to spin up new threads for them).

Bug: chromium:865098
Bug: chromium:866868
Change-Id: Iceb282582781109ade233366d1009c3be50db3a5
Reviewed-on: https://chromium-review.googlesource.com/1174380
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583649}
[modify] https://crrev.com/5912b768395ab595274c932bd653f9e47a93ec1c/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/5912b768395ab595274c932bd653f9e47a93ec1c/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ecc7f1995431a135519633994c45195334bd48

commit 63ecc7f1995431a135519633994c45195334bd48
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Aug 17 08:55:59 2018

Revert "[v8] Re-post non-blocking ScriptStreamer tasks"

This reverts commit 5912b768395ab595274c932bd653f9e47a93ec1c.

Reason for revert: Seems to cause Scanner crashes

Original change's description:
> [v8] Re-post non-blocking ScriptStreamer tasks
> 
> Posted blocking ScriptStreamer tasks can end up in a queue, and have
> their Resource complete loading before the task even starts. When this
> happens, these tasks will no longer block on network input, but they
> will still be posted to the blocking task runner, which does not spin up
> new threads if the running task is not blocked. When there are a lot of
> small functions posted for streaming, this results in a slightly
> paradoxical starvation, where the blocking task runner is processing
> lots of no-longer-blocking tasks all in one thread, as it has no reason
> to spin up new threads.
> 
> To avoid this, if a streaming task isn't started before the resource
> finishes loading, we can cancel this posted task, and instead post a new
> non-blocking task to the non-blocking thread pool. This frees up the
> blocking task runner to process only blocking tasks (and thus allows it
> to spin up new threads for them).
> 
> Bug: chromium:865098
> Bug: chromium:866868
> Change-Id: Iceb282582781109ade233366d1009c3be50db3a5
> Reviewed-on: https://chromium-review.googlesource.com/1174380
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583649}

TBR=skyostil@google.com,gab@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,skyostil@chromium.org,altimin@chromium.org,leszeks@chromium.org

Change-Id: Iffbab7a8994d12ffce53c6b5b76d19f4db79df0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098, chromium:866868, chromium:875162
Reviewed-on: https://chromium-review.googlesource.com/1179641
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583995}
[modify] https://crrev.com/63ecc7f1995431a135519633994c45195334bd48/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/63ecc7f1995431a135519633994c45195334bd48/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Cc: marja@chromium.org
 Issue 859479  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bab18044ca5689ac72a05883051d23b9f354df

commit 04bab18044ca5689ac72a05883051d23b9f354df
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Aug 17 12:47:51 2018

[v8] Re-post non-blocking ScriptStreamer tasks (reland)

Posted blocking ScriptStreamer tasks can end up in a queue, and have
their Resource complete loading before the task even starts. When this
happens, these tasks will no longer block on network input, but they
will still be posted to the blocking task runner, which does not spin up
new threads if the running task is not blocked. When there are a lot of
small functions posted for streaming, this results in a slightly
paradoxical starvation, where the blocking task runner is processing
lots of no-longer-blocking tasks all in one thread, as it has no reason
to spin up new threads.

To avoid this, if a streaming task isn't started before the resource
finishes loading, we can cancel this posted task, and instead post a new
non-blocking task to the non-blocking thread pool. This frees up the
blocking task runner to process only blocking tasks (and thus allows it
to spin up new threads for them).

TBR=kouhei@chromium.org

Bug: chromium:865098
Bug: chromium:866868
Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb
Reviewed-on: https://chromium-review.googlesource.com/1179744
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584032}
[modify] https://crrev.com/04bab18044ca5689ac72a05883051d23b9f354df/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/04bab18044ca5689ac72a05883051d23b9f354df/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 17

Labels: merge-merged-3525
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bccb734e64c0e701ee8c795fa11fa2a040bf6c3

commit 2bccb734e64c0e701ee8c795fa11fa2a040bf6c3
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Aug 17 13:50:56 2018

Revert "[v8] Re-post non-blocking ScriptStreamer tasks"

This reverts commit 5912b768395ab595274c932bd653f9e47a93ec1c.

Reason for revert: Seems to cause Scanner crashes

Original change's description:
> [v8] Re-post non-blocking ScriptStreamer tasks
> 
> Posted blocking ScriptStreamer tasks can end up in a queue, and have
> their Resource complete loading before the task even starts. When this
> happens, these tasks will no longer block on network input, but they
> will still be posted to the blocking task runner, which does not spin up
> new threads if the running task is not blocked. When there are a lot of
> small functions posted for streaming, this results in a slightly
> paradoxical starvation, where the blocking task runner is processing
> lots of no-longer-blocking tasks all in one thread, as it has no reason
> to spin up new threads.
> 
> To avoid this, if a streaming task isn't started before the resource
> finishes loading, we can cancel this posted task, and instead post a new
> non-blocking task to the non-blocking thread pool. This frees up the
> blocking task runner to process only blocking tasks (and thus allows it
> to spin up new threads for them).
> 
> Bug: chromium:865098
> Bug: chromium:866868
> Change-Id: Iceb282582781109ade233366d1009c3be50db3a5
> Reviewed-on: https://chromium-review.googlesource.com/1174380
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583649}

TBR=skyostil@google.com,gab@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,skyostil@chromium.org,altimin@chromium.org,leszeks@chromium.org

Change-Id: Iffbab7a8994d12ffce53c6b5b76d19f4db79df0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098, chromium:866868, chromium:875162
Reviewed-on: https://chromium-review.googlesource.com/1179641
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583995}(cherry picked from commit 63ecc7f1995431a135519633994c45195334bd48)
Reviewed-on: https://chromium-review.googlesource.com/1179841
Cr-Commit-Position: refs/branch-heads/3525@{#3}
Cr-Branched-From: f7f1772a44a00254f19f4ddae1f8890ef766e1e3-refs/heads/master@{#583911}
[modify] https://crrev.com/2bccb734e64c0e701ee8c795fa11fa2a040bf6c3/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/2bccb734e64c0e701ee8c795fa11fa2a040bf6c3/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a8f0de5a522de005b33c48f7937f56f88f753b

commit 35a8f0de5a522de005b33c48f7937f56f88f753b
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Thu Sep 06 20:22:41 2018

Revert "[v8] Re-post non-blocking ScriptStreamer tasks (reland)"

This reverts commit 04bab18044ca5689ac72a05883051d23b9f354df.

Reason for revert: Failing DCHECKs by blocking on non-blocking task.
BUG:878750

Original change's description:
> [v8] Re-post non-blocking ScriptStreamer tasks (reland)
> 
> Posted blocking ScriptStreamer tasks can end up in a queue, and have
> their Resource complete loading before the task even starts. When this
> happens, these tasks will no longer block on network input, but they
> will still be posted to the blocking task runner, which does not spin up
> new threads if the running task is not blocked. When there are a lot of
> small functions posted for streaming, this results in a slightly
> paradoxical starvation, where the blocking task runner is processing
> lots of no-longer-blocking tasks all in one thread, as it has no reason
> to spin up new threads.
> 
> To avoid this, if a streaming task isn't started before the resource
> finishes loading, we can cancel this posted task, and instead post a new
> non-blocking task to the non-blocking thread pool. This frees up the
> blocking task runner to process only blocking tasks (and thus allows it
> to spin up new threads for them).
> 
> TBR=kouhei@chromium.org
> 
> Bug: chromium:865098
> Bug: chromium:866868
> Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb
> Reviewed-on: https://chromium-review.googlesource.com/1179744
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584032}

TBR=rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,leszeks@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:865098, chromium:866868
Change-Id: I8c26832b131cf8997c304422eb0324bb0770b947
Reviewed-on: https://chromium-review.googlesource.com/1211582
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589272}
[modify] https://crrev.com/35a8f0de5a522de005b33c48f7937f56f88f753b/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/35a8f0de5a522de005b33c48f7937f56f88f753b/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04d3c8a8192852302b61d3b4ca532d7920030677

commit 04d3c8a8192852302b61d3b4ca532d7920030677
Author: Leszek Swirski <leszeks@chromium.org>
Date: Mon Sep 10 18:18:42 2018

[v8] Re-post non-blocking ScriptStreamer tasks (reland^2)

Posted blocking ScriptStreamer tasks can end up in a queue, and have
their Resource complete loading before the task even starts. When this
happens, these tasks will no longer block on network input, but they
will still be posted to the blocking task runner, which does not spin up
new threads if the running task is not blocked. When there are a lot of
small functions posted for streaming, this results in a slightly
paradoxical starvation, where the blocking task runner is processing
lots of no-longer-blocking tasks all in one thread, as it has no reason
to spin up new threads.

To avoid this, if a streaming task isn't started before the resource
finishes loading, we can cancel this posted task, and instead post a new
non-blocking task to the non-blocking thread pool. This frees up the
blocking task runner to process only blocking tasks (and thus allows it
to spin up new threads for them).

TBR=kouhei@chromium.org

Bug: chromium:865098
Bug: chromium:866868
Change-Id: Ia955fb7a5fd7a6dfdac6a21d8d866b1d1699054d
Reviewed-on: https://chromium-review.googlesource.com/1216963
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589984}
[modify] https://crrev.com/04d3c8a8192852302b61d3b4ca532d7920030677/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/04d3c8a8192852302b61d3b4ca532d7920030677/third_party/blink/renderer/bindings/core/v8/script_streamer.h

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7754eebac7ee83d2fca463da5512fb5ba43c762d

commit 7754eebac7ee83d2fca463da5512fb5ba43c762d
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Sep 12 15:27:43 2018

[blink] Remove ScriptStreamer's ScriptState dependency

In preparation of detaching ScriptStreamer from ClassicPendingScript,
remove the has V8 context check from streaming compilation (as V8
doesn't need a context for compilation), and thus remove the
ScriptState from ScriptStreamer. Also, remove an unused Settings
parameter.

Bug: chromium:865098
Change-Id: I1dcce15d9bb9cfd0caf4be495351061db654f884
Reviewed-on: https://chromium-review.googlesource.com/1219491
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590687}
[modify] https://crrev.com/7754eebac7ee83d2fca463da5512fb5ba43c762d/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/7754eebac7ee83d2fca463da5512fb5ba43c762d/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/7754eebac7ee83d2fca463da5512fb5ba43c762d/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/7754eebac7ee83d2fca463da5512fb5ba43c762d/third_party/blink/renderer/core/script/classic_pending_script.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb2bb6769b38736fc75a12c15563c4a69f1a61f

commit 7eb2bb6769b38736fc75a12c15563c4a69f1a61f
Author: Leszek Swirski <leszeks@chromium.org>
Date: Mon Sep 17 15:26:00 2018

[config] Enable scheduled script streaming field trial

Start a field trial for scheduled script streaming, where script
streaming uses the task scheduler rather than a dedicated streaming
thread.

Enabling this flag will:

  * Post script streaming tasks as MayBlock using PostTask
  * Re-post those tasks as non-MayBlock if the resource finishes
    loading before the task starts
  * Remove the small script heuristic for streaming

Bug: chromium:866868
Bug: chromium:865098
Change-Id: Id12d052623b5ebf9a1924cc2065807fede718014
Reviewed-on: https://chromium-review.googlesource.com/1226604
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591681}
[modify] https://crrev.com/7eb2bb6769b38736fc75a12c15563c4a69f1a61f/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516840902587453313f53e6b0b45442bebc5b8e8

commit 516840902587453313f53e6b0b45442bebc5b8e8
Author: Leszek Swirski <leszeks@chromium.org>
Date: Sat Sep 22 17:57:12 2018

[blink] Re-enable small script streaming heuristic

Currently, the small script streaming disabled heuristic is disabled for
the scheduled script streaming flag. Remove this for now, so that we can
test the scheduling perf impact independently from heuristic changes.

Bug: chromium:865098
Bug: chromium:866868
Change-Id: Ib3974ebe6d28dadb8421e75fd13801e0d916de24
Reviewed-on: https://chromium-review.googlesource.com/1238435
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593444}
[modify] https://crrev.com/516840902587453313f53e6b0b45442bebc5b8e8/third_party/blink/renderer/bindings/core/v8/script_streamer.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd9163502462762e58d8010577dbf36aeef6c13

commit 7bd9163502462762e58d8010577dbf36aeef6c13
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Oct 12 09:03:00 2018

[blink] Control ScriptStreamer with ScriptResource

Move the ScriptStreamer control logic from ClassicPendingScript to
ScriptResource. In the future, this will allow us to start streaming
a ScriptResource before the ClassicPendingScript is available, e.g on
preload.

The ClassicPendingScript now only sends one "finished" callback, from
ScriptResource. This callback is either when the streaming completes,
or when there is no streaming and the ClassicPendingScript has told
the ScriptResource that it doesn't intend to start streaming. In the
long run, we want all scripts to go through the streaming interface,
and we want ScriptResource to control when streaming starts, so the
"no more streaming" call will disappear -- however it is necessary to
maintain the current behaviour, and be able to control it with a
runtime flag.

Bug: chromium:865098
Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1181430
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599148}
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/7bd9163502462762e58d8010577dbf36aeef6c13/tools/metrics/histograms/enums.xml

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

commit b7590d68012b9cf52c14e3f44e019ea36ecc2d9e
Author: Florent Castelli <orphis@chromium.org>
Date: Fri Oct 12 12:16:18 2018

Revert "[blink] Control ScriptStreamer with ScriptResource"

This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.

Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
Bug:  894792 ,  894795 

Original change's description:
> [blink] Control ScriptStreamer with ScriptResource
> 
> Move the ScriptStreamer control logic from ClassicPendingScript to
> ScriptResource. In the future, this will allow us to start streaming
> a ScriptResource before the ClassicPendingScript is available, e.g on
> preload.
> 
> The ClassicPendingScript now only sends one "finished" callback, from
> ScriptResource. This callback is either when the streaming completes,
> or when there is no streaming and the ClassicPendingScript has told
> the ScriptResource that it doesn't intend to start streaming. In the
> long run, we want all scripts to go through the streaming interface,
> and we want ScriptResource to control when streaming starts, so the
> "no more streaming" call will disappear -- however it is necessary to
> maintain the current behaviour, and be able to control it with a
> runtime flag.
> 
> Bug: chromium:865098
> Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599148}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1278758
Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599180}
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/b7590d68012b9cf52c14e3f44e019ea36ecc2d9e/tools/metrics/histograms/enums.xml

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9df78ccc1e1ac79a5657966a264562c6d03fb7

commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Oct 19 14:40:33 2018

Reland "[blink] Control ScriptStreamer with ScriptResource"

This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13

No changes from the original, revert reason is fixed with
https://chromium-review.googlesource.com/c/1283037

Original change's description:
> [blink] Control ScriptStreamer with ScriptResource
>
> Move the ScriptStreamer control logic from ClassicPendingScript to
> ScriptResource. In the future, this will allow us to start streaming
> a ScriptResource before the ClassicPendingScript is available, e.g on
> preload.
>
> The ClassicPendingScript now only sends one "finished" callback, from
> ScriptResource. This callback is either when the streaming completes,
> or when there is no streaming and the ClassicPendingScript has told
> the ScriptResource that it doesn't intend to start streaming. In the
> long run, we want all scripts to go through the streaming interface,
> and we want ScriptResource to control when streaming starts, so the
> "no more streaming" call will disappear -- however it is necessary to
> maintain the current behaviour, and be able to control it with a
> runtime flag.
>
> Bug: chromium:865098
> Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599148}

TBR=kouhei@chromium.org,kinuko@chromium.org

Bug: chromium:865098
Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
Reviewed-on: https://chromium-review.googlesource.com/c/1286450
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601143}
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/dd9df78ccc1e1ac79a5657966a264562c6d03fb7/tools/metrics/histograms/enums.xml

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42aaff47209c95a505823b0834bdfe1d337ee1ff

commit 42aaff47209c95a505823b0834bdfe1d337ee1ff
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Oct 23 12:32:29 2018

[blink] Remove work stealing

Work stealing is deprecated by script streaming on the task scheduler,
and broken anyway by ScriptResource-controlled script streaming.

Bug: 557466
Bug: 761977
Bug: 865098
Bug: 866868
Change-Id: Ie01d239b052ad7499e9884687bf95376a5cf6f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1258168
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601921}
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/content/child/runtime_features.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/content/public/common/content_features.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/content/public/common/content_features.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/script_runner.h
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/core/script/script_runner_test.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/42aaff47209c95a505823b0834bdfe1d337ee1ff/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8

commit a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Oct 24 09:22:08 2018

Revert "[blink] Remove work stealing"

This reverts commit 42aaff47209c95a505823b0834bdfe1d337ee1ff.

Reason for revert: Blocking a revert for https://crbug.com/894796

Original change's description:
> [blink] Remove work stealing
> 
> Work stealing is deprecated by script streaming on the task scheduler,
> and broken anyway by ScriptResource-controlled script streaming.
> 
> Bug: 557466
> Bug: 761977
> Bug: 865098
> Bug: 866868
> Change-Id: Ie01d239b052ad7499e9884687bf95376a5cf6f9a
> Reviewed-on: https://chromium-review.googlesource.com/c/1258168
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601921}

TBR=hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org,jochen@chromium.org

Change-Id: I0017e6580c01f5da934a6a13af0b8b01641c0c39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 557466, 761977, 865098, 866868
Reviewed-on: https://chromium-review.googlesource.com/c/1297421
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602280}
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/content/child/runtime_features.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/content/public/common/content_features.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/content/public/common/content_features.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/script_runner.h
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/core/script/script_runner_test.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c564235ff692fe0b3d926152748feb7902e8a800

commit c564235ff692fe0b3d926152748feb7902e8a800
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Oct 24 12:38:25 2018

Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""

This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.

Reason for revert: Makes VR tests flaky (https://crbug.com/894796)

Original change's description:
> Reland "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> 
> No changes from the original, revert reason is fixed with
> https://chromium-review.googlesource.com/c/1283037
> 
> Original change's description:
> > [blink] Control ScriptStreamer with ScriptResource
> >
> > Move the ScriptStreamer control logic from ClassicPendingScript to
> > ScriptResource. In the future, this will allow us to start streaming
> > a ScriptResource before the ClassicPendingScript is available, e.g on
> > preload.
> >
> > The ClassicPendingScript now only sends one "finished" callback, from
> > ScriptResource. This callback is either when the streaming completes,
> > or when there is no streaming and the ClassicPendingScript has told
> > the ScriptResource that it doesn't intend to start streaming. In the
> > long run, we want all scripts to go through the streaming interface,
> > and we want ScriptResource to control when streaming starts, so the
> > "no more streaming" call will disappear -- however it is necessary to
> > maintain the current behaviour, and be able to control it with a
> > runtime flag.
> >
> > Bug: chromium:865098
> > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#599148}
> 
> TBR=kouhei@chromium.org,kinuko@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601143}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:865098
Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
Reviewed-on: https://chromium-review.googlesource.com/c/1297138
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602310}
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/c564235ff692fe0b3d926152748feb7902e8a800/tools/metrics/histograms/enums.xml

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5528336d71c1ec02d5b6e8f3224755a9cfb20de4

commit 5528336d71c1ec02d5b6e8f3224755a9cfb20de4
Author: Leszek Swirski <leszeks@chromium.org>
Date: Mon Nov 05 11:45:40 2018

Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""

This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.

No changes from the original, VR flakes are caused by issues with
loadUrl and have been deflaked (see 894796 for details)

Original change's description:
> Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> 
> This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> 
> Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> 
> Original change's description:
> > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > 
> > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > 
> > No changes from the original, revert reason is fixed with
> > https://chromium-review.googlesource.com/c/1283037
> > 
> > Original change's description:
> > > [blink] Control ScriptStreamer with ScriptResource
> > >
> > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > ScriptResource. In the future, this will allow us to start streaming
> > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > preload.
> > >
> > > The ClassicPendingScript now only sends one "finished" callback, from
> > > ScriptResource. This callback is either when the streaming completes,
> > > or when there is no streaming and the ClassicPendingScript has told
> > > the ScriptResource that it doesn't intend to start streaming. In the
> > > long run, we want all scripts to go through the streaming interface,
> > > and we want ScriptResource to control when streaming starts, so the
> > > "no more streaming" call will disappear -- however it is necessary to
> > > maintain the current behaviour, and be able to control it with a
> > > runtime flag.
> > >
> > > Bug: chromium:865098
> > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#599148}
> > 
> > TBR=kouhei@chromium.org,kinuko@chromium.org
> > 
> > Bug: chromium:865098
> > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#601143}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: chromium:865098
> Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602310}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:865098
Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
Reviewed-on: https://chromium-review.googlesource.com/c/1317566
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605295}
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/5528336d71c1ec02d5b6e8f3224755a9cfb20de4/tools/metrics/histograms/enums.xml

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781

commit d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781
Author: Dmitry Titov <dimich@chromium.org>
Date: Mon Nov 05 18:12:50 2018

Revert "Reland "Reland "[blink] Control ScriptStreamer with ScriptResource"""

This reverts commit 5528336d71c1ec02d5b6e8f3224755a9cfb20de4.

Reason for revert: Broke VR tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3533

Original change's description:
> Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> 
> This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
> 
> No changes from the original, VR flakes are caused by issues with
> loadUrl and have been deflaked (see 894796 for details)
> 
> Original change's description:
> > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > 
> > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> > 
> > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > 
> > Original change's description:
> > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > 
> > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > > 
> > > No changes from the original, revert reason is fixed with
> > > https://chromium-review.googlesource.com/c/1283037
> > > 
> > > Original change's description:
> > > > [blink] Control ScriptStreamer with ScriptResource
> > > >
> > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > ScriptResource. In the future, this will allow us to start streaming
> > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > preload.
> > > >
> > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > ScriptResource. This callback is either when the streaming completes,
> > > > or when there is no streaming and the ClassicPendingScript has told
> > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > long run, we want all scripts to go through the streaming interface,
> > > > and we want ScriptResource to control when streaming starts, so the
> > > > "no more streaming" call will disappear -- however it is necessary to
> > > > maintain the current behaviour, and be able to control it with a
> > > > runtime flag.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > 
> > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > 
> > > Bug: chromium:865098
> > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#601143}
> > 
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: chromium:865098
> > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602310}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: chromium:865098
> Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605295}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I0a42464953d0c3f07977b03e868a1fb252a2ab66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1318084
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605385}
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/d2ca6aa33d86bcfe7cb3a73d6a0744ef7e1ec781/tools/metrics/histograms/enums.xml

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11

commit 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Nov 06 20:53:36 2018

Reland^3 "[blink] Control ScriptStreamer with ScriptResource"

This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.

VR tests have been properly deflaked in https://crrev.com/c/1319715, this
is otherwise unchanged.

Original change's description:
> Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
>
> This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
>
> No changes from the original, VR flakes are caused by issues with
> loadUrl and have been deflaked (see 894796 for details)
>
> Original change's description:
> > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> >
> > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> >
> > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> >
> > Original change's description:
> > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > >
> > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > >
> > > No changes from the original, revert reason is fixed with
> > > https://chromium-review.googlesource.com/c/1283037
> > >
> > > Original change's description:
> > > > [blink] Control ScriptStreamer with ScriptResource
> > > >
> > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > ScriptResource. In the future, this will allow us to start streaming
> > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > preload.
> > > >
> > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > ScriptResource. This callback is either when the streaming completes,
> > > > or when there is no streaming and the ClassicPendingScript has told
> > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > long run, we want all scripts to go through the streaming interface,
> > > > and we want ScriptResource to control when streaming starts, so the
> > > > "no more streaming" call will disappear -- however it is necessary to
> > > > maintain the current behaviour, and be able to control it with a
> > > > runtime flag.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > >
> > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > >
> > > Bug: chromium:865098
> > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#601143}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:865098
> > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602310}
>
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:865098
> Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605295}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org

Bug: chromium:865098
Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1318923
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605815}
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11/tools/metrics/histograms/enums.xml

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf

commit a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Nov 07 19:06:47 2018

Revert "Reland^3 "[blink] Control ScriptStreamer with ScriptResource""

This reverts commit 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11.

Reason for revert: Canary crasher, Bug:902832

Original change's description:
> Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
> was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
> a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
> 
> VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> is otherwise unchanged.
> 
> Original change's description:
> > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> >
> > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
> >
> > No changes from the original, VR flakes are caused by issues with
> > loadUrl and have been deflaked (see 894796 for details)
> >
> > Original change's description:
> > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> > >
> > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > >
> > > Original change's description:
> > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > >
> > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > > >
> > > > No changes from the original, revert reason is fixed with
> > > > https://chromium-review.googlesource.com/c/1283037
> > > >
> > > > Original change's description:
> > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > >
> > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > preload.
> > > > >
> > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > long run, we want all scripts to go through the streaming interface,
> > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > maintain the current behaviour, and be able to control it with a
> > > > > runtime flag.
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > >
> > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#602310}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:865098
> > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605295}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605815}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I9a9337344d5a11fcc6b16aab1d8ad600ffef4e10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1323655
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606095}
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/a16ca17f52e8b45426d0b9b11bda9c4f70a22ebf/tools/metrics/histograms/enums.xml

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaeff5e6358a4b69fe1c92d30ffa04a703690879

commit aaeff5e6358a4b69fe1c92d30ffa04a703690879
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Nov 08 13:46:19 2018

Reland^4 "[blink] Control ScriptStreamer with ScriptResource"

This is a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.

Relanding with no changes, seems that this wasn't the cause of
https://crbug.com/902832 after all.

Original change's description:
> Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
>
> This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
> was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
> a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
>
> VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> is otherwise unchanged.
>
> Original change's description:
> > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> >
> > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
> >
> > No changes from the original, VR flakes are caused by issues with
> > loadUrl and have been deflaked (see 894796 for details)
> >
> > Original change's description:
> > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> > >
> > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > >
> > > Original change's description:
> > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > >
> > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > > >
> > > > No changes from the original, revert reason is fixed with
> > > > https://chromium-review.googlesource.com/c/1283037
> > > >
> > > > Original change's description:
> > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > >
> > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > preload.
> > > > >
> > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > long run, we want all scripts to go through the streaming interface,
> > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > maintain the current behaviour, and be able to control it with a
> > > > > runtime flag.
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > >
> > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#602310}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:865098
> > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605295}
>
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
>
> Bug: chromium:865098
> Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605815}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org

Bug: chromium:865098
Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
Reviewed-on: https://chromium-review.googlesource.com/c/1325921
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606448}
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/aaeff5e6358a4b69fe1c92d30ffa04a703690879/tools/metrics/histograms/enums.xml

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43673375d85dfc8257c262cab39b6d62d7a81cfe

commit 43673375d85dfc8257c262cab39b6d62d7a81cfe
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 09 12:20:57 2018

Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""

This reverts commit aaeff5e6358a4b69fe1c92d30ffa04a703690879.

Reason for revert: Findit thinks this CL makes delaying_onload_link_preload_after_discovery.html flaky with 70% confidence. Let's give it a shot and see if this fixes the flaking. Sorry, and let's hope the 5th reland goes better!

Original change's description:
> Reland^4 "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
> which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
> which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
> which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
> 
> Relanding with no changes, seems that this wasn't the cause of
> https://crbug.com/902832 after all.
> 
> Original change's description:
> > Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
> >
> > This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
> > was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
> > a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
> >
> > VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> > is otherwise unchanged.
> >
> > Original change's description:
> > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
> > >
> > > No changes from the original, VR flakes are caused by issues with
> > > loadUrl and have been deflaked (see 894796 for details)
> > >
> > > Original change's description:
> > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > > >
> > > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> > > >
> > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > > >
> > > > Original change's description:
> > > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > > >
> > > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > > > >
> > > > > No changes from the original, revert reason is fixed with
> > > > > https://chromium-review.googlesource.com/c/1283037
> > > > >
> > > > > Original change's description:
> > > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > > >
> > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > > preload.
> > > > > >
> > > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > > long run, we want all scripts to go through the streaming interface,
> > > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > > maintain the current behaviour, and be able to control it with a
> > > > > > runtime flag.
> > > > > >
> > > > > > Bug: chromium:865098
> > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > > >
> > > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > > >
> > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#602310}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#605295}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> >
> > Bug: chromium:865098
> > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605815}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
> Reviewed-on: https://chromium-review.googlesource.com/c/1325921
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606448}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I6d2bbe9085376921d819c015bf37832efe8d2d11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098,  chromium:903732 
Reviewed-on: https://chromium-review.googlesource.com/c/1328966
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606804}
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/tools/metrics/histograms/enums.xml

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb

commit e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb
Author: Leszek Swirski <leszeks@chromium.org>
Date: Mon Nov 12 16:57:19 2018

Reland^5 "[blink] Control ScriptStreamer with ScriptResource"

This is a reland of aaeff5e6358a4b69fe1c92d30ffa04a703690879
which was a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.

Relanding with no changes, after disabling the flaky test in
https://crbug.com/904389

Original change's description:
> [blink] Control ScriptStreamer with ScriptResource
>
> Move the ScriptStreamer control logic from ClassicPendingScript to
> ScriptResource. In the future, this will allow us to start streaming
> a ScriptResource before the ClassicPendingScript is available, e.g on
> preload.
>
> The ClassicPendingScript now only sends one "finished" callback, from
> ScriptResource. This callback is either when the streaming completes,
> or when there is no streaming and the ClassicPendingScript has told
> the ScriptResource that it doesn't intend to start streaming. In the
> long run, we want all scripts to go through the streaming interface,
> and we want ScriptResource to control when streaming starts, so the
> "no more streaming" call will disappear -- however it is necessary to
> maintain the current behaviour, and be able to control it with a
> runtime flag.
>
> Bug: chromium:865098
> Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599148}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org

Bug: chromium:865098
Change-Id: Ifa87904db32666517bfe1174fca51b7e552679b2
Reviewed-on: https://chromium-review.googlesource.com/c/1329800
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607268}
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/e734f1f90c59a72f2a7c761ca3d06a9d61d6f0cb/tools/metrics/histograms/enums.xml

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa

commit 7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Nov 22 10:52:23 2018

[blink] Stream scripts on preload

Start streaming ScriptResources when they are fetched, so that they
can start streaming during preload, before the script tag is seen.
This is enabled with a new ScriptStreamingOnPreload flag.

Bug: chromium:865098
Change-Id: I4a2874bce857a538f4bd35a818254ca9617f1a72
Reviewed-on: https://chromium-review.googlesource.com/c/1185185
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610370}
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/content/child/runtime_features.cc
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/content/public/common/content_features.cc
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/content/public/common/content_features.h
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/WebKit/LayoutTests/virtual/streaming-preload/external/wpt/html/semantics/scripting-1/README.txt
[add] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/WebKit/LayoutTests/virtual/streaming-preload/http/tests/fetch/README.txt
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc82d4b6b3aa11e45c2422eafa3a45f2d5f75a1

commit 2cc82d4b6b3aa11e45c2422eafa3a45f2d5f75a1
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Nov 27 19:40:50 2018

[blink] Harden inspector ScriptResource content access

Check for an edge case where a ScriptResource may have a null resource
buffer without having been loaded. As part of this, extract the
inspector's logic for accessing a ScriptResource's text into the
ScriptResource, as it relies on ScriptResource internal state.

Bug: 865098
Bug: 899217
Change-Id: I5ceb6f105e21e4eeb7ce5f9bc82c7d7c7f7f6aad
Reviewed-on: https://chromium-review.googlesource.com/c/1352183
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611255}
[modify] https://crrev.com/2cc82d4b6b3aa11e45c2422eafa3a45f2d5f75a1/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/2cc82d4b6b3aa11e45c2422eafa3a45f2d5f75a1/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/2cc82d4b6b3aa11e45c2422eafa3a45f2d5f75a1/third_party/blink/renderer/core/loader/resource/script_resource.h

QUERY I'm using for checking crashes:
REGEXP_CONTAINS(expanded_custom_data.ChromeCrashProto.magic_signature_1.name,'blink::ScriptResource') AND REGEXP_CONTAINS(product.Version,'^72\\.0')

So far none except for Issue 899217/Issue 909858 and one due to unknown cause.
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76cc229bc7fbec74b3b6854360908f6561d1556f

commit 76cc229bc7fbec74b3b6854360908f6561d1556f
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Nov 29 00:55:54 2018

[blink] Make TextForInspector check a DCHECK

This CHECK is currently occasionally failing in the wild, but the failure
of the CHECK doesn't mean any serious correctness issues. Make it a
DCHECK for now to prevent crashes, and investigate separately.

Bug: 865098
Bug: 899217
Bug: 909858
Change-Id: Ie99a1e79bd239ac01021e1d942724cf3bdfdd510
Reviewed-on: https://chromium-review.googlesource.com/c/1353955
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611972}
[modify] https://crrev.com/76cc229bc7fbec74b3b6854360908f6561d1556f/third_party/blink/renderer/core/loader/resource/script_resource.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82bf836801aed3e75c3984124ca2b0455ec57b3f

commit 82bf836801aed3e75c3984124ca2b0455ec57b3f
Author: Camillo Bruni <cbruni@chromium.org>
Date: Mon Dec 03 11:29:44 2018

[blink/script] Add trace events for PendingScripts

This CL adds the following trace events in the blink category:
- PendingScript::ExecuteScriptBlock
- ScriptRunner::ExecuteInOrderTask
- ScriptRunner::ExecuteAsyncTask
- ClassicPendingScript::GetSource

Bug: 865098
Change-Id: I4b8af61283bd97b0ab1d9e0b74fc0f08ce7a2293
Reviewed-on: https://chromium-review.googlesource.com/c/1356545
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613047}
[modify] https://crrev.com/82bf836801aed3e75c3984124ca2b0455ec57b3f/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/82bf836801aed3e75c3984124ca2b0455ec57b3f/third_party/blink/renderer/core/script/pending_script.cc
[modify] https://crrev.com/82bf836801aed3e75c3984124ca2b0455ec57b3f/third_party/blink/renderer/core/script/script_runner.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e255aed3c9924035b27ed04226f1dbd22d6884e

commit 3e255aed3c9924035b27ed04226f1dbd22d6884e
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Dec 11 09:08:56 2018

[blink] Remove IsFinished check for TextForInspector

There are some edge cases where IsLoaded is true but IsFinishedInternal
is not (yet) true, so remove that check and expand the comment.

Bug: 865098
Bug: 899217
Bug: 909858
Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc
Reviewed-on: https://chromium-review.googlesource.com/c/1369789
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615468}
[modify] https://crrev.com/3e255aed3c9924035b27ed04226f1dbd22d6884e/third_party/blink/renderer/core/loader/resource/script_resource.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Dec 21

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9cce0a02ab297fbe2c892274e7c2fdaac4289ed

commit c9cce0a02ab297fbe2c892274e7c2fdaac4289ed
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Dec 21 20:22:08 2018

[blink] Remove IsFinished check for TextForInspector

There are some edge cases where IsLoaded is true but IsFinishedInternal
is not (yet) true, so remove that check and expand the comment.

Bug: 865098
Bug: 899217
Bug: 909858
Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc
Reviewed-on: https://chromium-review.googlesource.com/c/1369789
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615468}(cherry picked from commit 3e255aed3c9924035b27ed04226f1dbd22d6884e)
Reviewed-on: https://chromium-review.googlesource.com/c/1388819
Cr-Commit-Position: refs/branch-heads/3626@{#502}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c9cce0a02ab297fbe2c892274e7c2fdaac4289ed/third_party/blink/renderer/core/loader/resource/script_resource.cc

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c9cce0a02ab297fbe2c892274e7c2fdaac4289ed

Commit: c9cce0a02ab297fbe2c892274e7c2fdaac4289ed
Author: leszeks@chromium.org
Commiter: hiroshige@chromium.org
Date: 2018-12-21 20:22:08 +0000 UTC

[blink] Remove IsFinished check for TextForInspector

There are some edge cases where IsLoaded is true but IsFinishedInternal
is not (yet) true, so remove that check and expand the comment.

Bug: 865098
Bug: 899217
Bug: 909858
Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc
Reviewed-on: https://chromium-review.googlesource.com/c/1369789
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615468}(cherry picked from commit 3e255aed3c9924035b27ed04226f1dbd22d6884e)
Reviewed-on: https://chromium-review.googlesource.com/c/1388819
Cr-Commit-Position: refs/branch-heads/3626@{#502}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Labels: CommitLog-Audit-Violation Merge-Without-Approval M-72
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision c9cce0a02ab297fbe2c892274e7c2fdaac4289ed was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: -CommitLog-Audit-Violation -Merge-Without-Approval
Owner: leszeks@chromium.org
Reassigning to Leszek who has been doing the work.
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 16 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea23db3659d3adab3a096c404e3193c841040079

commit ea23db3659d3adab3a096c404e3193c841040079
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Jan 16 00:07:08 2019

Reland "[blink] Remove work stealing"

This is a reland of 42aaff47209c95a505823b0834bdfe1d337ee1ff.

This was reverted because it was blocking another revert. That revert
relanded and has stuck, so this can reland now too.

Original change's description:
> [blink] Remove work stealing
>
> Work stealing is deprecated by script streaming on the task scheduler,
> and broken anyway by ScriptResource-controlled script streaming.
>
> Bug: 557466
> Bug: 761977
> Bug: 865098
> Bug: 866868
> Change-Id: Ie01d239b052ad7499e9884687bf95376a5cf6f9a
> Reviewed-on: https://chromium-review.googlesource.com/c/1258168
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601921}

TBR=hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org,jochen@chromium.org

Bug: 557466, 761977, 865098, 866868
Change-Id: Ibf7ac460f97bf7ab3699371c70076cb1e1d41d65
Reviewed-on: https://chromium-review.googlesource.com/c/1411601
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622896}
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/content/child/runtime_features.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/content/public/common/content_features.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/content/public/common/content_features.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/script_runner.h
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/core/script/script_runner_test.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/ea23db3659d3adab3a096c404e3193c841040079/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment