New issue
Advanced search Search tips

Issue 865097 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Jul 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Erroneous VR binary size regression

Project Member Reported by mthiesse@chromium.org, Jul 18 
Momentary panic ensued after seeing a ~500kB regression on https://chromeperf.appspot.com/report?sid=84618bc636cbabd1b7fea5774cc927e50d5929c8bb0716f3775caea360f0a998

The cause is:
https://chromium.googlesource.com/chromium/src/+/15787aa257b549bc23267dd353654cddcc5e2c3f

However, this isn't actually a binary size increase - just a change in accounting. AR used to be on regardless of whether or not VR was on, but now it's tied to the VR flag as well, making it look like a regression for the VR flag.

We should just disable AR for our VR binary size bots.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/76d3210078900071be35b08921aad0b9403205f6

commit 76d3210078900071be35b08921aad0b9403205f6
Author: bsheedy <bsheedy@google.com>
Date: Wed Jul 18 22:15:43 2018

Comment 2 by bsheedy@chromium.org, Jul 18

Status: Fixed (was: Started)
►

Sign in to add a comment