New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865091 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Local storage, session storage, preview pane completely obscures the table

Reported by regis.ca...@gmail.com, Jul 18

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3493.3 Safari/537.36

Steps to reproduce the problem:
1. Fire up the dev tools on this page 
2. Click on the console tab
3. Enter `localStorage.setItem('foo', 'bar')` (no back ticks) and press enter
4. Enter `localStorage.setItem('bar', 'com')` (no back ticks) and press enter
5. Click on the Application tab, choose local storage then click on the "https://chromiumbugs.appspot.com" node

What is the expected behavior?
a consistent view (key: foo, value: bar, key = bar, value = com)

What went wrong?
see screenshot, I get some strange UI showing "key: 1 | bar"

Did this work before? Yes not sure, sorry

Chrome version: 69.0.3493.3  Channel: dev
OS Version: 18.04 (up to date)
Flash Version: 

NB: `localStorage.length` gives 2 so it's only an UI issue.
 
Capture d’écran de 2018-07-18 19-30-56.png
6.2 KB View Download
Labels: Needs-Triage-M69 Needs-Bisect
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on reported chrome version 69.0.3493.3 using Ubuntu 17.10. Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chrome 
2. Opened Dev_Tools >> Console 
3. Entered " localStorage.setItem('foo', 'bar') " and clicked on enter
4. Entered " localStorage.setItem('bar', 'com') " and clicked on enter
5. Navigated to Application tab >> Clicked on local storage then clicked on the " https://chromiumbugs.appspot.com "
As we are able to see the consistent view (key: foo, value: bar, key = bar, value = com)

@Reporter: Could you please review the attached screen-cast and confirm if anything being missed here. 

Thanks..!
865091.webm
9.8 MB View Download
Hello Phanindra,

Here's a screencast. I think I found out why you don't reproduce, if I use the lateral inspector, it's working as expected here too (see screenshot). 
Regards,
Capture d’écran de 2018-07-19 09-06-20.png
36.2 KB View Download
demo.mp4
889 KB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 19

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable RegressedIn-64 FoundIn-67 Target-67 Target-69 M-68 Target-68 FoundIn-68 FoundIn-69 OS-Mac OS-Windows Pri-1
Owner: eostroukhov@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on the reported chrome 69.0.3493.3,latest stable 67.0.3396.99 and canary 69.0.3496.0 using Windows10, Mac OS10.13.5, Ubuntu17.10.        Below is the bisect information for same.

Bisect Info:
================
Good build: 64.0.3255.0
Bad build:  64.0.3256.0

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/9618fdc418cd5576e0c04e121bd19a84459c1642..62f757cf193455349ddf045bfc15e2e48b649ae6

Suspect: https://chromium.googlesource.com/chromium/src/+/62f757cf193455349ddf045bfc15e2e48b649ae6

Reviewed-on: https://chromium-review.googlesource.com/731405

eostroukhov: Please confirm the issue and help in re-assigning if it is not related to your change.Adding RBS label for M-68 feel free to change it if not required.

Thanks!
Labels: -Target-67
We're not planning any further M67 releases, so removing "Target-67" label.
Labels: M-69
Cc: manoranj...@chromium.org
Could some one from devtools team, please take a look into it & confirm it is really blocking M68 stable release as we are planning M68 release soon tentatively.

Thanks..!
Labels: -M-68 -Target-68
This issue existing from M64, so punting this for M69.
Labels: -M-69 -Target-69 Target-70 M-70
Not a blocker for M69 as well as this is regressed since M64.
Friendly ping to get an update as it is marked as RBS.
Thanks..!
Gentle ping to get an update as it is marked as RBS. Could some one from devtools team please take a look and update the thread.

Thanks..!
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: l...@chromium.org
Sorry for the delay.  This is not RBS.  I think an appropriate fix is to just ensure minimum-height on the data table, to prevent the preview pane from completely obscuring it.
Summary: Local storage, session storage, preview pane completely obscures the table (was: Local storage and session storage view is broken)
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f1ed2c0e0dd71456fa9d7a096318e84639f8597

commit 4f1ed2c0e0dd71456fa9d7a096318e84639f8597
Author: Harley Li <hhli@chromium.org>
Date: Tue Sep 11 20:45:16 2018

[DevTools] Set minimum height of storage's key-value table

Set the minimum height of storage panel's key-value table so that the
preview panel down below won't obscure it when dragged upward, confusing
the users.
Screenshot: https://imgur.com/a/VhC4X7x

Bug:  865091 
Change-Id: I152f9082f6dd1646a1e8eaeb4d9111b181546553
Reviewed-on: https://chromium-review.googlesource.com/1220477
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590453}
[modify] https://crrev.com/4f1ed2c0e0dd71456fa9d7a096318e84639f8597/third_party/blink/renderer/devtools/front_end/resources/DOMStorageItemsView.js

Owner: hhli@chromium.org
Status: Fixed (was: Assigned)
Labels: TE-Verified-M71 TE-Verified-71.0.3550.0
Able to reproduce the issue on chrome version 69.0.3493.3 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.5  using Chrome version # 71.0.3550.0.
Attaching screen-cast for reference.
Observed that  " a consistent view (key: foo, value: bar, key = bar, value = com) " 
The fix is working as expected, adding Verified labels

Thanks...!
865091.mp4
1015 KB View Download
Updating the above comment #18, Verified the fix on Mac 10.13.6, Windows 10 and Ubuntu 14.40 using Chrome version # 71.0.3550.0.

Sign in to add a comment