edchin@ PTAL

There's actually a related problem here: if you open an NTP, navigate to a page, then navigate back to the NTP and enter the tab grid, then the NTP's title in the tab grid is whatever that page's title is.

I think what we actually want is to never show a title in the grid for chrome://newtab WebStates. 

Pete/Martijn, can you confirm?

Agreed, let's not show a title for chrome://newtab.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909c936ad25fb979e16e13d71e2b3801812d8b25

commit 909c936ad25fb979e16e13d71e2b3801812d8b25
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 19 12:51:43 2018

[iOS] Remove favicon and title for NTP tabs in the tab grid.

This CL special-cases NTP URLs (chrome://newtab) in the tab grid
mediator to set no title or favicon in the grid items sent to the
consumer; this means that the corresponding cells in the tab grid will
have no titles or favicons.

In order to cleanly support cells having no icons, the icon image view
background is set to be clear when there is no image.

Bug:  865074 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I13eeeb3c494f7c5f300f2b179da4887dfeb9cdca
Reviewed-on: https://chromium-review.googlesource.com/1143262
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576458}
[modify] https://crrev.com/909c936ad25fb979e16e13d71e2b3801812d8b25/ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
[modify] https://crrev.com/909c936ad25fb979e16e13d71e2b3801812d8b25/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm

[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.

This bug requires manual review: We don't branch M69 until 2018-07-19.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Canary verification please.

Tested in 70.0.3500.0 Canary, iPhone X  iOS 11.4, Issue is still shown,

https://drive.google.com/file/d/1wobgvG1gCg8I0PWytnO-NsontdG8SmrK/view

I guess the history on this bug makes things a bit unclear. The bug report is that NTP tabs in the grid sometimes don't show a title. But the UX decision (comment #4) was that NTP tiles should *never* show a title or a favicon. The bug summary was updated to reflect this.

So if NTP tiles aren't showing favicons and titles in Canary, then this issue is fixed. 

shbarezer@ can you please re-verify and update this bug accordingly? 

Sorry, for my misunderstanding, in that case the bug is fixed.

Verified in 70.0.3500.0 Canary, iPhone X  iOS 11.4.

Looks good.

Approved.

Oops, my mistake; looks like this made it into the branch.