Old Sign in promo in Settings screen |
|||||||||||||
Issue descriptionApp Version: 69.0.3495.0 canary iOS Version: 11.4.1, 12.0 beta#4, 10.3.3 Device: iPhone6s, iPhoneX, iPad URL: UI >Settings Steps to reproduce: 1. Launch Google Chrome 2. Tap Menu > Settings Observed results: Observe that Sign in promo is still in Old UI style Expected results: New Sign in promo similar to what seen in Recent Tabs should be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Link to video/image: https://docs.google.com/drawings/d/1d-pIochZbM9RPodhelzpJ3vUzstpbv8ft7NqnICZbcc/preview
,
Jul 18
,
Jul 19
,
Jul 19
,
Jul 19
Fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1142267
,
Jul 19
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 19
,
Jul 19
This bug requires manual review: We don't branch M69 until 2018-07-19. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20
,
Jul 23
Canary verification please.
,
Jul 23
Fix looks good on M70.0.3500.0 canary iOS11.4.1, iPad Pro.
,
Jul 24
Approved.
,
Jul 25
This was merged to M-69 before branching (just confirmed) so there's no cherrypicking needed.
,
Jul 26
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by sczs@chromium.org
, Jul 18Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)