New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 865167



Sign in to add a comment

"LocalNTPMDTest.LoadsMDIframe" browser test fails on Win,Win64 and Linux64 official.desktop.continuous builder.

Project Member Reported by pbomm...@chromium.org, Jul 18

Issue description

Link to builder :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/88685
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/37093
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/11180


Link to Error log :
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_trunk%2F37093%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FLocalNTPMDTest.LoadsMDIframe%2F0


Error :
LocalNTPMDTest.LoadsMDIframe (run #1):
[ RUN      ] LocalNTPMDTest.LoadsMDIframe
[11908:16336:0718/081745.413:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=LocalNTPMDTest.LoadsMDIframe --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir35264_22564\results35264_21772\test_results.xml" --test-launcher-summary-output="c:\users\chrome~1\appdata\local\temp\tmpyzgowm.json" --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir35264_22564\d35264_22778" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=NewTabPageUIMd,TestFeatureForBrowserTest1,UseGoogleLocalNtp --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/search/local_ntp_browsertest.cc(588): error: Expected equality of these values:
  total_thumbs
    Which is: 1
  0
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0000000140CB07C7+87] (C:\b\c\b\win64_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:810)
	testing::internal::AssertHelper::operator= [0x0000000140CB034E+78] (C:\b\c\b\win64_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:382)
	`anonymous namespace'::LocalNTPMDTest_LoadsMDIframe_Test::RunTestOnMainThread [0x000000014042A6CF+1583] (C:\b\c\b\win64_trunk\src\chrome\browser\ui\search\local_ntp_browsertest.cc:588)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x000000014283522F+447] (C:\b\c\b\win64_trunk\src\content\public\test\browser_test_base.cc:409)
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00000001438BFA30+4784] (C:\b\c\b\win64_trunk\src\chrome\browser\chrome_browser_main.cc:2028)
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00000001438BE66E+174] (C:\b\c\b\win64_trunk\src\chrome\browser\chrome_browser_main.cc:1411)
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000141605E15+85] (C:\b\c\b\win64_trunk\src\content\browser\browser_main_loop.cc:1006)
	content::StartupTaskRunner::RunAllTasksNow [0x000000014192511B+43] (C:\b\c\b\win64_trunk\src\content\browser\startup_task_runner.cc:43)
	content::BrowserMainLoop::CreateStartupTasks [0x00000001416048C8+616] (C:\b\c\b\win64_trunk\src\content\browser\browser_main_loop.cc:919)
	content::BrowserMainRunnerImpl::Initialize [0x000000014160822E+126] (C:\b\c\b\win64_trunk\src\content\browser\browser_main_runner_impl.cc:142)
	content::BrowserMain [0x0000000141602820+176] (C:\b\c\b\win64_trunk\src\content\browser\browser_main.cc:44)
	content::RunBrowserProcessMain [0x00000001426FCCBF+111] (C:\b\c\b\win64_trunk\src\content\app\content_main_runner_impl.cc:596)
	content::ContentMainRunnerImpl::Run [0x00000001426FD5D5+613] (C:\b\c\b\win64_trunk\src\content\app\content_main_runner_impl.cc:952)
	service_manager::Main [0x0000000142D92646+822] (C:\b\c\b\win64_trunk\src\services\service_manager\embedder\main.cc:472)
	content::ContentMain [0x00000001426FCBF1+65] (C:\b\c\b\win64_trunk\src\content\app\content_main.cc:19)
	content::BrowserTestBase::SetUp [0x0000000142834F59+1785] (C:\b\c\b\win64_trunk\src\content\public\test\browser_test_base.cc:322)
	InProcessBrowserTest::SetUp [0x00000001427F9296+502] (C:\b\c\b\win64_trunk\src\chrome\test\base\in_process_browser_test.cc:251)
[11908:16336:0718/081752.018:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[11908:16336:0718/081752.018:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[11908:16336:0718/081752.018:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] LocalNTPMDTest.LoadsMDIframe, where TypeParam =  and GetParam() =  (6743 ms)
 
Cc: ramyan@chromium.org
Owner: kristip...@chromium.org
Status: Started (was: Untriaged)
This should be fixed once https://chromium-review.googlesource.com/c/chromium/src/+/1139108 lands. Test is failing due to change introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1137258.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d3d90d3b6b460678571defa7e30902bcb2e63ea

commit 6d3d90d3b6b460678571defa7e30902bcb2e63ea
Author: kristipark <kristipark@chromium.org>
Date: Thu Jul 19 03:28:01 2018

[NTP] Add iframe for the edit custom link dialog

In order to prevent private information from being leaked to third-
party NTPs, information related to editing/adding links will be
contained in an iframe. Once the user finishes editing, the information
will be sent to the EmbeddedSearchAPI and ultimately be received by the
Most Visited iframe by querying EmbeddedSearchAPI with the specified
rid.

Screenshot: https://screenshot.googleplex.com/FcYM4VCiu3c.png

Design Doc: go/chrome-ntp-custom-links

Bug: 851293,  865071 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I06f4449f9c3764c5d797b83acbc7c97e6903b787
Reviewed-on: https://chromium-review.googlesource.com/1139108
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576348}
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/browser_resources.grd
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/ntp_tiles/chrome_custom_links_manager_factory.cc
[add] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/custom_links_edit.css
[add] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/custom_links_edit.html
[add] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/custom_links_edit.js
[add] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/icons/add_link.svg
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/local_ntp.html
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/most_visited_single.css
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/resources/local_ntp/most_visited_single.js
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/search/iframe_source.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/search/most_visited_iframe_source.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/search/ntp_features.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/search/ntp_features.h
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/chrome/test/data/local_ntp/local_ntp_browsertest.html
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/components/ntp_tiles/constants.cc
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/components/ntp_tiles/constants.h
[modify] https://crrev.com/6d3d90d3b6b460678571defa7e30902bcb2e63ea/components/ntp_tiles/most_visited_sites.cc

Blocking: 865167
Status: Fixed (was: Started)

Sign in to add a comment