Some of the strings in Settings are still using Roboto fonts. |
|||||||
Issue descriptionApp Version: 69.0.3495.0 canary iOS Version: 11.4.1, 12.0 beta#4 Device: iPhone6s, iPad Pro URL: Settings Steps to reproduce: 1. Launch Google Chrome 2. Open Settings Below are the some of the screens that are still using Roboto font. Link to video/image: https://drive.google.com/file/d/1s5yKSAnKd5dcJE5dAfMzIeyhxZ74Zlox/view I will keep adding the screenshots in this bug if I came across more.
,
Jul 19
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7743e4779de210edef5519273dcca2667c61380 commit c7743e4779de210edef5519273dcca2667c61380 Author: Rohit Rao <rohitrao@chromium.org> Date: Thu Jul 19 17:22:37 2018 [ios] Updates more Settings cells to use UIKit styling. BUG= 865067 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If3364c7847fb34483c9048248a52bdde6f4d83e3 Reviewed-on: https://chromium-review.googlesource.com/1142024 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576537} [modify] https://crrev.com/c7743e4779de210edef5519273dcca2667c61380/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/c7743e4779de210edef5519273dcca2667c61380/ios/chrome/browser/ui/authentication/account_control_item.h [modify] https://crrev.com/c7743e4779de210edef5519273dcca2667c61380/ios/chrome/browser/ui/authentication/account_control_item.mm [modify] https://crrev.com/c7743e4779de210edef5519273dcca2667c61380/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm [modify] https://crrev.com/c7743e4779de210edef5519273dcca2667c61380/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
,
Jul 25
The title in the navigation bar will remain Roboto. The two cells in the middle of the page have been fixed. Please reopen or file a new bug if you see any more cells that use Roboto. No merge needed for M69.
,
Jul 25
,
Aug 1
Confirming this also does not need to be merged?
,
Aug 16
Removing Merge-TBD label since UIRefresh-NoMerge label.
,
Aug 23
Verified in 69.0.3497.58 Beta in iPhone 8plus(iOS 12 beta9), iPad Air(iOS 12 beta9), iPhone 7(iOS 11.4.1), iPhone 7plus(iOS 10.3.3) Strings fonts are fixed as per the comment#4, looks good Link to screenshot: https://drive.google.com/file/d/185XZrT4HKZ9qHH4XiixwU0i1PW_CGqhG/view?usp=sharing |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sczs@chromium.org
, Jul 18Labels: -Pri-2 Pri-1
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)