New issue
Advanced search Search tips

Issue 865063 link

Starred by 1 user
Status: Fixed
Owner:
rayankans@chromium.org
Closed: Aug 7
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

BGF update event should be able to update the icon

Project Member Reported by rayankans@chromium.org, Jul 18 
Basically, BackgroundFetchUpdateEvent::updateUI should accept a dictionary (title + icons).

Spec changes still in progress.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3981964f2499033059aae600732d656370e0ddf

commit d3981964f2499033059aae600732d656370e0ddf
Author: Rayan Kanso <rayankans@chromium.org>
Date: Mon Jul 23 21:34:05 2018

[Background Fetch] Move all updatable UI options to their own proto.

Bundle up the icon and the title since they will be accessed/modified
together in the updateUI call.

It also makes sense to move the icon from the metadata proto since that
will speed up getting the registration info.

TBR=avi@chromium.org

Bug:  865063 
Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
Reviewed-on: https://chromium-review.googlesource.com/1146650
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577272}
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/BUILD.gn
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/README.md
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/get_initialization_data_task.cc
[add] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/image_helpers.cc
[add] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/image_helpers.h
[add] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/image_helpers_unittest.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/d3981964f2499033059aae600732d656370e0ddf/content/test/BUILD.gn
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5

commit 7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Jul 23 23:44:36 2018

Revert "[Background Fetch] Move all updatable UI options to their own proto."

This reverts commit d3981964f2499033059aae600732d656370e0ddf.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 577272 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QzOTgxOTY0ZjI0OTkwMzMwNTlhYWU2MDA3MzJkNjU2MzcwZTBkZGYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/71239

Sample Failed Step: site_per_process_content_unittests

Original change's description:
> [Background Fetch] Move all updatable UI options to their own proto.
> 
> Bundle up the icon and the title since they will be accessed/modified
> together in the updateUI call.
> 
> It also makes sense to move the icon from the metadata proto since that
> will speed up getting the registration info.
> 
> TBR=avi@chromium.org
> 
> Bug:  865063 
> Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
> Reviewed-on: https://chromium-review.googlesource.com/1146650
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577272}

Change-Id: I3a2cf95f1f058c5c026c68c4ca76998f8ccf52e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  865063 
Reviewed-on: https://chromium-review.googlesource.com/1147641
Cr-Commit-Position: refs/heads/master@{#577336}
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/BUILD.gn
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/README.md
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/get_initialization_data_task.cc
[delete] https://crrev.com/cf2d5c1f1587d0cdd040cfb95f56555141ff53f9/content/browser/background_fetch/storage/image_helpers.cc
[delete] https://crrev.com/cf2d5c1f1587d0cdd040cfb95f56555141ff53f9/content/browser/background_fetch/storage/image_helpers.h
[delete] https://crrev.com/cf2d5c1f1587d0cdd040cfb95f56555141ff53f9/content/browser/background_fetch/storage/image_helpers_unittest.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5/content/test/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9311d41253fc74d49527fb2ee69e0363334b969d

commit 9311d41253fc74d49527fb2ee69e0363334b969d
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Jul 24 12:58:30 2018

Reland "[Background Fetch] Move all updatable UI options to their own proto."

This is a reland of d3981964f2499033059aae600732d656370e0ddf

TBR=avi@chromium.org

Original change's description:
> [Background Fetch] Move all updatable UI options to their own proto.
>
> Bundle up the icon and the title since they will be accessed/modified
> together in the updateUI call.
>
> It also makes sense to move the icon from the metadata proto since that
> will speed up getting the registration info.
>
> TBR=avi@chromium.org
>
> Bug:  865063 
> Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
> Reviewed-on: https://chromium-review.googlesource.com/1146650
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577272}

Bug:  865063 
Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25
Reviewed-on: https://chromium-review.googlesource.com/1148261
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577500}
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/BUILD.gn
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/README.md
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/get_initialization_data_task.cc
[add] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/image_helpers.cc
[add] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/image_helpers.h
[add] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/image_helpers_unittest.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/9311d41253fc74d49527fb2ee69e0363334b969d/content/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4a2efba220348bdfa4b0fe78be630b15914ef1b

commit f4a2efba220348bdfa4b0fe78be630b15914ef1b
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Jul 24 14:11:49 2018

[Background Fetch] Allow updateUI to change the icon

updateUI accepts a dictionary now, where the developer can change the
title and/or the icon.

TBR=haraken@chromium.org

Bug:  865063 
Change-Id: I779c05ee6bdeee83ce94793eddb4409af95395c6
Reviewed-on: https://chromium-review.googlesource.com/1142152
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577524}
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.idl
[add] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_options.idl
[modify] https://crrev.com/f4a2efba220348bdfa4b0fe78be630b15914ef1b/third_party/blink/renderer/modules/modules_idl_files.gni
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a04c812ca3afb3e0b76eba836db02a90ab2591c

commit 0a04c812ca3afb3e0b76eba836db02a90ab2591c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Jul 24 15:46:28 2018

Revert "Reland "[Background Fetch] Move all updatable UI options to their own proto.""

This reverts commit 9311d41253fc74d49527fb2ee69e0363334b969d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 577500 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzMTFkNDEyNTNmYzc0ZDQ5NTI3ZmIyZWU2OWUwMzYzMzM0Yjk2OWQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/41118

Sample Failed Step: viz_content_unittests

Original change's description:
> Reland "[Background Fetch] Move all updatable UI options to their own proto."
> 
> This is a reland of d3981964f2499033059aae600732d656370e0ddf
> 
> TBR=avi@chromium.org
> 
> Original change's description:
> > [Background Fetch] Move all updatable UI options to their own proto.
> >
> > Bundle up the icon and the title since they will be accessed/modified
> > together in the updateUI call.
> >
> > It also makes sense to move the icon from the metadata proto since that
> > will speed up getting the registration info.
> >
> > TBR=avi@chromium.org
> >
> > Bug:  865063 
> > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
> > Reviewed-on: https://chromium-review.googlesource.com/1146650
> > Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Peter Beverloo <peter@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577272}
> 
> Bug:  865063 
> Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25
> Reviewed-on: https://chromium-review.googlesource.com/1148261
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577500}

Change-Id: I60aa46070806c053cc60d77b32456d192de378c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  865063 
Reviewed-on: https://chromium-review.googlesource.com/1148500
Cr-Commit-Position: refs/heads/master@{#577559}
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/BUILD.gn
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/README.md
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/get_initialization_data_task.cc
[delete] https://crrev.com/c3b0effbe9f638243dae263af97794bf010170c1/content/browser/background_fetch/storage/image_helpers.cc
[delete] https://crrev.com/c3b0effbe9f638243dae263af97794bf010170c1/content/browser/background_fetch/storage/image_helpers.h
[delete] https://crrev.com/c3b0effbe9f638243dae263af97794bf010170c1/content/browser/background_fetch/storage/image_helpers_unittest.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/0a04c812ca3afb3e0b76eba836db02a90ab2591c/content/test/BUILD.gn
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b8d879525aeec2fd7c7a3c9c0e90f46da61109

commit 91b8d879525aeec2fd7c7a3c9c0e90f46da61109
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Jul 25 12:03:03 2018

Reland "Reland "[Background Fetch] Move all updatable UI options to their own proto.""

This is a reland of 9311d41253fc74d49527fb2ee69e0363334b969d

TBR=avi@chromium.org

Original change's description:
> Reland "[Background Fetch] Move all updatable UI options to their own proto."
>
> This is a reland of d3981964f2499033059aae600732d656370e0ddf
>
> TBR=avi@chromium.org
>
> Original change's description:
> > [Background Fetch] Move all updatable UI options to their own proto.
> >
> > Bundle up the icon and the title since they will be accessed/modified
> > together in the updateUI call.
> >
> > It also makes sense to move the icon from the metadata proto since that
> > will speed up getting the registration info.
> >
> > TBR=avi@chromium.org
> >
> > Bug:  865063 
> > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
> > Reviewed-on: https://chromium-review.googlesource.com/1146650
> > Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Peter Beverloo <peter@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577272}
>
> Bug:  865063 
> Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25
> Reviewed-on: https://chromium-review.googlesource.com/1148261
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577500}

Bug:  865063 
Change-Id: I766da48a901bc9da8e70acc02855b770f71e09e3
Reviewed-on: https://chromium-review.googlesource.com/1148361
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577843}
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/BUILD.gn
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/README.md
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/get_initialization_data_task.cc
[add] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/image_helpers.cc
[add] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/image_helpers.h
[add] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/image_helpers_unittest.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/91b8d879525aeec2fd7c7a3c9c0e90f46da61109/content/test/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b7e2572d8615524b95c9d47d39d2af024ef4af4

commit 4b7e2572d8615524b95c9d47d39d2af024ef4af4
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Jul 25 18:35:05 2018

[Background Fetch] Persist icon passed to updateUI.

Bug:  865063 
Change-Id: Ic1a85aaaf1874f6b1d4538463a7968a1d9a6be85
Reviewed-on: https://chromium-review.googlesource.com/1145303
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577988}
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/4b7e2572d8615524b95c9d47d39d2af024ef4af4/content/browser/background_fetch/storage/update_registration_ui_task.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6bcbbd0ff95fe98a82cf471478774997a77ad1f

commit f6bcbbd0ff95fe98a82cf471478774997a77ad1f
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Jul 26 22:00:29 2018

[Background Fetch] Propagate UpdateUI params to OIC.

Bug:  865063 
Change-Id: I1b13da06c4f3e8ef6d15cb087f37ffa3394361ef
Reviewed-on: https://chromium-review.googlesource.com/1150522
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578452}
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/chrome/test/data/background_fetch/sw.js
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_data_manager_observer.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/mock_background_fetch_delegate.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
[modify] https://crrev.com/f6bcbbd0ff95fe98a82cf471478774997a77ad1f/content/shell/browser/layout_test/layout_test_background_fetch_delegate.h
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431a8a1d414410c12f7e1bddc69a7a8d88f8add5

commit 431a8a1d414410c12f7e1bddc69a7a8d88f8add5
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Aug 02 18:31:40 2018

[Background Fetch] Update Options and UIOptions IDL definitions

TBR=dcheng@chromium.org

Bug:  865063 
Change-Id: Ieca1efe67cbc9b0340f4bc9f1e0e5af9a0a0391d
Reviewed-on: https://chromium-review.googlesource.com/1160442
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580257}
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.serviceworker-expected.txt
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_options.idl
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc
[add] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_ui_options.idl
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.idl
[delete] https://crrev.com/388ad143e27333453092c76b46e940c30f12350e/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_options.idl
[modify] https://crrev.com/431a8a1d414410c12f7e1bddc69a7a8d88f8add5/third_party/blink/renderer/modules/modules_idl_files.gni
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732c168a96e32d62fd7e7017e5ee5700a1605939

commit 732c168a96e32d62fd7e7017e5ee5700a1605939
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Aug 07 19:50:04 2018

Update Android notification UI when offline item is complete.

This change updates the OfflineContentProvider onItemUpdated observer
function to include whether the visuals need to be updated.
This allows to change the notification icon from the offline item.

Bug:  865063 
Change-Id: I47fb04700c550fb630fefa328b634c979c25cd27
Reviewed-on: https://chromium-review.googlesource.com/1156592
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581313}
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/chrome/android/junit/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUiTest.java
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemBridge.java
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/android/offline_item_bridge.cc
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/offline_item.cc
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/offline_item.h
[modify] https://crrev.com/732c168a96e32d62fd7e7017e5ee5700a1605939/components/offline_items_collection/core/test_support/offline_item_test_support.cc

Comment 12 by rayankans@chromium.org, Aug 7

Status: Fixed (was: Started)
►

Sign in to add a comment