New issue
Advanced search Search tips

Issue 865059 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
sergeyu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Provide templates for actions which run tools from the Fuchsia SDK

Project Member Reported by w...@chromium.org, Jul 18 
We currently run tools like fidlc, fidlgen, etc via GN action()s which use a Python stub script to run the actual tool.

Rather than repeatedly re-implementing all that complexity for each case (e.g. determining tool paths, ensure a dependency on the tool itself, etc) we could provide a base fuchsia_sdk_tool() template that these different templates could build upon.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df1806f1f9a92940bb6404a8788b5f0bda2aae14

commit df1806f1f9a92940bb6404a8788b5f0bda2aae14
Author: Wez <wez@chromium.org>
Date: Wed Jul 18 17:19:16 2018

[Fuchsia] Add dependency on SDK version to GN rules for generators, etc.

Without this dependency making an SDK update containing e.g. a FIDL
generator change would not cause FIDL stubs to be regenerated.

Bug: 865059
Change-Id: If760cccfd0a2357abdd3f4f32281fb2dd79cbd43
Reviewed-on: https://chromium-review.googlesource.com/1142127
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576104}
[modify] https://crrev.com/df1806f1f9a92940bb6404a8788b5f0bda2aae14/build/config/fuchsia/fidl_library.gni
[modify] https://crrev.com/df1806f1f9a92940bb6404a8788b5f0bda2aae14/build/config/fuchsia/package.gni
►

Sign in to add a comment