New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Provision metrics include repairs

Reported by jrbarnette@chromium.org, Jul 18

Issue description

Currently, every time we invoke machine_install_and_update_labels,
we generate metrics relating to success or failure of the installation
operation.  As it happens, many repair operations include a call
to this function.

The result is that every time we attempt to repair a device, then,
pass or fail, we also generate metrics that claim to be for provisioning.
This is awkward:  we want the provisioning metrics (especially for failures)
to be about provisioning tasks, not repair tasks.

 
Cc: akes...@chromium.org pprabhu@chromium.org
Owner: jrbarnette@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4c81b9797dfd35927c0f02e611a6d1c1a9f3d477

commit 4c81b9797dfd35927c0f02e611a6d1c1a9f3d477
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Mon Jul 23 19:59:55 2018

[autotest] Make provisioning metrics for Provisioning only.

This moves generation of metrics for provisioning to be emitted only
during Provisioning tasks, and not also during Repair tasks.

BUG= chromium:865047 
TEST=run the sanity suite in a local Autotest instance

Change-Id: I801e5d6141a7b454d546b9f384c90b160741c5f6
Reviewed-on: https://chromium-review.googlesource.com/1142434
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4c81b9797dfd35927c0f02e611a6d1c1a9f3d477/server/cros/autoupdater.py
[modify] https://crrev.com/4c81b9797dfd35927c0f02e611a6d1c1a9f3d477/server/site_tests/provision_AutoUpdate/provision_AutoUpdate.py

Status: Fixed (was: Started)

Sign in to add a comment