New issue
Advanced search Search tips

Issue 865044 link

Starred by 1 user
Status: Verified
Owner:
sczs@chromium.org
Closed: Jul 24
Cc:
thegreenfrog@chromium.org
kariahda@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression
Q2
Team-Accessibility



Sign in to add a comment

Two finger Swipe-Z gesture doesn't dismiss few screens.

Project Member Reported by srikanthg@chromium.org, Jul 18 
App Version: 69.0.3495.0 canary
iOS Version: 11.4.1, 12.0 beta#4
Device: iPhone6s, iPhoneX, iPad Pro
URL: n/a

Precondition: Enable Voice Over (Settings > General > Accessibility > VoiceOver > ON)

Steps to reproduce:
  1. Launch Google Chrome
  2. Tap Manu > History OR ReadingList OR Recent Tabs
  3.  Perform gesture "Two finger swipe - Z" to dismiss the Screen.

Observed results: No action performed

Note: Works with Bookmarks and Settings screens.

Expected results: Screen should be dismissed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes

Comment 1 by sczs@chromium.org, Jul 18

Cc: thegreenfrog@chromium.org
Labels: M-69 ReleaseBlock-Stable
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Since this an important gesture that dismisses the screen we should implement it before releasing

Comment 2 by sczs@chromium.org, Jul 19

Labels: Q2

Comment 3 by sczs@chromium.org, Jul 20

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a57a8953ba37cb2baf05aee0f7f2613468fe5fb

commit 7a57a8953ba37cb2baf05aee0f7f2613468fe5fb
Author: sczs <sczs@chromium.org>
Date: Tue Jul 24 01:52:43 2018

[ios] Implements accessibilityPerformEscape on UIRefresh collections.

Bug:  865044 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9099ae71217f68eb624332debb8260faa067991d
Reviewed-on: https://chromium-review.googlesource.com/1145629
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577403}
[modify] https://crrev.com/7a57a8953ba37cb2baf05aee0f7f2613468fe5fb/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/7a57a8953ba37cb2baf05aee0f7f2613468fe5fb/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/7a57a8953ba37cb2baf05aee0f7f2613468fe5fb/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

Comment 5 by sczs@chromium.org, Jul 24

Status: Fixed (was: Started)

Comment 6 by marq@chromium.org, Jul 25

Labels: Merge-TBD

Comment 7 by sczs@chromium.org, Jul 27

Cc: kariahda@chromium.org
Labels: Merge-Request-69
Verified on Canary, kariahda@ could you PTAL

Comment 8 by kariahda@chromium.org, Jul 27

Labels: -Merge-TBD -Merge-Request-69 Merge-Approved-69
Approved!
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c775cd33ca9ac42c980c7756fb17ef46f28fa084

commit c775cd33ca9ac42c980c7756fb17ef46f28fa084
Author: sczs <sczs@chromium.org>
Date: Fri Jul 27 23:13:04 2018

[ios] Implements accessibilityPerformEscape on UIRefresh collections.

TBR=sczs@chromium.org

(cherry picked from commit 7a57a8953ba37cb2baf05aee0f7f2613468fe5fb)

Bug:  865044 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9099ae71217f68eb624332debb8260faa067991d
Reviewed-on: https://chromium-review.googlesource.com/1145629
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577403}
Reviewed-on: https://chromium-review.googlesource.com/1153973
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#182}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/c775cd33ca9ac42c980c7756fb17ef46f28fa084/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/c775cd33ca9ac42c980c7756fb17ef46f28fa084/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/c775cd33ca9ac42c980c7756fb17ef46f28fa084/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

Comment 10 by subhashi...@chromium.org, Aug 1

Status: Verified (was: Fixed)
Verified in:

App Version: 70.0.3509.0 canary & 69.0.3497.22 beta
Devices: iPhone 7 Plus, iPhone 6 Plus, iPad Air
iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5

Able to dismiss History, Recent Tabs, Reading list and Settings screens using Two finger'Z' swipe gesture
►

Sign in to add a comment