New issue
Advanced search Search tips

Issue 865039 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

compositing modifes mask and filter

Project Member Reported by petermayo@chromium.org, Jul 18 
compositing/masks/mask-with-added-filters layout test demonstrates that compositing changes the application of filters too much

Note that we can do a lot better with the flag --enable-blink-gen-property-trees.
mask-with-added-filters-expected.png
47.3 KB View Download
mask-with-added-filters-ACTUAL.png
61.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b277b01fb2b57f68b1c7d9a63586274f1d40b8d

commit 1b277b01fb2b57f68b1c7d9a63586274f1d40b8d
Author: nednguyen <nednguyen@google.com>
Date: Wed Jul 18 18:53:41 2018

Mark compositing/masks/mask-with-added-filters.html as Fail

This is to remove the last usage of NeedsManualRebaseline

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b

BUG: 865039, 621126
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b
Reviewed-on: https://chromium-review.googlesource.com/1142194
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576151}
[modify] https://crrev.com/1b277b01fb2b57f68b1c7d9a63586274f1d40b8d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65cc8767eee7e3b2c9b4ad7f8cd5dc6736c48c39

commit 65cc8767eee7e3b2c9b4ad7f8cd5dc6736c48c39
Author: Peter Mayo <petermayo@chromium.org>
Date: Wed Jul 18 23:39:17 2018

[BGPT] Add a flag specific expectation of passing.

This flag specifically improves the results of layout test
compositing/masks/mask-with-added-filters.html


Bug: 865039
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8589dacff3c77b42931e58bc3d39c0360f93aa9e
Reviewed-on: https://chromium-review.googlesource.com/1142237
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576253}
[modify] https://crrev.com/65cc8767eee7e3b2c9b4ad7f8cd5dc6736c48c39/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[add] https://crrev.com/65cc8767eee7e3b2c9b4ad7f8cd5dc6736c48c39/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/masks/mask-with-added-filters-expected.png

Comment 3 by schenney@chromium.org, Jul 23

Labels: Test-Layout
Status: Available (was: Untriaged)
►

Sign in to add a comment