Split NotificationTestRule into EmbeddedTestServerRule and NotificationTestRule |
||
Issue descriptionThis will enable NotificationTestRule to be used alongside PermissionTestRule. Right now attempting to use both from NotificationPlatformBridgeTest results in a failure, presumably due to them both attempting to create a test server in setup: C 79.613s Main [FAIL] org.chromium.chrome.browser.notifications.NotificationPermissionTest#testPermissionGranted: C 79.613s Main org.chromium.net.test.EmbeddedTestServer$EmbeddedTestServerFailure: Failed to add default handlers a nd start serving files from : android.os.DeadObjectException C 79.613s Main at org.chromium.net.test.EmbeddedTestServer.addDefaultHandlers(EmbeddedTestServer.java:213) C 79.613s Main at org.chromium.net.test.EmbeddedTestServer.initializeAndStartServer(EmbeddedTestServer.java:379) C 79.613s Main at org.chromium.net.test.EmbeddedTestServer.createAndStartServer(EmbeddedTestServer.java:345) C 79.613s Main at org.chromium.chrome.browser.notifications.NotificationTestRule.setUp(NotificationTestRule.j ava:53) C 79.613s Main at org.chromium.chrome.browser.notifications.NotificationTestRule.access$100(NotificationTestR ule.java:34) C 79.613s Main at org.chromium.chrome.browser.notifications.NotificationTestRule$3.evaluate(NotificationTestRule.java:137) C 79.613s Main at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116) C 79.613s Main at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:5 5) C 79.614s Main at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java :270) C 79.614s Main at org.chromium.chrome.browser.permissions.PermissionTestRule$1.evaluate(PermissionTestRule.ja va:99)
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56e2b19423bd8bfc79470df3aae8e6944993d9e2 commit 56e2b19423bd8bfc79470df3aae8e6944993d9e2 Author: Anita Woodruff <awdf@chromium.org> Date: Fri Jul 20 09:27:13 2018 [Android Tests] Use EmbeddedTestServerTestRule for notification tests - Rather than using an embedded test server directly within NotificationTestRule, use an EmbeddedTestServerTestRule from those tests that use this rule explicitly. - This is a precursor to being able to use PermissionTestRule from NotificationPlatformBridgeTest in order to re-enable the permission tests (because PermissionTestRule uses an EmbeddedServerTestRule internally too atm and they clash). Bug: 865034 Change-Id: I2cc61938acf5cd449dc2a5fecdec69e0a1167c6d Reviewed-on: https://chromium-review.googlesource.com/1142148 Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#576818} [modify] https://crrev.com/56e2b19423bd8bfc79470df3aae8e6944993d9e2/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java [modify] https://crrev.com/56e2b19423bd8bfc79470df3aae8e6944993d9e2/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationTestRule.java [modify] https://crrev.com/56e2b19423bd8bfc79470df3aae8e6944993d9e2/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java [modify] https://crrev.com/56e2b19423bd8bfc79470df3aae8e6944993d9e2/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerRule.java
,
Jul 24
|
||
►
Sign in to add a comment |
||
Comment 1 by awdf@chromium.org
, Jul 18