New issue
Advanced search Search tips

Issue 865027 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 865000
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

No magnifying glass in focused NTP omnibox

Project Member Reported by pschaffner@chromium.org, Jul 18

Issue description

1. cold start chrome
2. open a new tab
3. focus the omnibox
4. note there is no leading-edge completion icon (specifically the magnifying glass)

You can force a magnifying glass in this context by starting to type, getting a top-ranked query suggestion, defocusing, then refocusing ... but that isn't a very nice workaround ;)
 
Cc: -stkhapugin@chromium.org justincohen@chromium.org
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
stkhapugin@ could you PTAL?
Labels: Q2 M-69 MS-Omnibox
Status: Started (was: Assigned)
Seems like upon focusing the omnibox, we need to always show the magnifying glass. 
Technically, focusing an non-NTP omnibox should have the generic favicon icon I believe.
Cc: stkhapugin@chromium.org
Owner: pschaffner@chromium.org
Status: Assigned (was: Started)
The previous implementation was using the location/security icon here. What would you consider the correct behaviour now? Should it just always default to the globe icon? 
Owner: stkhapugin@chromium.org
Yes, I think it should always default to the globe (in a non-NTP state).
Status: Started (was: Assigned)
Mergedinto: 865000
Status: Duplicate (was: Started)
Fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1146926. Will request merge there. 

Sign in to add a comment