New issue
Advanced search Search tips

Issue 865018 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 773295
issue 789670



Sign in to add a comment

Migrate google_apis/gaia/gaia_oauth_client.cc to SimpleURLLoader

Project Member Reported by morlovich@chromium.org, Jul 18

Issue description

Used by things with 'signin' in path, so probably needed for canary?
 
Cc: reillyg@chromium.org
FYI Reilly: the meeting spreadsheet seems to connect your name to signin, and I think this is a big part of it. In-progress in https://chromium-review.googlesource.com/c/chromium/src/+/1148471, but some stuff doesn't build yet (though a lot of stuff builds & passes tests)
Blocking: 773295
Status: Started (was: Assigned)
Marking this as started since you have a patch underway.
morlovich@, any update here? are you blocked on reviews?
morlovich@ appears to have a WIP patch here:

https://chromium-review.googlesource.com/c/chromium/src/+/1148471
Labels: OS-Windows
Labels: -Pri-3 OS-Android OS-Linux OS-Mac Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44cd1928239236ba639176ddbbd9fb83606ed819

commit 44cd1928239236ba639176ddbbd9fb83606ed819
Author: Maks Orlovich <morlovich@chromium.org>
Date: Fri Aug 10 15:32:21 2018

IdentityTestEnvironment: explicitly track pending & available token requests

... Rather than relying on them to be sufficiently close to each other
that there isn't much event loop activity.

This is needed for upcoming port of GaiaOauthClient to Network Service
(and hence mojo), which requires tests to spin the event loop in a lot
more places than before to deliver fetch results, making it hard to
ensure that HandleOnAccessTokenRequested and WaitForAccessTokenRequestIfNecessary
get delivered in right order.

Bug:  865018 
Change-Id: I7acf6427be7be5b00c8e003dd687169c4b8a7577
Reviewed-on: https://chromium-review.googlesource.com/1167904
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582176}
[modify] https://crrev.com/44cd1928239236ba639176ddbbd9fb83606ed819/services/identity/public/cpp/identity_test_environment.cc
[modify] https://crrev.com/44cd1928239236ba639176ddbbd9fb83606ed819/services/identity/public/cpp/identity_test_environment.h

Blocking: 789670
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db7d0d6b7cef5759b8709b405d7df043477b53a

commit 8db7d0d6b7cef5759b8709b405d7df043477b53a
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Aug 16 19:22:27 2018

S13n: Port GaiaOauthClient to SimpleURLLoader

URLFetcher will stop working in the browser process with
advent of Network Service, and SimpleURLLoader is the replacement
API for most clients.


Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icfbc714b2336360abd651ffd0ea4a8aeff1f21c5
Bug:  865018 
Reviewed-on: https://chromium-review.googlesource.com/1148471
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583768}
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/login/signin/token_handle_fetcher.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/login/signin/token_handle_util.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/service/cloud_print/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/service/cloud_print/cloud_print_auth.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/service/cloud_print/cloud_print_auth.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/chrome/service/cloud_print/cloud_print_proxy_backend.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/account_tracker.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/account_tracker.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/account_tracker_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/gcm_account_tracker_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/signin/core/browser/account_fetcher_service.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/signin/core/browser/account_info_fetcher.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/signin/core/browser/account_info_fetcher.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/components/signin/core/browser/account_tracker_service_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/google_apis/gaia/gaia_oauth_client.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/google_apis/gaia/gaia_oauth_client.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/google_apis/gaia/gaia_oauth_client_unittest.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/base/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/base/gaia_oauth_client.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/base/gaia_oauth_client.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/base/oauth_token_getter_impl.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/base/oauth_token_getter_impl.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/client/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/client/chromoting_client_runtime.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/chromoting_host_context.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/chromoting_host_context.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/mac/BUILD.gn
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/setup/BUILD.gn
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/setup/host_starter.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/setup/host_starter.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/setup/me2me_native_messaging_host_main.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/setup/start_host_main.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/host/win/BUILD.gn
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/ios/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/ios/facade/remoting_oauth_authentication.mm
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/test/BUILD.gn
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/test/DEPS
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/test/access_token_fetcher.cc
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/test/access_token_fetcher.h
[modify] https://crrev.com/8db7d0d6b7cef5759b8709b405d7df043477b53a/remoting/test/access_token_fetcher_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment