New issue
Advanced search Search tips

Issue 865017 link

Starred by 1 user
Status: Fixed
Owner:
majidvp@chromium.org
Closed: Jul 20
Cc:
ikilpatrick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 430155



Sign in to add a comment

Move animationWorklet from window to CSS

Project Member Reported by majidvp@chromium.org, Jul 18 
All other houdini APIs are in CSS namespace (e.g., CSS.paintWorklet, CSS.layoutWorklet). It seems reasonable that we should move animationWorklet in CSS as well.

The only counter-argument is that unlike other houdini worklets, AW currently does not integrate with css directly. However this is a temporary state and consistency with other houdini API is a stron motivation.

This also needs updating spec and all demos, polyfill etc.
https://github.com/WICG/animation-worklet/issues/99
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c188f8687c84198d4b2dfc9b9ea653107ad856c7

commit c188f8687c84198d4b2dfc9b9ea653107ad856c7
Author: Majid Valipour <majidvp@chromium.org>
Date: Thu Jul 19 17:47:02 2018

[animationworklet] Move global from window to CSS namespace

The interesting changes are in css_animation_worklet.idl
 - change AW to be static attribute on partial CSS interface.
 - explicitly asking binding to pass in ScriptState since
   window is no longer available. This means changing few function
   that used to take ExecutionContext to take ScriptState.


There rest are automated renames from
Window.animationWorklet => CSS.animationWorklet
WindowAnimationWorklet => CSSAnimationWorklet


Bug:  865017 
Change-Id: Ic89dc50a027ca225f5e19d9d9dc6b38a8aef7a7d
Reviewed-on: https://chromium-review.googlesource.com/1142372
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576555}
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/worklet-test-utils.js
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-on-animation-worklet.js
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope.html
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/http/tests/worklet/resources/worklet-test-utils.js
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/resources/animation-worklet-tests.js
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/BUILD.gn
[add] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/css_animation_worklet.cc
[add] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/css_animation_worklet.h
[rename] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/css_animation_worklet.idl
[delete] https://crrev.com/338ba0e2715f166fc50b6a92e41f865d03cdc3e1/third_party/blink/renderer/modules/animationworklet/window_animation_worklet.cc
[delete] https://crrev.com/338ba0e2715f166fc50b6a92e41f865d03cdc3e1/third_party/blink/renderer/modules/animationworklet/window_animation_worklet.h
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/worklet_animation.h
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/worklet_animation.idl
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc
[modify] https://crrev.com/c188f8687c84198d4b2dfc9b9ea653107ad856c7/third_party/blink/renderer/modules/modules_idl_files.gni

Comment 2 by majidvp@chromium.org, Jul 20

Status: Fixed (was: Assigned)
Fixed. I will start updating our demos and docs now.
►

Sign in to add a comment