Not sure it's canary blocking
It certainly looks to be canary blocking on ChromeOS...I'm not rightly sure about other platforms. Let's be cautious here.
hey ... can we see if this is also blocks Windows?
wip: https://chromium-review.googlesource.com/c/chromium/src/+/1138795 I'd assume that this is applicable to OS-Windows. Adding back the flag.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6246ea83f3bd5fc7c814b9157de7578bb3999aed commit 6246ea83f3bd5fc7c814b9157de7578bb3999aed Author: Maks Orlovich <morlovich@chromium.org> Date: Wed Aug 08 14:19:10 2018 S13n: Port oauth2_api_call_flow to SimpleURLLoader URLFetcher will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 865015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I248ff39534aeab11be4a60826edf7e89256ad2dc Reviewed-on: https://chromium-review.googlesource.com/1138795 Reviewed-by: Stuart Langley <slangley@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581556} [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chrome/browser/chromeos/drive/drive_integration_service.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/components/drivefs/BUILD.gn [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/components/drivefs/drivefs_host.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/components/drivefs/drivefs_host.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/components/drivefs/drivefs_host_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/BUILD.gn [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/device_sync_impl.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/device_sync_impl.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/device_sync_service.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/device_sync_service.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/device_sync_service_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/public/cpp/BUILD.gn [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/DEPS [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_api_call_flow.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_api_call_flow.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_api_call_flow_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_client_impl.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_client_impl.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/components/cryptauth/cryptauth_client_impl_unittest.cc [add] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/extensions/shell/browser/api/identity/DEPS [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/extensions/shell/browser/api/identity/identity_api.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/extensions/shell/browser/api/identity/identity_api_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/BUILD.gn [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/gaia_auth_fetcher_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_api_call_flow.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_api_call_flow.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_api_call_flow_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_mint_token_flow.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_mint_token_flow.h [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_mint_token_flow_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/oauth2_token_service_unittest.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/gaia/ubertoken_fetcher_unittest.cc [add] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/test/DEPS [add] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/google_apis/test/run_all_unittests.cc [modify] https://crrev.com/6246ea83f3bd5fc7c814b9157de7578bb3999aed/services/network/test/test_utils.cc
Issue 826780 has been merged into this issue.
Comment 1 by morlovich@chromium.org
, Jul 18