stkhapugin@ PTAL

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc

commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 23 13:29:18 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577161}
[modify] https://crrev.com/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d73dbd650f80985ebb76c86e28af122f1901ab

commit f8d73dbd650f80985ebb76c86e28af122f1901ab
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jul 25 11:40:02 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577161}(cherry picked from commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc)
Reviewed-on: https://chromium-review.googlesource.com/1150100
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#66}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/f8d73dbd650f80985ebb76c86e28af122f1901ab/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

This was merged without approval. Did I miss something here?

This is the same CL as  crbug.com/865019 

This is the same CL as  crbug.com/865019 

Ok I see this was approved on this bug. https://bugs.chromium.org/p/chromium/issues/detail?id=865019

Gotcha, thank you for updating with adjacent bugs.

Verified on chrome canary version 70.0.3509.0 on iPhone 8 plus with iOS 11.4.1, 12 beta 5, following steps mentioned in comment #0.  "x" button is visible typing text.  Looks good.

Removing Merge-TBD label. This was merged as a part of crbug/865019.

Verified the issue on the build 69.0.3497.22 beta tested on iPhone(iOS 11.4).
"x" button is visible typing text.