New issue
Advanced search Search tips

Issue 865006 link

Starred by 2 users
Status: Verified
Owner:
hbos@chromium.org
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Improve webrtc_set_description_observer_handler_unittest.cc

Project Member Reported by hbos@chromium.org, Jul 18 
Test coverage currently only covers the WebRtcSetRemoteDescriptionObserverHandler, it should also cover WebRtcSetLocalDescriptionObserverHandler.

Also, it only covers the case of "surface_receivers_only == true", it should also cover "surface_receivers_only == false" (surface transceiver).

Can we parameterize the tests?

Comment 1 by hbos@chromium.org, Oct 31

Blocking: 897251
Labels: -Pri-3 M-72 Pri-1
Status: Started (was: Available)

Comment 3 by hbos@chromium.org, Nov 1

Blocking: -897251

Comment 4 by hta@chromium.org, Nov 4

Owner: hbos@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07a1e235baae77255e03416489ee8e46f599b056

commit 07a1e235baae77255e03416489ee8e46f599b056
Author: Henrik Boström <hbos@chromium.org>
Date: Mon Nov 05 16:13:49 2018

Parameterize WebRtcSetDescriptionObserverHandlerTest.

Handlers exists in two flavors, WebRtcSetLocalDescriptionObserverHandler
which is used for setLocalDescription(), and
WebRtcSetRemoteDescriptionObserverHandler which is used for
setRemoteDescription(). They have the same functionality but have to be
different classes due to webrtc observer interfaces being different
classes.

Each handler can operate in two modes: surfacing transceiver states
(includes senders and receivers) or only surfacing receiver states.

Prior to this CL, only the "remote" handler and "receiver only" mode
was tested. With this CL, all four combinations
"(local/remote) x (transceivers/receivers)" are tested using
parameterized gtests.

This improves test coverage and unblocks testing that is needed to solve
a bug related to surfacing transceivers (https://crbug.com/897251).

Bug:  865006 
Change-Id: Iaf40b498b0fef0978c4179c47118f6cff0bcdf66
Reviewed-on: https://chromium-review.googlesource.com/c/1309747
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605350}
[modify] https://crrev.com/07a1e235baae77255e03416489ee8e46f599b056/content/renderer/media/webrtc/mock_peer_connection_impl.cc
[modify] https://crrev.com/07a1e235baae77255e03416489ee8e46f599b056/content/renderer/media/webrtc/mock_peer_connection_impl.h
[modify] https://crrev.com/07a1e235baae77255e03416489ee8e46f599b056/content/renderer/media/webrtc/webrtc_set_description_observer_unittest.cc

Comment 6 by hbos@chromium.org, Nov 5

Status: Verified (was: Started)
►

Sign in to add a comment