Headless WebSocket server can't handle ping frames
Reported by
dariokon...@gmail.com,
Jul 18
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 Steps to reproduce the problem: 1. Open a headless chromium 2. Send a ping to the WebSocket. What is the expected behavior? It should keep the connection alive. What went wrong? The WebSocket closes. Did this work before? No Does this work in other browsers? Yes Chrome version: 67.0.3396.99 Channel: stable OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 30.0 r0 Related to https://groups.google.com/a/chromium.org/forum/#!mydiscussions/chromium-discuss/nPiz9ukGJfo Puppeteer-Sharp OSX demo app attached, it will fail after a few seconds.
,
Jul 18
,
Jul 19
So this is not about the client-side WebSocket implemented in net/websockets but the server-side implementation contained in Chrome?
,
Jul 19
#3 Correct. The issue is in DecodeFrameHybi17 here: https://cs.chromium.org/chromium/src/net/server/web_socket_encoder.cc?l=52 There's another copy of this under //services/network that will also need to be fixed. AFAIK there isn't a proper component or owner for that server, so it ends up being our problem. Lowering the priority as there is a known workaround, ie. don't send pings.
,
Jul 20
,
Aug 14
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rsesek@chromium.org
, Jul 18