RxR leading edge completion icon and completion type icon should match |
|||||||||
Issue descriptionIn the omnibox, the leading edge completion icons are currently the old ones, and are not in sync with the new completion type icons shown in the completion view. You can use the same assets and tint colors provided here https://bugs.chromium.org/p/chromium/issues/detail?id=821817#c22.
,
Jul 18
,
Jul 19
,
Jul 19
,
Jul 19
,
Jul 19
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3188821a3d6050924de5bec497c73bbfb0327c commit ba3188821a3d6050924de5bec497c73bbfb0327c Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Thu Jul 19 16:19:12 2018 Use UI Refresh icons for suggestions in the omnibox. Uses new completion icons in the omnibox. Bug: 864990 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic062601ec2b0eb665c8e80779ffc04d90bbb5723 Reviewed-on: https://chromium-review.googlesource.com/1143274 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576516} [modify] https://crrev.com/ba3188821a3d6050924de5bec497c73bbfb0327c/ios/chrome/browser/ui/omnibox/omnibox_mediator.mm
,
Jul 23
,
Jul 25
,
Aug 23
Verified in 69.0.3497.58 Beta in iPad Air(iOS 12 beta9), iPhone 2018(iOS 11.4.1) Omnibox now displays the new completion icons Link to screenshot: https://drive.google.com/file/d/1nhTInnGkfs-qrDFWO2M-nbrD_dE5Gjk5/view?usp=sharing
,
Aug 23
Correction in comment#10 incorrect device name mentioned below are the correct devices iPad Air(iOS 12 beta9), iPad 2018(iOS 11.4.1) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pschaffner@chromium.org
, Jul 18