Issue metadata
Sign in to add a comment
|
Regression:Background contents('Birthday') is seen while hovering mouse on password generated drop down.
Reported by
shruti.j...@etouch.net,
Jul 18
|
||||||||||||||||||||||
Issue descriptionChrome Version : 69.0.3495.0 (Official Build) Revision bc6daf0166d18e090b7026ceae6c5d4f448d082b-refs/branch-heads/3495@{#1} (64 bit) OS: Mac(10.12.6,10.13.1,10.13.6,10.14.0) Pre-condition: 1.Enable 'Automatic Password Generation' from chrome://flags and Relaunch the browser. 2.Sign in to chrome with valid credentials. Test URL: https://www.facebook.com/ Steps to reproduce: 1.Launch chrome and Navigate to above URL. 2.Click on 'New Password' so that password generation auto-populate. 3.Hover the mouse on password generated drop down. Actual Result: Background contents('Birthday') is seen while hovering mouse on password generated drop down. Expected Result:Background contents('Birthday') should not be seen while hovering mouse on password generated drop down. This is a regression issue, broken in 'M-69', and below is per-revision bisect-info: Good Build:69.0.3494.0 (Revision:575514) Bad Build: 69.0.3495.0 (Revision:575926) You are probably looking for a change made after 575697 (known good), but no later than 575698 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5240a33ded02b4e0b90b235dae805e07f5cd39a4..fa89015c94aa96aed4bcf1452b8c808de3ab627c Suspect: https://chromium.googlesource.com/chromium/src/+/fa89015c94aa96aed4bcf1452b8c808de3ab627c @Vasilii Sukhanov : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c9d329c0c2d3bba5af886573813b433bcb647f3 commit 1c9d329c0c2d3bba5af886573813b433bcb647f3 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Jul 19 15:26:45 2018 Share the autofill constants between the password generation and autofill views. As a nice side effect, the issue with transparency in the generation prompt is fixed. Bug: 864978 Change-Id: I58d4d04053297dda1b2a4aa5cfce381b0062eadd Reviewed-on: https://chromium-review.googlesource.com/1141962 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576503} [modify] https://crrev.com/1c9d329c0c2d3bba5af886573813b433bcb647f3/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/1c9d329c0c2d3bba5af886573813b433bcb647f3/chrome/browser/ui/views/autofill/autofill_popup_base_view.h [modify] https://crrev.com/1c9d329c0c2d3bba5af886573813b433bcb647f3/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/1c9d329c0c2d3bba5af886573813b433bcb647f3/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
,
Jul 19
,
Jul 20
Update : Retested above issue on Mac(10.12.6,10.13.1,10.13.6,10.14.0)OS using latest Canary #69.0.3497.0 and issue is fixed. Now ,Background contents are not seen while hovering mouse on password generated drop down.Kindly review the attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vasi...@chromium.org
, Jul 1820.6 KB
20.6 KB View Download
20.9 KB
20.9 KB View Download