New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864949 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Re-evaluate SyncStartupTracker

Project Member Reported by treib@chromium.org, Jul 18

Issue description

SyncStartupTracker is a helper class that supposedly helps with observing Sync's startup sequence. It's used by some UI code, DiceTurnSyncOnHelper and PeopleHandler. However,
a) its semantics are a bit weird (it says SYNC_STARTUP_COMPLETE as soon as the engine is initialized), and
b) SyncService::GetState() should make this task easy enough without any special helper class.

I'm also not sure whether auth errors are treated consistently: If an auth errors occurs before the engine is initialized, it's considered an error, but if it happens after the engine is initialized, it's success.

So, maybe we can just get rid of the helper class and check GetState() directly instead, or if we decide to keep it, we should at least implement it in terms of GetState().
 
Labels: sync-fixit-2018q4

Sign in to add a comment