New issue
Advanced search Search tips

Issue 864948 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 824539
Owner: ----
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

layouttest cannot dump pixel on android

Reported by zljj0...@gmail.com, Jul 18

Issue description

Steps to reproduce the problem:
1. build content shell and blink test apks
2. run layouttest with dump pixel enable

What is the expected behavior?
layouttest can dump pixel on android

What went wrong?
On 68.0.3440.8, layout test can not dump pixels on android.

Did this work before? N/A 

Chrome version: 68.0.3440.8  Channel: stable
OS Version: 4.4.4
Flash Version: Shockwave Flash 30.0 r0
 
layoutests has set viewport size,
but later m68 will set empty viewport, which will cause SingleThreadProxy::DoComposite return(for LayerTreeHostImpl::CanDraw return false width empty deviceViewport), and 
layoutest can not dump pixels.
//// In this bt, testRunner set correct viewport
0x00adfb63: content::RenderWidget::UpdateSurfaceAndScreenInfo(viz::LocalSurfaceId const&, gfx::Size const&, content::ScreenInfo const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:1761
0x00ae1c19: content::RenderWidget::SynchronizeVisualProperties(content::VisualProperties const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:1264
0x00ae0de1: content::RenderWidget::SetWindowRectSynchronously(gfx::Rect const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:731
0x00ade80b: content::RenderViewImpl::ForceResizeForTesting(gfx::Size const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_view_impl.cc:2364
0x0013d9e9: content::ForceResizeRenderView(content::RenderView*, blink::WebSize const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/test/layouttest_support.cc:501
0x00122dab: content::BlinkTestRunner::OnSetTestConfiguration(mojo::StructPtr<content::mojom::ShellTestConfiguration>) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/shell/renderer/layout_test/blink_test_runner.cc:870
0x00123bd3: content::LayoutTestRenderFrameObserver::SetTestConfiguration(mojo::StructPtr<content::mojom::ShellTestConfiguration>) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/shell/renderer/layout_test/layout_test_render_frame_observer.cc:91
0x000af10f: content::mojom::LayoutTestControlStubDispatch::Accept(content::mojom::LayoutTestControl*, mojo::Message*) at /home/zhouliang/work2/u4.3/src/out/Release/gen/content/shell/common/layout_test.mojom.cc:?


////In this bt, chromium set empty viewport, and make layouttest can not dump pixel
0x00adfb63: content::RenderWidget::UpdateSurfaceAndScreenInfo(viz::LocalSurfaceId const&, gfx::Size const&, content::ScreenInfo const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:1761
0x00ae1c19: content::RenderWidget::SynchronizeVisualProperties(content::VisualProperties const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:1264
0x00ae0f3b: content::RenderWidget::OnSynchronizeVisualProperties(content::VisualProperties const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:786
0x00adde6b: content::RenderViewImpl::OnSynchronizeVisualProperties(content::VisualProperties const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_view_impl.cc:1988
0x0077bb8b: void base::DispatchToMethod<content::RenderWidget*, void (content::RenderWidget::*)(blink::WebDeviceEmulationParams const&), std::__1::tuple<blink::WebDeviceEmulationParams> >(content::RenderWidget* const&, void (content::RenderWidget::*)(blink::WebDeviceEmulationParams const&), std::__1::tuple<blink::WebDeviceEmulationParams>&&) at /home/zhouliang/work2/u4.3/src/out/Release/../../base/tuple.h:60
 (inlined by) void IPC::DispatchToMethod<content::RenderWidget, void (content::RenderWidget::*)(blink::WebDeviceEmulationParams const&), void, std::__1::tuple<blink::WebDeviceEmulationParams> >(content::RenderWidget*, void (content::RenderWidget::*)(blink::WebDeviceEmulationParams const&), void*, std::__1::tuple<blink::WebDeviceEmulationParams>&&) at /home/zhouliang/work2/u4.3/src/out/Release/../../ipc/ipc_message_templates.h:51
0x00ae0061: bool IPC::MessageT<ViewMsg_SynchronizeVisualProperties_Meta, std::__1::tuple<content::VisualProperties>, void>::Dispatch<content::RenderWidget, content::RenderWidget, void, void (content::RenderWidget::*)(content::VisualProperties const&)>(IPC::Message const*, content::RenderWidget*, content::RenderWidget*, void*, void (content::RenderWidget::*)(content::VisualProperties const&)) at /home/zhouliang/work2/u4.3/src/out/Release/../../ipc/ipc_message_templates.h:146
0x00adfd85: content::RenderWidget::OnMessageReceived(IPC::Message const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_widget.cc:652
0x00adc35f: content::RenderViewImpl::OnMessageReceived(IPC::Message const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/renderer/render_view_impl.cc:1095
0x00667565: content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage(IPC::Message const&) at /home/zhouliang/work2/u4.3/src/out/Release/../../content/child/child_thread_impl.cc:370
Components: Blink>Infra
Cc: jbudorick@chromium.org
Android 4.4.4 is K (KitKat), and I thought that actually worked somewhat given that issue 567947 is about making layout tests work on L+.

 jbudorick@, in your adventures with layout tests on Android, have you come across this issue? Has it ever worked at all?
Mergedinto: 824539
Status: Duplicate (was: Unconfirmed)
yep, this is the sixth issue.

Not sure if pixel dumps worked at some point or not; so much has bitrotten here since the last time I was working on the layout tests :(

Sign in to add a comment