Issue metadata
Sign in to add a comment
|
Regression:Chopped ubertray is seen while flipping the device from normal mode to vertical mode |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3493.0/10887.0.0 dev channel Minnie OS: Chrome OS What steps will reproduce the problem? (1)Sign into user >>Keep open Ubertray (2)Flip the device from normal laptop style to vertical mode and observe(Kindly refer video) Actual: Chopped ubertray is seen while flipping the device from normal mode to vertical mode Expected: No such chopped ubertray should be seen This is a Regression issue as same is working fine in 68.0.3440.59/10718.50.0 beta channel Minnie
,
Aug 7
,
Aug 7
I confirmed this on 69.0.3497.29 (M69 branch) kevin and 70.0.3508.3 caroline. However I see this only when #enable-system-tray-unified is set to "Disabled". So it might be a different issue. 1. switch to tablet landscape mode (i.e. flip the display) 2. open uber tray 3. switch to laptop mode The uber tray drifts to the right as the overview (window list) icon on the tray disappears.
,
Aug 30
,
Aug 30
At 70.0.3536.0, this doesn't happen because the tray is closed upon screen orientation change.
,
Aug 30
I found Issue 879046 , which hides this issue at this moment. This issue can still be visible once that is fixed.
,
Aug 30
I confirmed this happens without rotating the screen to vertical layout, but right after flipping to table mode from desktop mode. So this looks inverse path of Issue 812536 . Note that we need to inverse patch 7af6353e8fa8 to see this now, due to Issue 879046 .
,
Aug 31
We had similar issue before and had fix for that. https://bugs.chromium.org/p/chromium/issues/detail?id=812536 https://chromium-review.googlesource.com/c/chromium/src/+/1110946 x, y, translation x, translation y Enter tablet mode 864, 174, 44, 0 --> adjusted to (820, 174) Leave tablet mode 776, 290, 0, 0 Seems it's picking up position/translation of anchor at the beginning of animation and then moved after animation.
,
Sep 26
nit: the behavior had changed after https://chromium-review.googlesource.com/c/chromium/src/+/1237407 due to some event order change. So far I observed misalignment of the bubble in these cases: - when getting into / out of tablet mode - especially, when the shelf is positioned to right or left These have the same root cause and can be fixed by crrev.com/c/1246082.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7e5862b1d5407553fae466de086f3d4b62241e commit ad7e5862b1d5407553fae466de086f3d4b62241e Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 27 08:16:42 2018 Unified: Anchor system tray bubble to the shelf rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. Bug: 864939 , 812536 Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a Reviewed-on: https://chromium-review.googlesource.com/1246082 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594630} [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf.cc [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf.h [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/tray/tray_bubble_view.cc [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/tray/tray_bubble_view.h [modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/unified/unified_system_tray_bubble.cc
,
Sep 27
,
Sep 27
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e75c935f5b8442eebc9e1d0755907f2927b693d3 commit e75c935f5b8442eebc9e1d0755907f2927b693d3 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Oct 01 06:29:51 2018 Unified: Anchor system tray bubble to the shelf rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. This patch was manually edited from the original. - target tray_bubble_view.{cc,h} had been moved across directories - set_arrow() had been renamed to SetArrow() (cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e) Bug: 864939 , 812536 Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a Reviewed-on: https://chromium-review.googlesource.com/1246082 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594630} Reviewed-on: https://chromium-review.googlesource.com/1250307 Cr-Commit-Position: refs/branch-heads/3538@{#764} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf.cc [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf.h [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ui/views/bubble/tray_bubble_view.h
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e75c935f5b8442eebc9e1d0755907f2927b693d3 Commit: e75c935f5b8442eebc9e1d0755907f2927b693d3 Author: yamaguchi@chromium.org Commiter: yamaguchi@chromium.org Date: 2018-10-01 06:29:51 +0000 UTC Unified: Anchor system tray bubble to the shelf rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. This patch was manually edited from the original. - target tray_bubble_view.{cc,h} had been moved across directories - set_arrow() had been renamed to SetArrow() (cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e) Bug: 864939 , 812536 Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a Reviewed-on: https://chromium-review.googlesource.com/1246082 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594630} Reviewed-on: https://chromium-review.googlesource.com/1250307 Cr-Commit-Position: refs/branch-heads/3538@{#764} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 1
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c2ba253f97ae465d6047e70f2c00ab3811755a Commit: e2c2ba253f97ae465d6047e70f2c00ab3811755a Author: tetsui@chromium.org Commiter: tetsui@chromium.org Date: 2018-10-09 03:02:47 +0000 UTC Revert "Unified: Anchor system tray bubble to the shelf rect." This reverts commit e75c935f5b8442eebc9e1d0755907f2927b693d3. Reason for revert: P0 regression https://crbug.com/892248 Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > This patch was manually edited from the original. > - target tray_bubble_view.{cc,h} had been moved across directories > - set_arrow() had been renamed to SetArrow() > > (cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e) > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#594630} > Reviewed-on: https://chromium-review.googlesource.com/1250307 > Cr-Commit-Position: refs/branch-heads/3538@{#764} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=yoshiki@chromium.org,yamaguchi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864939 , 812536 , 892248 Change-Id: I73c6216c26b14eb6cd7c47fcbe08dc0190c92164 Reviewed-on: https://chromium-review.googlesource.com/c/1270205 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#913} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c2ba253f97ae465d6047e70f2c00ab3811755a commit e2c2ba253f97ae465d6047e70f2c00ab3811755a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 09 03:02:47 2018 Revert "Unified: Anchor system tray bubble to the shelf rect." This reverts commit e75c935f5b8442eebc9e1d0755907f2927b693d3. Reason for revert: P0 regression https://crbug.com/892248 Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > This patch was manually edited from the original. > - target tray_bubble_view.{cc,h} had been moved across directories > - set_arrow() had been renamed to SetArrow() > > (cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e) > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#594630} > Reviewed-on: https://chromium-review.googlesource.com/1250307 > Cr-Commit-Position: refs/branch-heads/3538@{#764} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=yoshiki@chromium.org,yamaguchi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864939 , 812536 , 892248 Change-Id: I73c6216c26b14eb6cd7c47fcbe08dc0190c92164 Reviewed-on: https://chromium-review.googlesource.com/c/1270205 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#913} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf.cc [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf.h [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ui/views/bubble/tray_bubble_view.h
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d08b807021b513d9a9e762bea5d3e5c6394450aa commit d08b807021b513d9a9e762bea5d3e5c6394450aa Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 09 03:34:01 2018 Revert "Unified: Anchor system tray bubble to the shelf rect." This reverts commit ad7e5862b1d5407553fae466de086f3d4b62241e. Reason for revert: P0 regression https://crbug.com/892248 Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594630} TBR=xiyuan@chromium.org,yoshiki@chromium.org,yamaguchi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864939 , 812536 , 892248 Change-Id: Ia6b034a6bb8f2d583924e217ee7215f32800d1ba Reviewed-on: https://chromium-review.googlesource.com/c/1270397 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#597790} [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf.cc [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf.h [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/tray/tray_bubble_view.cc [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/tray/tray_bubble_view.h [modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/unified/unified_system_tray_bubble.cc
,
Oct 9
,
Oct 16
I think this is lower priority than other P1 issues, and not a blocker of M71. - According to https://bugs.chromium.org/p/chromium/issues/detail?id=812536#c3 this issue has been there since M65. - This will not hinder user operations - There is a simple workaround (close and reopen the tray bubble) - Happens on some limited situations - However it's better to fix early as it doesn't look good.
,
Oct 19
,
Oct 22
Changing to M-71, because of the reasons in #20.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66c51516344cbeb9b21e1648c76783b73b517b1d commit 66c51516344cbeb9b21e1648c76783b73b517b1d Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Oct 25 01:50:17 2018 Unified: Anchor system tray bubble to user workspace rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e "Unified: Anchor system tray bubble to the shelf rect." with some fixes. Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594630} Bug: 864939 , 812536 , 887965 Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c Reviewed-on: https://chromium-review.googlesource.com/c/1282522 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602571} [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf.h [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/message_center/notification_tray.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/system_tray.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/tray_bubble_view.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/tray_bubble_view.h [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/unified/unified_slider_bubble_controller.cc [modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/unified/unified_system_tray_bubble.cc
,
Oct 26
We have new fix crrev.com/c/1282522 in master. We'd like to cherrypick it to M71. (Note that old patch 1246082 was once merged to M70, but has already been reverted. So it is no longer effective on any branch.)
,
Oct 26
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
This change impacts a number of areas. Can you add context regarding testing on ToT/M72 or otherwise prior to a merge? I'd like to understand the merge risk. Thanks.
,
Oct 29
The change (crrev.com/c/1282522) resolves the issue, which is not originally related to multiscreen. However the change is affected by the existing multi-display logic (like https://crbug.com/892248). So here are the manual test cases I did: 1. "screen change within single display" - Show the bubble. - Flip the device between tablet/laptop mode. - Verify the bubble is still shown in the right position. - Change shelf position to bottom/left/right and do the same for each. 2. "Multidisplay" - Connect an external display. - Set to extended desktop mode (not mirror). - Open display setting. Change display arrangement. - Click every the uber tray (aka. status area) in each shelf and verify a bubble appears correctly. - Change arrangement (position) of displays by "Drag to move a display" in chrome://settings/display and verify the same. - Verify the same in the tablet mode. (use USB mouse instead of touchpad) - Also test with a RTL language with shelf positioned to "bottom".
,
Oct 29
Thanks for the detail. This is still a fairly large change and not a regression for M71. Been out there since M68. I'd rather wait for M72... Compelling reason not to?
,
Oct 30
This issue is happening due to a race condition with other logic. So the actual issue changes between versions, rather than breaking out at a certain branch. With the latest build of M71 release branch, about the 1/3 of the window was chopped when I tried now. It looks worse than some older revisions of M71 release branch. There is a workaround on the user side; close bubble once and open it again. I'd like to ask +sgabriel +omrillo for confirmation and the decision.
,
Oct 30
Hard for me to make a call on merging vs. not, I'm unsure what that could mean for the build. I do like the fixed version :)
,
Oct 30
Approving M71 Chrome OS since this was merged to M70.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd commit 3bfa9f8a83f849400494ad47d6e99808cf5c7fcd Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Oct 31 01:17:02 2018 Unified: Anchor system tray bubble to user workspace rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e "Unified: Anchor system tray bubble to the shelf rect." with some fixes. Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594630} Bug: 864939 , 812536 , 887965 Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c Reviewed-on: https://chromium-review.googlesource.com/c/1282522 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602571}(cherry picked from commit 66c51516344cbeb9b21e1648c76783b73b517b1d) Reviewed-on: https://chromium-review.googlesource.com/c/1308236 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#429} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf.h [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/message_center/notification_tray.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/system_tray.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/tray_bubble_view.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/tray_bubble_view.h [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/unified/unified_slider_bubble_controller.cc [modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/unified/unified_system_tray_bubble.cc
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd Commit: 3bfa9f8a83f849400494ad47d6e99808cf5c7fcd Author: yamaguchi@chromium.org Commiter: yamaguchi@chromium.org Date: 2018-10-31 01:17:02 +0000 UTC Unified: Anchor system tray bubble to user workspace rect. The design spec states tray bubble should be anchored to: - right-bottom (when the shelf is positioned to the bottom or right) - or left-bottom (when the shelf is positioned to the left) corner of the workspace. The bubble went to wrong positions when changing the device mode between tablet and laptop, or rotating the screen, while the system tray bubble is opened. This change is a fix for it. This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e "Unified: Anchor system tray bubble to the shelf rect." with some fixes. Original change's description: > Unified: Anchor system tray bubble to the shelf rect. > > The design spec states tray bubble should be anchored to: > - right-bottom (when the shelf is positioned to the bottom or right) > - or left-bottom (when the shelf is positioned to the left) > corner of the workspace. > > The bubble went to wrong positions when changing the device mode > between tablet and laptop, or rotating the screen, while the system > tray bubble is opened. This change is a fix for it. > > > Bug: 864939 , 812536 > Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a > Reviewed-on: https://chromium-review.googlesource.com/1246082 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594630} Bug: 864939 , 812536 , 887965 Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c Reviewed-on: https://chromium-review.googlesource.com/c/1282522 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602571}(cherry picked from commit 66c51516344cbeb9b21e1648c76783b73b517b1d) Reviewed-on: https://chromium-review.googlesource.com/c/1308236 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#429} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
The fix I1392a2d96 has been merged to M71 and is available from 71.0.3578.33. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Jul 26Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)