New issue
Advanced search Search tips

Issue 864938 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Windows desktop widgets invoke WidgetDelegate::OnWidgetMove twice per origin change, not once

Project Member Reported by tapted@chromium.org, Jul 18

Issue description

Chrome Version       : m69 ToT

CL where I tried to add test coverage: https://chromium-review.googlesource.com/c/chromium/src/+/1141555

I needed a special case for Windows. See failures on patchset 2.

Not much uses WidgetDelegate::OnWidgetMove - it's probably redundant with WidgetObserver methods and we can maybe just delete it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/910a421680802dc4b7fdf6a470d9e4274d81f6dd

commit 910a421680802dc4b7fdf6a470d9e4274d81f6dd
Author: Trent Apted <tapted@chromium.org>
Date: Wed Jul 18 23:40:21 2018

MacViews: Ensure WidgetDelegate::OnWidgetMove() is invoked consistently.

Since AppKit coordinates are flipped, NSWindowDelegate may not send
move changes when the top-left corner of the window moves relative to
the screen. Similarly, it will send a move when resizing a window
vertically via the bottom edge, which other platforms do not class as a
move.

To fix, track the top-left window corner relative to the top-left of the
screen and ensure the toolkit is notified when it changes.

OnWidgetMove() had no test coverage, so add a cross-platform widget test.
The test exposes a discrepancy on Windows only, which is likely a bug to
investigate in a follow-up.

Bug:  862217 ,  864938 
Change-Id: I1fb0a6c2b463ea7cbd823fbe4d65545991564d50
Reviewed-on: https://chromium-review.googlesource.com/1141555
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576255}
[modify] https://crrev.com/910a421680802dc4b7fdf6a470d9e4274d81f6dd/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/910a421680802dc4b7fdf6a470d9e4274d81f6dd/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/910a421680802dc4b7fdf6a470d9e4274d81f6dd/ui/views/widget/widget_unittest.cc

Cc: viswa.karala@chromium.org
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
Status: WontFix (was: Unconfirmed)
**UI mass Triage**

Assuming the issue may be fixed, since there is no activity, hence closing it. If you feel this issue should still be addressed, please feel free to reopen it or file a new issue.

Thanks!

Sign in to add a comment