New issue
Advanced search Search tips

Issue 864935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary space is seen between the checkbox and 'Update Firmware...' text in Power wash overlay

Project Member Reported by kebalaji@chromium.org, Jul 18

Issue description

Chrome Version: 69.0.3493.0/10887.0.0 dev channel Minnie,Gnawty,Celes
OS: Chrome OS

What steps will reproduce the problem?
(1)In sign-out screen>> Hit Ctrl+Alt+Shift+Reload, click on Restart and in 
 Powerwash overlay observe unnecessary space between the checkbox and 'Update Firmware...' text

Actual: Unnecessary spacing is seen between the checkbox and 'Update Firmware...' text
Expected: Less spacing should be seen

This is a Regression issue as same is working fine in M67 stable

Note : Issue is not seen in Linux,Windows OS
       Issue is also seen on M68 Beta

Attached the screencast for reference..
 
ActualSpacing.jpg
2.7 MB View Download
ExpectedSpacing.jpg
2.6 MB View Download
Cc: -wzang@chromium.org
Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/243e11bed7cb248424c8b448ebe30eb1bc980043

commit 243e11bed7cb248424c8b448ebe30eb1bc980043
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Jul 20 02:26:02 2018

cros: Fix style for TPM firmware button

cr_checkbox started to use FlexBox in
https://chromium-review.googlesource.com/c/chromium/src/+/1033346
So the custom margin is no longer needed.

Bug:  864935 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idf0d2eb549a026cee160dc16e37cc2b770a5fc89
Reviewed-on: https://chromium-review.googlesource.com/1144476
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576757}
[modify] https://crrev.com/243e11bed7cb248424c8b448ebe30eb1bc980043/chrome/browser/resources/chromeos/login/oobe_reset.css

Status: Fixed (was: Assigned)

Sign in to add a comment