New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864925 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in ui::I18nSourceStream::FilterData

Project Member Reported by ClusterFuzz, Jul 18

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4995352592384000

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0xd397f5a8
Crash State:
  ui::I18nSourceStream::FilterData
  net::FilterSourceStream::DoFilterData
  net::FilterSourceStream::DoLoop
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=575072:575074

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4995352592384000

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 18

Components: Internals>Network>Filters UI>Browser>WebUI
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 18

Labels: M-69 Target-69
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 18

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 18

Labels: Pri-1
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Mac OS-Windows
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
dschuyler@ Could you take a look or help find an owner? It looks like you were the last person to change the logic in https://cs.chromium.org/chromium/src/ui/base/webui/i18n_source_stream.cc?l=63 (in https://codereview.chromium.org/2601313002).

The caller in this stacktrace is https://cs.chromium.org/chromium/src/net/filter/filter_source_stream.cc?q=net/filter/filter_source_stream.cc:157&sq=package:chromium&g=0&l=157.

The clusterfuzz regression range is not helpful unfortunately.

(Applying labels: I think this affects all platforms.)
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 25

Labels: -Security_Impact-Head Security_Impact-Beta
Mergedinto: 863318
Status: Duplicate (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Aug 2

ClusterFuzz has detected this issue as fixed in range 579993:579994.

Detailed report: https://clusterfuzz.com/testcase?key=4995352592384000

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0xd397f5a8
Crash State:
  ui::I18nSourceStream::FilterData
  net::FilterSourceStream::DoFilterData
  net::FilterSourceStream::DoLoop
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=575072:575074
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=579993:579994

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4995352592384000

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 7

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment