New issue
Advanced search Search tips

Issue 864923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature
Q2



Sign in to add a comment

Enable haptic feedback in drag-and-release in menus

Project Member Reported by pschaffner@chromium.org, Jul 18

Issue description

When opening a menu via a long-press, you can drag and release to select an item from the open menu. Upon switching items, there should be a haptic "tick", in conjunction to the visible highlight state, that denotes a change in selection.

To get an idea of how it should feel, long-press a link in content, press and hold on any action in the resulting action sheet, and then drag to another action.
 
Cc: -gambard@chromium.org
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
gambard@ PTAL
Labels: MS-Adaptive-Toolbar Q2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996ba055ec866a0428b85aaf94ef578db98d5f6b

commit 996ba055ec866a0428b85aaf94ef578db98d5f6b
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jul 19 07:28:39 2018

Add HapticFeedback on popup menus

This CL adds HapticFeedback when the popup menus are displayed when
long pressing the toolbar buttons.

Bug:  864923 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7fad41d33b500874e578d1f913d792a20baf5a15
Reviewed-on: https://chromium-review.googlesource.com/1141949
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576408}
[modify] https://crrev.com/996ba055ec866a0428b85aaf94ef578db98d5f6b/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/996ba055ec866a0428b85aaf94ef578db98d5f6b/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/996ba055ec866a0428b85aaf94ef578db98d5f6b/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment