Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yhirano@chromium.org PolicyDisplayRotationDefault/DisplayRotationBootTest.Reboot/N crash Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc commit bcd4dffd735a04da55c91ebe7f1959ddb8be36fc Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Jul 18 07:16:35 2018 Revert "chromeos: makes ScreenProviderObserver an associated interface" This reverts commit b4e6da646f25cca291318e50e7aa9dd05173dd65. Reason for revert: Broke PolicyDisplayRotationDefault/DisplayRotationBootTest.Reboot/* Original change's description: > chromeos: makes ScreenProviderObserver an associated interface > > And changes ws2 to ensure client is notified when scale-factor changes. > The conversion from ScreenProviderObserver to associated interface is to > ensure the ScreenProviderObserver is notified *before* the bounds change > because of scale-factor. To do otherwise means the client might use the wrong > scale-factor. > > BUG=862409 > TEST=none > > Change-Id: I78333dcabe3e4adb1e2091cba784d53d9c27be1a > Reviewed-on: https://chromium-review.googlesource.com/1138866 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575799} TBR=sadrul@chromium.org,sky@chromium.org,tsepez@chromium.org Change-Id: Iccd11134913aa340630f422d471f9047661d36a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862409, 864902 Reviewed-on: https://chromium-review.googlesource.com/1141584 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#575964} [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ash/app_launch_unittest.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/content/renderer/mus/renderer_window_tree_client.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/public/interfaces/screen_provider.mojom [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws/test_utils.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws/test_utils.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws/window_tree_client_unittest.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/BUILD.gn [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/client_root.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/client_root.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/screen_provider.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/screen_provider.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/screen_provider_unittest.cc [delete] https://crrev.com/57186f5dff9d6a5215f6604ba4c897f919039ff2/services/ui/ws2/test_screen_provider_observer.cc [delete] https://crrev.com/57186f5dff9d6a5215f6604ba4c897f919039ff2/services/ui/ws2/test_screen_provider_observer.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/test_window_tree_client.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/test_window_tree_client.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_service.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_service.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_service_test_setup.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_tree_binding.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_tree_binding.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/services/ui/ws2/window_tree_unittest.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/aura/mus/window_tree_client_delegate.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/views/mus/mus_client.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/views/mus/mus_client.h [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/views/mus/screen_mus.cc [modify] https://crrev.com/bcd4dffd735a04da55c91ebe7f1959ddb8be36fc/ui/views/mus/screen_mus.h
Comment 1 by yhirano@chromium.org
, Jul 18