New issue
Advanced search Search tips

Issue 864898 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

chrome://tracing's reverse the meaning of the field "propertiesMode".

Reported by manjian2...@gmail.com, Jul 18

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce the problem:
1. open chrome://tracing
2. click record
3. select v8.ic_stats
4. in the result page, select the group key "propertiesMode"

What is the expected behavior?
The slow should be fast, and the fast should be slow.

What went wrong?
      if (this.map_) {
        this.propertiesMode_ = obj.dict === 0 ? 'slow' : 'fast';
      } else {
        this.propertiesMode_ = 'unknown';
      }
the code showed above determines why a propertiesMode is selected as slow or fast. But a map which is a dictionary map means it is slow. The code showed above do the reverse.

Did this work before? N/A 

Chrome version: 67.0.3396.99  Channel: stable
OS Version: Ubuntu 18.04
Flash Version:
 
Labels: Needs-Triage-M67
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
Thanks for filling the issue...

Unable to reproduce the issue on reported chrome version 67.0.3396.99 using Ububtu 10.17. Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chrome 
2. Opened chrome://tracing and clicked record
3. Selected v8.ic_stats and clicked on record 
4. Clicked stop and
As we are unable able to find the step 4 " in the result page, select the group key "propertiesMode" "

@Reporter: Could you please review the attached screen-cast and also provide specific/proper step. 

Thanks..!
864898.webm
13.2 MB View Download
Components: -Platform>DevTools Blink>JavaScript>Compiler
You need to run some js, for example, open mail.google.com
Also you need to use the search bar to search for this tag.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 27

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Blink>JavaScript>Compiler Blink>JavaScript>Runtime
Owner: cbruni@chromium.org
Status: Assigned (was: Unconfirmed)
I guess this is a bug in the about:tracing page? Can you reroute please?
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/fe60316384dc20c0c35dbe7a26d2a859a4e32adc

commit fe60316384dc20c0c35dbe7a26d2a859a4e32adc
Author: Camillo Bruni <cbruni@chromium.org>
Date: Mon Aug 06 08:17:10 2018

Fix propertyMode in ic_stats_entry

Dictionary mode properties are commonly known as "slow" while we refer to
in-object and norm out-of-object properties as "fast".

The information is gathered in ICInfo::AppendToTracedValue (v8/src/ic/ic-stats.cc)
which correctly sets the "is_dictionary_map" bit.

Bug:  chromium:864898 
Change-Id: I813c96e55a067e6799925e7bb895d241635a7487
Reviewed-on: https://chromium-review.googlesource.com/1156308
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>

[modify] https://crrev.com/fe60316384dc20c0c35dbe7a26d2a859a4e32adc/tracing/tracing/extras/v8/ic_stats_entry.html
[modify] https://crrev.com/fe60316384dc20c0c35dbe7a26d2a859a4e32adc/tracing/tracing/extras/v8/ic_stats_entry_test.html

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aed19d52b8087e4458a008a6eaee031762e98440

commit aed19d52b8087e4458a008a6eaee031762e98440
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 06 10:22:39 2018

Roll src/third_party/catapult d2f6e76cbc6b..fe60316384dc (1 commits)

https://chromium.googlesource.com/catapult.git/+log/d2f6e76cbc6b..fe60316384dc


git log d2f6e76cbc6b..fe60316384dc --date=short --no-merges --format='%ad %ae %s'
2018-08-06 cbruni@chromium.org Fix propertyMode in ic_stats_entry


Created with:
  gclient setdep -r src/third_party/catapult@fe60316384dc

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:864898 
TBR=sullivan@chromium.org

Change-Id: Ibdfbb20f4952f1dd7e2ebbc599993edc4e4c0181
Reviewed-on: https://chromium-review.googlesource.com/1163108
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580839}
[modify] https://crrev.com/aed19d52b8087e4458a008a6eaee031762e98440/DEPS

Sign in to add a comment