New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864897 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Move Crostini section to after Google Play Store

Project Member Reported by tbuck...@chromium.org, Jul 18

Issue description

In Settings, the Crostini section should be after Google Play Store.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e791706596ef4ae2b5d2598b5134633d03f31d52

commit e791706596ef4ae2b5d2598b5134633d03f31d52
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Aug 03 04:21:05 2018

Put Crostini section after Play Store in Settings

Bug:  864897 
Change-Id: Iede53b65ec37b5778f9ec52f5a03293b2a0ee604
Reviewed-on: https://chromium-review.googlesource.com/1154738
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580450}
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/e791706596ef4ae2b5d2598b5134633d03f31d52/chrome/browser/resources/settings/settings_ui/settings_ui.js

Labels: Merge-Request-69
Labels: -Merge-Request-69 Merge-Approved-69
Merge approved M69.
Pls merge this change to M69 branch ASAP as this is a string change.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ddb48516a68aa291e317106040e9c75bb320ac

commit 87ddb48516a68aa291e317106040e9c75bb320ac
Author: Renee Wright <rjwright@chromium.org>
Date: Tue Aug 07 05:40:51 2018

Put Crostini section after Play Store in Settings

Bug:  864897 
Change-Id: Iede53b65ec37b5778f9ec52f5a03293b2a0ee604
Reviewed-on: https://chromium-review.googlesource.com/1154738
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580450}(cherry picked from commit e791706596ef4ae2b5d2598b5134633d03f31d52)
Reviewed-on: https://chromium-review.googlesource.com/1164762
Reviewed-by: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#455}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/87ddb48516a68aa291e317106040e9c75bb320ac/chrome/browser/resources/settings/settings_ui/settings_ui.js

Status: Fixed (was: Started)

Sign in to add a comment