chrome/android/profiles/chrome-profile-3309-text.prof is appared after building all in android chrome build config |
|||
Issue descriptionWhen I use following args.gn, file chrome/android/profiles/chrome-profile-3309-text.prof was appeared. ``` dcheck_always_on = true ffmpeg_branding = "Chrome" is_component_build = false is_debug = false proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true symbol_level = 0 target_cpu = "arm64" target_os = "android" use_goma = true ```
,
Jul 18
> Are you sure it appears after building? I thought the syncing of that was done in //DEPS (or similar), so this would happen after a sync, but I could be missing something.
You are right. The file appeared just after I run `gclient sync`
My .gclient is like below.
```
solutions = [
{
"url": "https://chromium.googlesource.com/chromium/src.git",
"managed": False,
"name": "src",
"deps_file": ".DEPS.git",
"custom_deps": {},
},
]
target_os = [ 'android' ]
```
> Out of curiosity, is this profile causing an issue? We sync other profiles to that directory, and they're very much needed, so if it is, we should probably work on fixing that, too. :)
It just requires me to run `git clean -df`.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17702faeec31df99529f435314036583f6e56e91 commit 17702faeec31df99529f435314036583f6e56e91 Author: George Burgess IV <gbiv@chromium.org> Date: Thu Jul 19 06:03:36 2018 Remove the old AFDO profiles for Android. We have an old profile hanging out in Android checkouts from before the days of autorolling them directly into Chromium. It's not breaking anything, but since it shows up in git status and is otherwise unused... Bug: 864893 Test: rm chrome-profile-3309-text.prof && gclient sync. Profile's gone. Change-Id: Iff487de8a9710ca9c87099df6bdebb1076db8429 Reviewed-on: https://chromium-review.googlesource.com/1142505 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#576386} [modify] https://crrev.com/17702faeec31df99529f435314036583f6e56e91/DEPS
,
Jul 19
You may need to remove the old profile once more, but ^ should keep it from coming back. We already have the new profile bits in Chromium's .gitignore, so that shouldn't show up as an untracked file. If I missed something, please let me know, and thanks for flagging this!
,
Jul 19
Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by g...@chromium.org
, Jul 18Status: Assigned (was: Untriaged)