New issue
Advanced search Search tips

Issue 864890 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Team Drives can be focused via keyboard even when it's not visible

Project Member Reported by lucmult@chromium.org, Jul 18

Issue description

I experienced this with Team Drives flag disabled.

When navigating on the directory tree with keyboard eventually it focus Team Drives and it even shows on breadcrumbs if I hit enter on the hidden Team Drives.

See screenshot attached.
 
Screenshot 2018-07-18 at 3.01.55 PM.png
426 KB View Download
Owner: ----
Status: Available (was: Assigned)
Owner: lucmult@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef43152bdde5b35b824368f8fb787cd746271605

commit ef43152bdde5b35b824368f8fb787cd746271605
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Aug 07 03:14:13 2018

Remove Team Drive root from directory tree instead of hiding

Remove Team Drive root from the directory tree when user has no team
drive. Fixes a bug where users could navigate to Team Drive root via
the keyboard even though the root was hidden.

Bug:  864890 
Change-Id: I2f6b59ca908ae609302cb873b6b182842cedc1c4
Reviewed-on: https://chromium-review.googlesource.com/1163352
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581114}
[modify] https://crrev.com/ef43152bdde5b35b824368f8fb787cd746271605/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/ef43152bdde5b35b824368f8fb787cd746271605/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/ef43152bdde5b35b824368f8fb787cd746271605/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js

Labels: -M-69 M-70
Status: Fixed (was: Started)
Tks, then I can just close this bug. :-)

Sign in to add a comment