New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864871 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature

Blocking:
issue 907849
issue 868068



Sign in to add a comment

Implement standalone RTCIceTransport API

Project Member Reported by steveanton@chromium.org, Jul 18

Issue description

Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/iRJ3as8AYy4/97rywT_2CAAJ

The RTCIceTransport is a Web API part of WebRTC that will be a building block in the next version of WebRTC. It allows developers more control over the operation of ICE and an object-oriented model (as opposed to the RTCPeerConnection model).

The specification is joint between the WebRTC 1.0 spec https://w3c.github.io/webrtc-pc/#rtcicetransport and the WebRTC-ICE extension spec https://w3c.github.io/webrtc-ice/ .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18aaa2fa9e45ad860c89a322f6999f1d2971ed11

commit 18aaa2fa9e45ad860c89a322f6999f1d2971ed11
Author: Steve Anton <steveanton@chromium.org>
Date: Thu Aug 09 04:55:36 2018

Add RTCIceTransport IDL + binding skeleton

Bug: 864871
Change-Id: I8e7b6f33685625b831ea326737d605ffc813288b
Reviewed-on: https://chromium-review.googlesource.com/1153477
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581789}
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_ice_candidate_pair.idl
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_ice_parameters.idl
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[add] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.idl
[modify] https://crrev.com/18aaa2fa9e45ad860c89a322f6999f1d2971ed11/third_party/blink/renderer/platform/runtime_enabled_features.json5

Blocking: 868068
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d78d9f90c87a37772bbc55a72fb085d2c86faa85

commit d78d9f90c87a37772bbc55a72fb085d2c86faa85
Author: Steve Anton <steveanton@chromium.org>
Date: Thu Aug 23 22:27:33 2018

RTCIceTransport: gather() implementation.

This change implements the RTCIceTransport.gather() method and
associated methods/events: getLocalCandidates(), gatheringState,
ongatheringstatechange, and onicecandidate.

The state property is also partially implemented so that the
RTCIceTransport can be stopped and garbage collected.

Bug: 864871
Change-Id: I7056764789d92dc93038a7a2279a15c850b4d299
Reviewed-on: https://chromium-review.googlesource.com/1153845
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585634}
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/content/renderer/media/webrtc/peer_connection_dependency_factory.h
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/README.md
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.cc
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[add] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/rtc_ice_gather_options.idl
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
[modify] https://crrev.com/d78d9f90c87a37772bbc55a72fb085d2c86faa85/third_party/blink/tools/audit_non_blink_usage.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35aa0ef49c836db358b8c935a58e1cf4f726441e

commit 35aa0ef49c836db358b8c935a58e1cf4f726441e
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Aug 24 18:34:08 2018

RTCIceTransport: start() implementation.

This change implements the RTCIceTransport.start() method and
associated methods/events: addRemoteCandidate(), getRemoteCandidates(),
role, onstatechange.

Bug: 864871
Change-Id: Ic6ac7ce4c9ba98b1dc2610ed7847e6b9714f6c8d
Reviewed-on: https://chromium-review.googlesource.com/1161605
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585915}
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/35aa0ef49c836db358b8c935a58e1cf4f726441e/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ec02b4e17351f4076da7b5630b0ac1c83da9b81

commit 8ec02b4e17351f4076da7b5630b0ac1c83da9b81
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Sep 07 18:59:47 2018

Add a new interface: IceTransportAdapter

The IceTransportAdapter splits P2PTransportChannel-specific logic
out of IceTransportHost and puts it behind an interface to
facilitate future testing. The API methods are changed to map to
the requirements of the RTCIceTransport rather than the
implementation details of the P2PTransportChannel.

Bug: 864871
Change-Id: I2a7036f675a11460e9721cc937beec17b7f03cc9
Reviewed-on: https://chromium-review.googlesource.com/1200127
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589616}
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter.h
[add] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[add] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/8ec02b4e17351f4076da7b5630b0ac1c83da9b81/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f306543529c028d85aa58db1fa8389a91428927

commit 5f306543529c028d85aa58db1fa8389a91428927
Author: Steve Anton <steveanton@chromium.org>
Date: Mon Sep 10 21:03:37 2018

Add C++ unit tests for RTCIceTransport

Adds unit tests for the RTCIceTransport Blink bindings that use a
mock IceTransportAdapter. These exercise the RTCIceTransport
bindings along with the IceTransportProxy and IceTransportHost.

Bug: 864871
Change-Id: I2b857979bf201f67f9db631b6f35a3e8bebef547
Reviewed-on: https://chromium-review.googlesource.com/1206173
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590060}
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/DEPS
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_cross_thread_factory.h
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[add] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_ice_transport_adapter.h
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/rtc_ice_candidate.h
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[add] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[modify] https://crrev.com/5f306543529c028d85aa58db1fa8389a91428927/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_ice_event.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d61b8e44d6e658e12d3c76cdaab665eac9253b

commit a9d61b8e44d6e658e12d3c76cdaab665eac9253b
Author: Steve Anton <steveanton@chromium.org>
Date: Tue Oct 02 02:26:55 2018

Implement RTCIceTransport.onselectedcandidatepairchange

Bug: 864871
Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286
Reviewed-on: https://chromium-review.googlesource.com/1208961
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595700}
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[modify] https://crrev.com/a9d61b8e44d6e658e12d3c76cdaab665eac9253b/third_party/blink/tools/audit_non_blink_usage.py

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e89d0d30725a3cc83da30fb733e06229c216c1b

commit 3e89d0d30725a3cc83da30fb733e06229c216c1b
Author: Steve Anton <steveanton@chromium.org>
Date: Tue Oct 02 06:09:25 2018

Revert "Implement RTCIceTransport.onselectedcandidatepairchange"

This reverts commit a9d61b8e44d6e658e12d3c76cdaab665eac9253b.

Reason for revert: flaky test

Original change's description:
> Implement RTCIceTransport.onselectedcandidatepairchange
> 
> Bug: 864871
> Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286
> Reviewed-on: https://chromium-review.googlesource.com/1208961
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Steve Anton <steveanton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595700}

TBR=dcheng@chromium.org,hta@chromium.org,haraken@chromium.org,hbos@chromium.org,steveanton@chromium.org

Change-Id: I946ade2587e49b3273d9dd303a3e383e8f5f16a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864871
Reviewed-on: https://chromium-review.googlesource.com/1256622
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595737}
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[modify] https://crrev.com/3e89d0d30725a3cc83da30fb733e06229c216c1b/third_party/blink/tools/audit_non_blink_usage.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa

commit ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa
Author: Steve Anton <steveanton@chromium.org>
Date: Wed Oct 03 14:27:55 2018

Reland: Implement RTCIceTransport.onselectedcandidatepairchange

TBR=hta@chromium.org,haraken@chromium.org

Bug: 864871
Change-Id: I6a2e0dc98efc58e22b33066ee3d37ded3c9b021a
Reviewed-on: https://chromium-review.googlesource.com/c/1258503
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596207}
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[modify] https://crrev.com/ba8f43f2308d6186e8b164fb4d0a1f9e8dce53aa/third_party/blink/tools/audit_non_blink_usage.py

Blocking: 907849
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0

commit 4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0
Author: Harald Alvestrand <hta@webrtc.org>
Date: Mon Jan 21 10:42:35 2019

Add 2 new virtual methods to IceTransportInternal

This will allow the blink-layer ICE-transport handling code
to use the virtual interface class rather than the concrete
implementation class.

Bug: chromium:864871
Change-Id: I5dfd1f266b3f3eabe42e09ba35afe218d25634b1
Reviewed-on: https://webrtc-review.googlesource.com/c/118360
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26333}
[modify] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/p2p/base/fake_ice_transport.h
[modify] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/p2p/base/ice_transport_internal.h
[modify] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/p2p/base/mock_ice_transport.h
[modify] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/p2p/base/p2p_transport_channel.cc
[modify] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/p2p/base/p2p_transport_channel.h
[add] https://crrev.com/4241cf5ed5d8ce0531b6e0b3933ba665e4b656f0/pc/ice_transport_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Today (20 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699

commit 94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 22 14:07:59 2019

Roll src/third_party/webrtc 74ba99062c48..71b5a7df7794 (53 commits)

https://webrtc.googlesource.com/src.git/+log/74ba99062c48..71b5a7df7794


git log 74ba99062c48..71b5a7df7794 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 srte@webrtc.org Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
2019-01-21 srte@webrtc.org Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
2019-01-21 hofbauer@webrtc.org Clarify and unify network delay plot annotations.
2019-01-21 hofbauer@webrtc.org Add Visual Studio Code project folder to gitignore file.
2019-01-21 artit@webrtc.org Remove dimensions subarray from internal iOS bots config
2019-01-21 sprang@webrtc.org Move congestion window field trial parsing to new class.
2019-01-21 danilchap@webrtc.org Connect global task queue factory and rtc::TaskQueue
2019-01-21 magjed@webrtc.org Android: Add option to print native stack traces in PeerConnectionFactory API
2019-01-21 orphis@webrtc.org Remove simulcast constraints in SimulcastEncoderAdapter
2019-01-21 devicentepena@webrtc.org AEC3: avoiding a warning in the reverberation decay estimator.
2019-01-21 magjed@webrtc.org Reland "Android: Add helper methods for printing native stack traces"
2019-01-21 eladalon@webrtc.org Deprecate FirstSubFrameInFrame() and LastSubFrameInFrame()
2019-01-21 srte@webrtc.org Removes clock from TransportFeedbackAdapter.
2019-01-21 nisse@webrtc.org Reland "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."
2019-01-21 nisse@webrtc.org Reland "Trim down FileWrapper class to be merely a wrapper owning a FILE*"
2019-01-21 magjed@webrtc.org Revert "Android: Add helper methods for printing native stack traces"
2019-01-21 artit@webrtc.org Change webrtc-internal iOS pool for try and ci bots
2019-01-21 qingsi@google.com Replace the usage of RTC_HISTOGRAM_COMMON_BLOCK with
2019-01-21 hta@webrtc.org Add 2 new virtual methods to IceTransportInternal
2019-01-21 nisse@webrtc.org Revert "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."
2019-01-21 nisse@webrtc.org Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2.
2019-01-21 nisse@webrtc.org Refactor VideoTrackTest to not depend on cricket::VideoCapturer
2019-01-20 magjed@webrtc.org Android: Remove static thread references from PeerconnectionFactory
2019-01-20 magjed@webrtc.org Android: Add helper methods for printing native stack traces
2019-01-18 crodbro@webrtc.org Fix for bandwidth toggling problem in StartUpPhase.
2019-01-18 terelius@webrtc.org Add some missing includes and dependencies.
2019-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f804d91f5..1cac36a781 (624000:624101)
2019-01-18 minyue@webrtc.org Adding text log on actual opus bitrate.
2019-01-18 nisse@webrtc.org Refactor PeerConnectionInterfaceTest to not depend on cricket::VideoCapturer
2019-01-18 ilnik@webrtc.org Update jitter delay on per-superframe level from FrameBuffer
2019-01-18 nisse@webrtc.org Add test WebRtcVideoChannelTest.DoesNotAdaptWhenScreeensharing
2019-01-18 nisse@webrtc.org Refactor PeerConnectionFactoryTest to not use FakeVideoCapturer.
2019-01-18 sprang@webrtc.org Don't include packetization overhead in protection bitrate.
2019-01-18 nisse@webrtc.org Revert "Trim down FileWrapper class to be merely a wrapper owning a FILE*"
2019-01-18 danilchap@webrtc.org Update PlatformThread constructor to take name with absl::string_view
2019-01-18 ilnik@webrtc.org Set inter_pic_predicted video codec flag in vp9 encoder correctly
2019-01-18 danilchap@webrtc.org Introduce global task queue factory.
2019-01-18 artit@webrtc.org Increase even more timeout for internal iOS perf
2019-01-18 srte@webrtc.org Adds repeating task class.
2019-01-18 srte@webrtc.org Adds WebRtcKeyValueConfig interface
2019-01-18 nisse@webrtc.org Trim down FileWrapper class to be merely a wrapper owning a FILE*
2019-01-18 zstein@webrtc.org Remove unused friend declaration from ParsedRtcEventLog.
2019-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 16c3dfe1d0..2f804d91f5 (623888:624000)
2019-01-18 amithi@webrtc.org Fixing possible bug when Flex and RTX used together.
2019-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e291b99915..16c3dfe1d0 (623778:623888)
2019-01-17 amithi@webrtc.org Revert "Opus multistream."
2019-01-17 titovartem@webrtc.org Introduce VideoFrameWriter.
2019-01-17 mbonadei@webrtc.org Revert "AEC3: Lockless transfer of render data to the capture thread"
2019-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a9216d2da..e291b99915 (623639:623778)
2019-01-17 Peter) Slatala DTLS transport needs to forward network route change.
2019-01-17 titovartem@webrtc.org Introduce ExampleVideoQualityAnalyzer.
2019-01-17 sprang@webrtc.org Add ability for VideoEncoder to signal frame rate allocation.
2019-01-17 sprang@webrtc.org Move some video codec constants to separate file.


Created with:
  gclient setdep -r src/third_party/webrtc@71b5a7df7794

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:none,chromium:921582,chromium:921023,chromium:864871,chromium:None,chromium:None,chromium:912122,chromium:None,chromium:922396,chromium:NONE,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6321648925f5a9781be3b886626342a08b25a9e9
Reviewed-on: https://chromium-review.googlesource.com/c/1425970
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624768}
[modify] https://crrev.com/94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699/DEPS

Sign in to add a comment