Upgrade dev-go/dbus to support BusObject.CallWithContext |
||
Issue descriptionThe version of github.com/godbus/dbus that we use, bd29ed602e2cf4207ebcabcd530259169e4289ba (from July 2017), lacks BusObject.CallWithContext(), leaving us without an easy way to ensure that calls time out when a context's deadline expires. CallWithContext was added in April 2018 by 2033fb2fe4dc4cc75083e8c26ce59aac0646030f. The latest tag that I see in the repo is v4.1.0, on a commit from September 2017. I'd like to upgrade our dev-go/dbus package to include the new method. Our latest ebuild is versioned "0.0.2-r6"; I'm not sure what this name corresponds to. chromeos-base/tast-local-tests-cros is the only package in the public overlay that depends on dev-go/dbus, but there are some Jetstream dependencies on it: chromeos-base/ap-daemons chromeos-base/ap-wireless sys-apps/spiny And also this: www-servers/spacecast I know how to verify that tast-local-tests-cros isn't broken if I update dev-go/dbus, but I have no idea about the other packages that depend on it. Rahul, is Go module support on your radar?
,
Aug 3
I've uploaded https://crrev.com/c/1161544 to upgrade to v4.1.0. I didn't need to make any changes to Tast for the upgrade.
,
Aug 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f800751c5d961f02b10bb500c33cb87cc914348b commit f800751c5d961f02b10bb500c33cb87cc914348b Author: Daniel Erat <derat@chromium.org> Date: Sat Aug 04 05:14:36 2018 dev-go/dbus: Upgrade to v4.1.0. Upgrade the dev-go/dbus package to build v4.1.0 (Nov 2017) rather than commit bd29ed60 (July 2017). I'm doing this as an intermediate step to get closer to 2033fb2f (April 2018), which adds BusObject.CallWithContext, needed to make D-Bus method calls time out in response to context expirations. BUG= chromium:864846 TEST=emerged tast packages; also verified that tast tests that use this package such as ui.ChromeLogin and example.DBus still pass Change-Id: I20658fbdead8db5c3901148f67502657205aac11 Reviewed-on: https://chromium-review.googlesource.com/1161544 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [rename] https://crrev.com/f800751c5d961f02b10bb500c33cb87cc914348b/dev-go/dbus/dbus-4.1.0.ebuild [delete] https://crrev.com/034e69a6b6e9798cc0afd4dff0d4dbba2769d580/dev-go/dbus/dbus-0.0.2-r6.ebuild [modify] https://crrev.com/f800751c5d961f02b10bb500c33cb87cc914348b/dev-go/dbus/Manifest
,
Aug 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fa50c13b39428f64004fa2d15ed4a45af3cbbef9 commit fa50c13b39428f64004fa2d15ed4a45af3cbbef9 Author: Daniel Erat <derat@chromium.org> Date: Sat Aug 04 05:14:37 2018 dev-go/dbus: Upgrade to 46d8b1f6. Upgrade the dev-go/dbus package to commit 46d8b1f6 (July 2018) to get BusObject.CallWithContext (added by 2033fb2f) plus a few bug fixes. I'm naming this 4.1.0_p20180722-r1 since v4.1.0 is the latest release tag. BUG= chromium:864846 TEST=ran relevant tast tests Change-Id: Id91a60f3f52b36a341674cc969797611dddcb705 Reviewed-on: https://chromium-review.googlesource.com/1161566 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/fa50c13b39428f64004fa2d15ed4a45af3cbbef9/dev-go/dbus/Manifest [rename] https://crrev.com/fa50c13b39428f64004fa2d15ed4a45af3cbbef9/dev-go/dbus/dbus-4.1.0_p20180722.ebuild [add] https://crrev.com/fa50c13b39428f64004fa2d15ed4a45af3cbbef9/dev-go/dbus/dbus-4.1.0_p20180722-r1.ebuild
,
Aug 6
|
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Aug 3Status: Started (was: Available)