Remove .sort() calls in browser tests |
|||
Issue descriptionWe often call .sort() on the expected file list before calling remoteCall.waitForFiles(). However, remoteCall.waitForFiles() sorts the files by default (unless told not to). This means we can remove many redundant calls to .sort() in our browser tests.
,
Nov 18
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b96acff5e0bd6df9204c918d2464cbb97aefd323 commit b96acff5e0bd6df9204c918d2464cbb97aefd323 Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Nov 19 03:04:23 2018 Remove redundant sort() calls. Also replace some waitForFileListChange + explicit files list assert with waitForFiles. This simplifies some tests. BUG= 864844 Change-Id: If859f073e25b122dcd3e9eaf536871e5c31b60f2 Reviewed-on: https://chromium-review.googlesource.com/c/1341431 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609167} [modify] https://crrev.com/b96acff5e0bd6df9204c918d2464cbb97aefd323/ui/file_manager/integration_tests/file_manager/drive_specific.js [modify] https://crrev.com/b96acff5e0bd6df9204c918d2464cbb97aefd323/ui/file_manager/integration_tests/file_manager/file_display.js [modify] https://crrev.com/b96acff5e0bd6df9204c918d2464cbb97aefd323/ui/file_manager/integration_tests/file_manager/transfer.js
,
Nov 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by slangley@chromium.org
, Nov 16