New issue
Advanced search Search tips

Issue 864809 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility



Sign in to add a comment

Support for non alpha-numeric keys in SwitchAccess

Project Member Reported by zhelfins@chromium.org, Jul 17

Issue description

SwitchAccess on ChromeOS is currently limited to using alphanumeric characters as switches. Many switches have a default behavior of sending key events for Space and Enter, so we should support any key code becoming a switch (or possibly even multiple key codes, it's also common to see a switch send "~1" or "~2").
 
Status: Available (was: Untriaged)
Labels: -Pri-3 M-72 Pri-2
Owner: zhelfins@chromium.org
Status: Started (was: Available)
Cc: -zhelfins@chromium.org
Labels: -M-72
Owner: anastasi@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867049303c130132ce764fc351c4e5b2dc3411fc

commit 867049303c130132ce764fc351c4e5b2dc3411fc
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Tue Jan 08 22:29:30 2019

Forward keycode to Switch Access when requested


This change is moving towards an improved onboarding process for Switch Access.

Because key codes in JavaScript and C++ only align for alpha-numeric values,
Switch Access is currently limited to using alphanumeric keys as switches.
It's very common for switch interfaces to use space and enter for switches, so
we would like to remove this restriction (and will do so in a subsequent
change).

Bug: 864809
Change-Id: Id6f3afbd85de440d615bc43b9f2fb4e4cf34ceab
Reviewed-on: https://chromium-review.googlesource.com/c/1391411
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620907}
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/events/switch_access_event_handler.cc
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/events/switch_access_event_handler.h
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/events/switch_access_event_handler_unittest.cc
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/accessibility/accessibility_extension_api.h
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/resources/chromeos/switch_access/keyboard_handler.js
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/resources/chromeos/switch_access/switch_access.js
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/resources/chromeos/switch_access/switch_access_interface.js
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/chrome/common/extensions/api/accessibility_private.json
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/third_party/closure_compiler/externs/accessibility_private.js
[modify] https://crrev.com/867049303c130132ce764fc351c4e5b2dc3411fc/tools/metrics/histograms/enums.xml

Sign in to add a comment