New issue
Advanced search Search tips

Issue 864802 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Switch Access steals key events from Virtual Keyboard

Project Member Reported by zhelfins@chromium.org, Jul 17

Issue description

When Switch Access is enabled, it consumes key events from the virtual keyboard as well as the physical keyboard, making it impossible to type those characters without deactivating Switch Access.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a16d8d94b05c843257cedab588fd85f089803b8

commit 3a16d8d94b05c843257cedab588fd85f089803b8
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Thu Aug 02 21:14:35 2018

Ignore virtual KeyEvents in SwitchAccess

Switch access should only use KeyEvents from physical keyboards as
switches; virtual keyboard events should be ignored.

Added a browser test for SwitchAccess

BUG= 864802 

Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc
Reviewed-on: https://chromium-review.googlesource.com/1114069
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580321}
[modify] https://crrev.com/3a16d8d94b05c843257cedab588fd85f089803b8/chrome/browser/chromeos/accessibility/accessibility_manager.h
[add] https://crrev.com/3a16d8d94b05c843257cedab588fd85f089803b8/chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
[modify] https://crrev.com/3a16d8d94b05c843257cedab588fd85f089803b8/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
[modify] https://crrev.com/3a16d8d94b05c843257cedab588fd85f089803b8/chrome/test/BUILD.gn

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91c5f56a9c29bd14981aae1bd8614d18c78f7194

commit 91c5f56a9c29bd14981aae1bd8614d18c78f7194
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Tue Sep 11 17:26:15 2018

Revert "Ignore virtual KeyEvents in SwitchAccess"

This reverts commit 3a16d8d94b05c843257cedab588fd85f089803b8.

Reason for revert: The method used to identify virtual key events with the old virtual keyboard UI no longer holds true with the new virtual keyboard UI.

I'm investigating why that's true, but to unblock progress on SwitchAccess typing, I am reverting this change.


Original change's description:
> Ignore virtual KeyEvents in SwitchAccess
> 
> Switch access should only use KeyEvents from physical keyboards as
> switches; virtual keyboard events should be ignored.
> 
> Added a browser test for SwitchAccess
> 
> BUG= 864802 
> 
> Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc
> Reviewed-on: https://chromium-review.googlesource.com/1114069
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580321}

TBR=dtseng@chromium.org,katie@chromium.org,zhelfins@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  864802 
Change-Id: I698bbb745e2e1371ecf4e7c800cf8d832919f927
Reviewed-on: https://chromium-review.googlesource.com/1217717
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590370}
[modify] https://crrev.com/91c5f56a9c29bd14981aae1bd8614d18c78f7194/chrome/browser/chromeos/accessibility/accessibility_manager.h
[delete] https://crrev.com/d3406a529402145060b321fb3e2ba68cede12ee8/chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
[modify] https://crrev.com/91c5f56a9c29bd14981aae1bd8614d18c78f7194/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
[modify] https://crrev.com/91c5f56a9c29bd14981aae1bd8614d18c78f7194/chrome/test/BUILD.gn

Owner: anastasi@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da04090cb6de2f918a8c7433c19bfbe45b4bcb4

commit 3da04090cb6de2f918a8c7433c19bfbe45b4bcb4
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Wed Nov 28 22:19:27 2018

Reland "Ignore virtual KeyEvents in SwitchAccess"

This is a reland of 3a16d8d94b05c843257cedab588fd85f089803b8

Original change's description:
> Ignore virtual KeyEvents in SwitchAccess
>
> Switch access should only use KeyEvents from physical keyboards as
> switches; virtual keyboard events should be ignored.
>
> Added a browser test for SwitchAccess
>
> BUG= 864802 
>
> Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc
> Reviewed-on: https://chromium-review.googlesource.com/1114069
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580321}

Bug:  864802 
Change-Id: I653c8965a0361d46fc701d6b9b648006d035b82e
Reviewed-on: https://chromium-review.googlesource.com/c/1347689
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611894}
[modify] https://crrev.com/3da04090cb6de2f918a8c7433c19bfbe45b4bcb4/chrome/browser/chromeos/accessibility/accessibility_manager.h
[add] https://crrev.com/3da04090cb6de2f918a8c7433c19bfbe45b4bcb4/chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
[modify] https://crrev.com/3da04090cb6de2f918a8c7433c19bfbe45b4bcb4/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
[modify] https://crrev.com/3da04090cb6de2f918a8c7433c19bfbe45b4bcb4/chrome/test/BUILD.gn

Sign in to add a comment