New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864798 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Superscript units for weather answers

Project Member Reported by emilyschechter@chromium.org, Jul 17

Issue description

Superscript units for weather answers
 
Cc: bklmn@chromium.org
Redline attached for reference. LMK if we need more pixel level detail...not sure how the superscript formatting will be implemented. 
Screen Shot 2018-07-17 at 4.46.56 PM.png
79.1 KB View Download
Owner: orinj@chromium.org
Status: Assigned (was: Untriaged)
orinj: Let's discuss how to tackle this Wednesday morning.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb15c32a277ad05663d11e5b385e94c481e3b078

commit bb15c32a277ad05663d11e5b385e94c481e3b078
Author: Orin Jaworski <orinj@chromium.org>
Date: Thu Jul 19 00:27:16 2018

[omnibox] Selectively apply superior baseline on new answers

Weather answers with °F will have TOP_ALIGNED text ranges, and
this CL detects them to raise the text, improving readability.

Bug:  864798 
Change-Id: I3a2dff9fc0e28283bdeaaa2413d261d076737a8f
Reviewed-on: https://chromium-review.googlesource.com/1142385
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576273}
[modify] https://crrev.com/bb15c32a277ad05663d11e5b385e94c481e3b078/chrome/browser/ui/views/omnibox/omnibox_text_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment