New issue
Advanced search Search tips

Issue 864797 link

Starred by 2 users
Status: Fixed
Owner:
rmcelrath@chromium.org
Closed: Jul 18
Cc:
xiaoche...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

FeedbackUploaderDispatchTest.500Response is flaky

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 17 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of xiaochengh@chromium.org

FeedbackUploaderDispatchTest.500Response is flaky, with flakes seen since July 10 or earlier.

[ RUN      ] FeedbackUploaderDispatchTest.500Response
[20698:20698:0710/131454.453723:4593928065:WARNING:feedback_uploader.cc(228)] FEEDBACK: Submission to feedback server (https://www.google.com/tools/feedback/chrome/__submit) status: Server error: HTTP response code 500
[20698:20698:0710/131454.457706:4593932047:WARNING:feedback_uploader.cc(228)] FEEDBACK: Submission to feedback server (https://www.google.com/tools/feedback/chrome/__submit) status: Server error: HTTP response code 500
../../components/feedback/feedback_uploader_dispatch_unittest.cc:177: Failure
Expected equality of these values:
  kTestRetryDelay * 2
    Which is: 0.002 s
  uploader.retry_delay()
    Which is: 0.004 s
Stack trace:
#0 0x000007d91c7f (/b/s/w/ir/out/Release/components_unittests+0x7d91c7e)
#1 0x000007db8ee0 (/b/s/w/ir/out/Release/components_unittests+0x7db8edf)
#2 0x000007db7aba (/b/s/w/ir/out/Release/components_unittests+0x7db7ab9)
[  FAILED  ] FeedbackUploaderDispatchTest.500Response (77 ms)

From flakiness dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=FeedbackUploaderDispatchTest.500Response

Comment 2 by xiaoche...@chromium.org, Jul 17

Owner: rmcelrath@chromium.org
Status: Assigned (was: Available)
rmcelrath@: Could you take a look?

Comment 3 by xiaoche...@chromium.org, Jul 18

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c054be784d9ad459acca06522482cd32092bce1

commit 5c054be784d9ad459acca06522482cd32092bce1
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Jul 18 00:24:11 2018

Disable flaky FeedbackUploaderDispatchTest.500Response on Linux and ChromeOS

Bug:  864797 
Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407
Tbr: afakhry@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1141136
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575869}
[modify] https://crrev.com/5c054be784d9ad459acca06522482cd32092bce1/components/feedback/feedback_uploader_dispatch_unittest.cc

Comment 5 by afakhry@chromium.org, Jul 18

Labels: -Pri-2 M-69 Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da795c1a5f49a488aba99a853b36c600c6155ea

commit 3da795c1a5f49a488aba99a853b36c600c6155ea
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Wed Jul 18 17:56:08 2018

Fix flaky FeedbackUploaderDispatchTest

One of the tests starts a request that will repeatedly retry itself on
failures, with backoff. The test asserts that the delay has a certain
value, which is effectively the same as asserting that the request is
on a certain retry attempt, but sometimes the request has time to retry
more than once before the test assertion occurs. This changes to assert
to not expect a specific value, just one that's larger than the
default.

Bug:  864797 
Change-Id: Ia8fced88b119f724bb2e2c93602ed6034b0b87d1
Reviewed-on: https://chromium-review.googlesource.com/1141299
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576131}
[modify] https://crrev.com/3da795c1a5f49a488aba99a853b36c600c6155ea/components/feedback/feedback_uploader_dispatch_unittest.cc

Comment 7 by rmcelrath@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment