New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Record when users activate the launcher searchbox

Project Member Reported by newcomer@chromium.org, Jul 17

Issue description

It will help us understand how many people are going to see the search zero state


Split by touch/mouse/keyboard.
 
Labels: -Restrict-View-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9

commit 55b98d3b8d0be26ebc0dc26ecdc297416ef916b9
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Aug 03 23:09:00 2018

cros: Add UMA to record search box activations

Make SearchBoxViewBase have the option to record searchbox activation.

Override RecordSearchBoxActivationHistogram at app_list SearchBoxView.

Bug:  864790 
Change-Id: I91001aaf188193f11d7448cb31ee75c76c1c8d6c
Reviewed-on: https://chromium-review.googlesource.com/1142575
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580691}
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/app_list/views/search_box_view_unittest.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ash/components/shortcut_viewer/views/ksv_search_box_view.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ui/chromeos/search_box/search_box_view_base.cc
[modify] https://crrev.com/55b98d3b8d0be26ebc0dc26ecdc297416ef916b9/ui/chromeos/search_box/search_box_view_base.h

Labels: Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 6

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Per chat with newcomer@, change has been verified on ToT. Merge approved for M69.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b81d162473f43e0cf077b1be4850d1c16612e5b4

commit b81d162473f43e0cf077b1be4850d1c16612e5b4
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 09 21:17:36 2018

MERGE:cros: Add UMA to record search box activations

Make SearchBoxViewBase have the option to record searchbox activation.

Override RecordSearchBoxActivationHistogram at app_list SearchBoxView.

Bug:  864790 
Change-Id: I91001aaf188193f11d7448cb31ee75c76c1c8d6c
Reviewed-on: https://chromium-review.googlesource.com/1142575
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580691}
Reviewed-on: https://chromium-review.googlesource.com/1169967
Cr-Commit-Position: refs/branch-heads/3497@{#518}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/app_list/views/search_box_view_unittest.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/components/shortcut_viewer/views/ksv_search_box_view.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ash/laser/laser_pointer_controller_unittest.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ui/chromeos/search_box/search_box_view_base.cc
[modify] https://crrev.com/b81d162473f43e0cf077b1be4850d1c16612e5b4/ui/chromeos/search_box/search_box_view_base.h

Cc: omrilio@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment