Media Intent Handler: Don't save to history |
||||||||
Issue descriptionThe files opened with the MediaLauncherActivity are currently saved to history. They shouldn't be
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9539242c99790cb230c8eebb0bc65dc4273e9871 commit 9539242c99790cb230c8eebb0bc65dc4273e9871 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Jul 26 00:34:05 2018 [Media Intent Handler] Don't save content:// URIs to history This CL adds "content" to the list of URI schemes that we don't want to save into history. This fixes an issue where media opened via the MediaLauncherActivity were being saved into history. Bug: 864777 Change-Id: I4c438aace5a4da62fa73a958db79756c63391b2f Reviewed-on: https://chromium-review.googlesource.com/1150608 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578145} [modify] https://crrev.com/9539242c99790cb230c8eebb0bc65dc4273e9871/chrome/browser/history/history_utils.cc
,
Jul 26
,
Jul 26
,
Jul 26
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37f8d38883f16ccf07c957ca41aca7dd8280874e commit 37f8d38883f16ccf07c957ca41aca7dd8280874e Author: Tommy Steimel <steimel@chromium.org> Date: Fri Jul 27 15:14:24 2018 [Media Intent Handler] Don't save content:// URIs to history This CL adds "content" to the list of URI schemes that we don't want to save into history. This fixes an issue where media opened via the MediaLauncherActivity were being saved into history. Bug: 864777 Change-Id: I4c438aace5a4da62fa73a958db79756c63391b2f Reviewed-on: https://chromium-review.googlesource.com/1150608 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578145}(cherry picked from commit 9539242c99790cb230c8eebb0bc65dc4273e9871) Reviewed-on: https://chromium-review.googlesource.com/1152649 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#150} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/37f8d38883f16ccf07c957ca41aca7dd8280874e/chrome/browser/history/history_utils.cc
,
Aug 1
Verified in 69.0.3497.24 build
,
Aug 22
In 69.0.3457.53 build - MediaLauncherActivity images are showing in history.
,
Aug 30
The newer issue was the file:// URIs were saving. Closing after discussions with the privacy team determined that saving the file:// URIs is okay. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mlamouri@chromium.org
, Jul 18