browser_resources.grd is running low on allocated ids, so it would be good to move our resources into a dedicated grd file. See history of src/tools/gritsettings/resource_ids for example cls: https://cs.chromium.org/chromium/src/tools/gritsettings/resource_ids?q=resource_ids&sq=package:chromium&dr&l=82-84
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a0ef003d5616a96d3f00fac642248e3e8a9b59 commit 07a0ef003d5616a96d3f00fac642248e3e8a9b59 Author: Kyle Milka <kmilka@chromium.org> Date: Fri Nov 09 22:18:09 2018 Move local ntp resources into dedicated grd file Allocate more ids for local ntp resources in preparation for adding more resources. Bug: 864763 Change-Id: I9b68fdda795959306d248eec973b86e0506323c7 Reviewed-on: https://chromium-review.googlesource.com/c/1327558 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606996} [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/BUILD.gn [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/browser_resources.grd [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/resources/BUILD.gn [add] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/resources/local_ntp_resources.grd [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/search/iframe_source_unittest.cc [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/browser/search/most_visited_iframe_source.cc [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/chrome/chrome_paks.gni [modify] https://crrev.com/07a0ef003d5616a96d3f00fac642248e3e8a9b59/tools/gritsettings/resource_ids
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5e23d9d9ee3a687f7e3fc7315123c882fa87f64 commit f5e23d9d9ee3a687f7e3fc7315123c882fa87f64 Author: Kyle Milka <kmilka@chromium.org> Date: Fri Nov 09 23:14:50 2018 Add per-file owner for local_ntp_resources.grd Bug: 864763 Change-Id: If3baac188ce07a4c2259b97b013353920b4ad3ba Reviewed-on: https://chromium-review.googlesource.com/c/1329668 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#607018} [modify] https://crrev.com/f5e23d9d9ee3a687f7e3fc7315123c882fa87f64/chrome/browser/resources/OWNERS
Comment 1 by ramyan@chromium.org
, Jul 18