New issue
Advanced search Search tips

Issue 864756 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-VR

Blocking:
issue 864810



Sign in to add a comment

[WebXR] Pass timestamp into XRSession.requestAnimationFrame callbacks

Project Member Reported by bajones@chromium.org, Jul 17

Issue description

When https://github.com/immersive-web/webxr/issues/347 is closed Chrome needs to implement the timestamp logic that was decided upon. Moste likely this will be identical to the timestamp logic for window.requestAnimationFrame().
 
Blocking: 864810
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a20abecf7b0957393948f74e1eee907b68547d6

commit 2a20abecf7b0957393948f74e1eee907b68547d6
Author: Brandon Jones <bajones@chromium.org>
Date: Thu Jul 19 21:12:10 2018

Updated the timestamp XRSession frames provide

The new timestamp is compatible with the one provided to
window.requestAnimationFrame callbacks.

Bug:  864756 
Change-Id: Ia68762a150b9d2c4a4760564f8d48aac7c689e94
Reviewed-on: https://chromium-review.googlesource.com/1142227
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576629}
[add] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/WebKit/LayoutTests/xr/xrSession_requestAnimationFrame_timestamp.html
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.cc
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/2a20abecf7b0957393948f74e1eee907b68547d6/third_party/blink/renderer/modules/xr/xr_session.h

Status: Fixed (was: Available)
Cc: klausw@chromium.org bajones@chromium.org
 Issue 832201  has been merged into this issue.
Components: Blink>WebXR

Sign in to add a comment