New issue
Advanced search Search tips

Issue 864733 link

Starred by 2 users
Status: Fixed
Owner:
mastiz@chromium.org
Closed: Jul 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Flaky DCHECK hit on win7_chromium_rel_ng browser_tests: CalledOnValidSequence()

Project Member Reported by xiaoche...@chromium.org, Jul 17 
Many irrelevant browser tests on win7_chromium_rel_ng are hitting this DCHECK flakily:

[5952:8900:0717/131011.328:FATAL:ref_counted.h(83)] Check failed: CalledOnValidSequence(). 
Backtrace:
	base::debug::StackTrace::StackTrace [0x03D562F0+32]
	base::debug::StackTrace::StackTrace [0x03D55AAD+13]
	logging::LogMessage::~LogMessage [0x03D6F723+83]
	base::subtle::RefCountedBase::Release [0x01329301+145]
	syncer::BlockingModelTypeStoreImpl::~BlockingModelTypeStoreImpl [0x070165AB+59]
	syncer::BlockingModelTypeStoreImpl::`scalar deleting destructor' [0x070171CB+11]
	std::unique_ptr<CPDF_Parser::TrailerData,std::default_delete<CPDF_Parser::TrailerData> >::~unique_ptr<CPDF_Parser::TrailerData,std::default_delete<CPDF_Parser::TrailerData> > [0x028C0586+22]
	base::internal::BindState<void (__cdecl*)(base::OnceCallback<void __cdecl(std::unique_ptr<policy::URLBlacklist,std::default_delete<policy::URLBlacklist> >)>,std::unique_ptr<policy::URLBlacklist,std::default_delete<policy::URLBlacklist> > *),base::OnceCall [0x028E527B+27]
	base::internal::CallbackBase::~CallbackBase [0x03D50949+25]
	base::internal::PostTaskAndReplyImpl::PostTaskAndReply [0x04DBEE94+1508]
	base::internal::PostTaskAndReplyImpl::PostTaskAndReply [0x04DBF073+1987]
	base::internal::CallbackBase::~CallbackBase [0x03D50949+25]
	base::internal::IncomingTaskQueue::TriageQueue::Clear [0x04DAB117+375]
	base::MessageLoop::DeletePendingTasks [0x03D78AE5+101]
	base::MessageLoop::~MessageLoop [0x03D7A817+247]
	base::MessageLoopForUI::`scalar deleting destructor' [0x03C6F99B+11]
	content::ContentMainRunnerImpl::Shutdown [0x03D0C31E+222]
	service_manager::Main [0x04412CBC+1484]
	content::ContentMain [0x03D0B813+51]
	content::BrowserTestBase::SetUp [0x03E5C8A6+1942]
	InProcessBrowserTest::SetUp [0x03E1F786+566]
	testing::Test::Run [0x01F58860+112]

Sample log:
- https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940725578280000272/+/steps/browser_tests__with_patch_/0/stdout

where 32 irrelevant tests hit this DCHECK with the same stack trace posted above:
- ChromeSSLHostStateDelegateTest.Clear
- AuthenticatorDialogTest.InvokeUi_ble_enter_pairing_mode
- InfoBarUiTest.InvokeUi_outdated_plugin
- IdentityGetProfileUserInfoFunctionTest.SignedIn
- ManifestVerifierBrowserTest.BobPayCanUseAnyMethodOnOwnOrigin
- AutocompleteBrowserTest.TabAwayRevertSelect
...

Comment 1 by xiaoche...@chromium.org, Jul 17 

 Issue 864691  has been merged into this issue.

Comment 2 by xiaoche...@chromium.org, Jul 17

Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
sky@: as chrome/test/ owner, could you take a look?

Comment 3 by xiaoche...@chromium.org, Jul 17

Labels: OS-Linux
Also seen elsewhere.

win_chromium_dbg_ng:
- https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940750453231147040/+/steps/browser_tests__with_patch_/0/stdout

linux_chromium_rel_ng:
- https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940721550175878496/+/steps/browser_tests__with_patch_/0/stdout

Didn't see the same crash on Mac or ChromeOS. There's a similar crash on ChromeOS, though, that hits the same DCHECK during RefCountedBase::AddRef()

Comment 4 by sky@chromium.org, Jul 17

Owner: azurewei@chromium.org
chrome/test is a very general place to pick an owner from. In the future I encourage you to pick an owner for the failing test. The failing test is InputImeApiTest.SendKeyEventsOnSpecialPage. azurewei@ seems to have touched the file quite a bit, passing to azurewei.

Comment 5 by xiaoche...@chromium.org, Jul 17

Owner: mastiz@chromium.org
mastiz@: You recently introduced BlockingModelTypeStoreImpl, which appears in the stack trace.

Could you take a look?

Comment 6 by xiaoche...@chromium.org, Jul 17

Description: Show this description

Comment 7 by mastiz@chromium.org, Jul 18

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1a67afa46e33d019f1efa14235ea260478e62c

commit 7a1a67afa46e33d019f1efa14235ea260478e62c
Author: Mikel Astiz <mastiz@chromium.org>
Date: Wed Jul 18 08:09:54 2018

Use thread-safe refcounting for ModelTypeStoreBackend

This partially reverts a recent change in
https://chromium-review.googlesource.com/1129800 which is believed to
cause test flakes.

Bug:  864733 
Change-Id: I2885a1527c56cf14d6d190af0b7667c7b6da56a5
Reviewed-on: https://chromium-review.googlesource.com/1141564
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575976}
[modify] https://crrev.com/7a1a67afa46e33d019f1efa14235ea260478e62c/components/sync/model_impl/model_type_store_backend.h

Comment 9 by mastiz@chromium.org, Jul 18

Status: Fixed (was: Started)
Optimistically marking as fixed, will keep an eye to confirm the flakes don't persist.
►

Sign in to add a comment