In-session app that allows users to select from a list of modules and perform any of them.
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ad3b577f30e651ab5ca705d753a482bfb8b362a commit 5ad3b577f30e651ab5ca705d753a482bfb8b362a Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Aug 21 03:38:40 2018 Chrome OS: Fix a few minor issues in oobe-dialog attributes. min-height/min-width => height/width if(getAttribute) => if(hasAttribute) Bug: 864686 Change-Id: If179f64af2d3ced1f2902a6c1b205a37558f709c Reviewed-on: https://chromium-review.googlesource.com/1182502 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#584637} [modify] https://crrev.com/5ad3b577f30e651ab5ca705d753a482bfb8b362a/chrome/browser/resources/chromeos/login/oobe_dialog.js [modify] https://crrev.com/5ad3b577f30e651ab5ca705d753a482bfb8b362a/chrome/browser/resources/chromeos/login/oobe_dialog_host.css [modify] https://crrev.com/5ad3b577f30e651ab5ca705d753a482bfb8b362a/chrome/browser/resources/chromeos/login/oobe_dialog_host_behavior.js [modify] https://crrev.com/5ad3b577f30e651ab5ca705d753a482bfb8b362a/chrome/browser/resources/chromeos/login/oobe_welcome.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be6556aa4558be2e92b4ab1eb603fe3b0d8b3783 commit be6556aa4558be2e92b4ab1eb603fe3b0d8b3783 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Aug 22 00:15:32 2018 Chrome OS OOBE: Refactor initialization in oobe_ui. This CL splits CreateOobeUIDataSource into several smaller functions. Bug: 864686 Change-Id: I6843595bf66a9584778fa5ebbff8167a0ce605d2 Reviewed-on: https://chromium-review.googlesource.com/1182608 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584930} [modify] https://crrev.com/be6556aa4558be2e92b4ab1eb603fe3b0d8b3783/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/be6556aa4558be2e92b4ab1eb603fe3b0d8b3783/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f933e705ac1df88e16a927daf73970c69cd83d5a commit f933e705ac1df88e16a927daf73970c69cd83d5a Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Aug 24 22:59:29 2018 Chrome OS: Add Discover window UI. This CL adds Chrome OS Discover UI in separate window. Window need further changes to match the specs, but this change mostly adds infrastructure. Bug: 864686 Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262 Reviewed-on: https://chromium-review.googlesource.com/1182880 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586034} [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/ash/public/cpp/app_list/internal_app_id_constants.h [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/ash/public/cpp/resources/ash_public_unscaled_resources.grd [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/ash/public/cpp/resources/unscaled_resources/discover_app_logo_192.png [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/browser_resources.grd [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/ash/launcher/discover_window_observer.cc [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/ash/launcher/discover_window_observer.h [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.cc [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.h [add] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager_observer.h [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/common/webui_url_constants.cc [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/chrome/common/webui_url_constants.h [modify] https://crrev.com/f933e705ac1df88e16a927daf73970c69cd83d5a/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/364fcc2068746b09b7d251fed70c01ced6e52f10 commit 364fcc2068746b09b7d251fed70c01ced6e52f10 Author: Scott Little <sclittle@chromium.org> Date: Fri Aug 24 23:28:31 2018 Revert "Chrome OS: Add Discover window UI." This reverts commit f933e705ac1df88e16a927daf73970c69cd83d5a. Reason for revert: Broke compile on Google Chrome ChromeOS bot: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/55439 Original change's description: > Chrome OS: Add Discover window UI. > > This CL adds Chrome OS Discover UI in separate window. > > Window need further changes to match the specs, but this > change mostly adds infrastructure. > > Bug: 864686 > > Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262 > Reviewed-on: https://chromium-review.googlesource.com/1182880 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586034} TBR=xiyuan@chromium.org,isherman@chromium.org,alemate@chromium.org Change-Id: Idaaf3bf2adf129d746de7a466d9c433ed52b41c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864686 Reviewed-on: https://chromium-review.googlesource.com/1189032 Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#586044} [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/ash/public/cpp/app_list/internal_app_id_constants.h [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/ash/public/cpp/resources/ash_public_unscaled_resources.grd [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/ash/public/cpp/resources/unscaled_resources/discover_app_logo_192.png [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/browser_resources.grd [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/chrome/browser/ui/ash/launcher/discover_window_observer.cc [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/chrome/browser/ui/ash/launcher/discover_window_observer.h [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.cc [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.h [delete] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager_observer.h [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/common/webui_url_constants.cc [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/chrome/common/webui_url_constants.h [modify] https://crrev.com/364fcc2068746b09b7d251fed70c01ced6e52f10/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a531e948bf1c3230aa78043cf8d4937d8d9db46c commit a531e948bf1c3230aa78043cf8d4937d8d9db46c Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 25 01:47:21 2018 Reland "Chrome OS: Add Discover window UI." This is a reland of f933e705ac1df88e16a927daf73970c69cd83d5a Original change's description: > Chrome OS: Add Discover window UI. > > This CL adds Chrome OS Discover UI in separate window. > > Window need further changes to match the specs, but this > change mostly adds infrastructure. > > Bug: 864686 > > Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262 > Reviewed-on: https://chromium-review.googlesource.com/1182880 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586034} TBR=isherman@chromium.org,xiyuan@chromium.org Bug: 864686 Change-Id: I384e150da88aa60b09a5ed93b06403f2bab8e4eb Reviewed-on: https://chromium-review.googlesource.com/1189166 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#586099} [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/ash/public/cpp/app_list/internal_app_id_constants.h [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/ash/public/cpp/resources/ash_public_unscaled_resources.grd [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/ash/public/cpp/resources/unscaled_resources/discover_app_logo_192.png [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/browser_resources.grd [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/ash/launcher/discover_window_observer.cc [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/ash/launcher/discover_window_observer.h [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.cc [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.h [add] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager_observer.h [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/common/webui_url_constants.cc [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/chrome/common/webui_url_constants.h [modify] https://crrev.com/a531e948bf1c3230aa78043cf8d4937d8d9db46c/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d commit aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 25 02:41:48 2018 Chrome OS: Update Discover code, make it loadable as a separate source. This CL updates OOBE Discover code to make it loadable as an app. Bug: 864686 Change-Id: I1e9840041f193ce2d69e0defd34f2ab56f8dcbb1 Reviewed-on: https://chromium-review.googlesource.com/1186185 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586112} [add] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_app.css [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_app.html [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_app.js [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_card.css [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_card.html [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_components.js [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js [add] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_ui.css [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_ui.html [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/discover/discover_ui.js [modify] https://crrev.com/aed5ae4ae2e89b7bb04af47bbf9a1171cb0b946d/chrome/browser/resources/chromeos/login/oobe_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c6c22bc04a29388d9a2d75a5759089697c86761 commit 9c6c22bc04a29388d9a2d75a5759089697c86761 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 25 04:15:35 2018 Chrome OS: Update Discover Welcome module code to latest specs. This Cl updates Chrome OS Discover Welcome module code to match the latest specs. Bug: 864686 Change-Id: Icbfb4c98976055daaa49bce51e1eb399aa6da078 Reviewed-on: https://chromium-review.googlesource.com/1186188 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586117} [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_SUBTITLE.png.sha1 [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_TITLE.png.sha1 [delete] https://crrev.com/4e71dae7cedd62d6fc123939d8e4929bebe6e706/chrome/browser/resources/chromeos/login/discover/discover_card_host.css [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/browser/resources/chromeos/login/discover/discover_welcome.css [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/browser/resources/chromeos/login/discover/discover_welcome.html [modify] https://crrev.com/9c6c22bc04a29388d9a2d75a5759089697c86761/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b414e94d4c4062f535903a14f6b7fee18ca9d06 commit 9b414e94d4c4062f535903a14f6b7fee18ca9d06 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Nov 08 22:46:16 2018 Chrome OS: hide PIN setup card from Discover App. Bug: 864686 Change-Id: I7032bd335ea625683176fc4d71c5285edecfc117 Reviewed-on: https://chromium-review.googlesource.com/c/1326224 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#606629} [modify] https://crrev.com/9b414e94d4c4062f535903a14f6b7fee18ca9d06/chrome/browser/resources/chromeos/login/discover/discover_ui.html [modify] https://crrev.com/9b414e94d4c4062f535903a14f6b7fee18ca9d06/chrome/browser/resources/chromeos/login/discover/discover_welcome.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38e1e0a8c37d61ddf313461c81d91fc44e186dea commit 38e1e0a8c37d61ddf313461c81d91fc44e186dea Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Nov 08 22:48:48 2018 Chrome OS: Convert kEnableDiscoverApp flag to feature. This CL converts discover App flag to feature and enabled it by default. Bug: 864686 Change-Id: Idf8dcce4982a16f92ed7b012525484963f799710 Reviewed-on: https://chromium-review.googlesource.com/c/1326221 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#606633} [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chrome/browser/about_flags.cc [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chrome/browser/flag_descriptions.h [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chromeos/chromeos_features.cc [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chromeos/chromeos_features.h [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chromeos/chromeos_switches.cc [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/chromeos/chromeos_switches.h [modify] https://crrev.com/38e1e0a8c37d61ddf313461c81d91fc44e186dea/tools/metrics/histograms/enums.xml
Comment 1 by benhenry@chromium.org
, Aug 3