New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864684 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 828999



Sign in to add a comment

Create show off module framework

Project Member Reported by zalcorn@chromium.org, Jul 17

Issue description

Allows modules to appear in first run and from app.
Supports both link and wizard modules.
Ensures modules are easy to add for any crOS team.

 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/browser_internal/+/a40811564a3df43500d646a476795225c81397ac

commit a40811564a3df43500d646a476795225c81397ac
Author: Alexander Alekseev <alemate@google.com>
Date: Mon Aug 20 13:50:41 2018

Labels: -M-70 CrOSShowOff M-71
Components: Platform>Apps>ShowOff
Components: -UI>Shell>OOBE
Labels: -M-71
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f

commit 851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Jan 07 20:08:19 2019

Chrome OS Discover App: Add test infrastructure.

This Cl adds browser_test infrastructure to Discover App and tests for existing
modules.

Bug: 864684
Change-Id: Ic20dc878d0435636d627d0b5917602f915deb204
Reviewed-on: https://chromium-review.googlesource.com/c/1391362
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620442}
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/discover_browser_test.cc
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/discover_browser_test.h
[modify] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
[modify] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.h
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app_test.cc
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers_test.cc
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files_test.cc
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/wait_for_did_start_navigate.cc
[add] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover/wait_for_did_start_navigate.h
[modify] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/browser/ui/webui/chromeos/login/discover_screen_handler.cc
[modify] https://crrev.com/851b7c1f81a6e796e4f1ee6bbc5e05dbc9f03c3f/chrome/test/BUILD.gn

Sign in to add a comment